snapcraft:fix-elf-regression

Last commit made on 2020-02-04
Get this branch:
git clone -b fix-elf-regression https://git.launchpad.net/snapcraft

Branch merges

Branch information

Name:
fix-elf-regression
Repository:
lp:snapcraft

Recent commits

3a55d1b... by Sergio Schvezov

use a generator for any

f2ddec5... by Sergio Schvezov

elf: search for host libraries within search paths

A regression was introduced with commit 76e8a3f3f1c3f69d957b2806c9387ac3c57e926a
which considered elf files on the host system to be valid. Additionally, since
the host-found libraries were absolute paths, an os.path.join suffixing the
search paths snapcraft cared about were ignored.

A unit test which considers this scenario was added.

LP: #1860766

Signed-off-by: Sergio Schvezov <email address hidden>

c13c79d... by Sergio Schvezov

python plugin: do not leak snapcraft's site-packages (#2901)

The current sitecustomize generated by the python plugin always considers
adding site-packages from $SNAP which is only meant for runtime. This is a
problem as snapcraft runs in the context of a snap, so $SNAP always exists
in the environment.

When building, snapcraft relies on build time environment in sitecustomize,
use this as a condition to export site-packages found under $SNAP.

LP: #1860884

Signed-off-by: Sergio Schvezov <email address hidden>

2aadaf2... by Sergio Schvezov

ci: publish the CI built snap to the Snap Store (#2900)

It is often useful to allow for the snap being built during a PR review to be
available on the Snap Store.

This change should make version of each run through Travis CI available on the
edge/pr-$TRAVIS_PULL_REQUEST (e.g.; edge/pr-1050).

Signed-off-by: Sergio Schvezov <email address hidden>

0f04924... by Sergio Schvezov

tests: fix status test for staging store (#2903)

Signed-off-by: Sergio Schvezov <email address hidden>

1e95505... by Chris Patterson

requirements: uprev pyinstaller to 3.6 (#2905)

Signed-off-by: Chris Patterson <email address hidden>

cfa69b1... by Sergio Schvezov

static: fix some valid flake8 issues (#2902)

This was mostly from running a flake8 from 3.9, but they are valid issue to
fix nonetheless.

Running flake8
./snapcraft/plugins/catkin.py:82:1: F401 'typing.Set' imported but unused
./snapcraft/plugins/_python/_pip.py:28:1: F401 'typing.Dict' imported but unused
./snapcraft/project/errors.py:19:1: F401 'typing.Dict' imported but unused
./snapcraft/project/errors.py:19:1: F401 'typing.List' imported but unused
./snapcraft/internal/project_loader/_config.py:24:1:
    F401 'typing.List' imported but unused
./snapcraft/internal/project_loader/_config.py:24:1:
    F401 'typing.Set' imported but unused
./snapcraft/internal/lifecycle/_status_cache.py:19:1:
    F401 'typing.List' imported but unused

Signed-off-by: Sergio Schvezov <email address hidden>

921d0f1... by Chris Patterson

meta: remove dead code from snap packaging (#2898)

Remove unused _wrap_exe() and _find_bin().

Signed-off-by: Chris Patterson <email address hidden>

bfac28c... by Chris Patterson

meta: include environment in hook wrappers (#2897)

Snapcraft regressed in how it handled environment for app wrappers and
hook wrappers in that is no longer includes it for hooks (only apps).
Add back the environment inclusion for hooks.

LP: #1824255

Co-authored-by: Kyle Fazzari <email address hidden>
Signed-off-by: Chris Patterson <email address hidden>

d76f734... by Chris Patterson

lifecycle: raise detailed error if mksquashfs fails (#2895)

Sentry is full of bug reports related to RuntimeError for failing
to execute mksquashfs. However, there is no clue as to the failure,
because snapcraft just prints it to logger. Instead of logging the
error, include the output as part of the raised RuntimeError.

If we can get a better idea of the nature of the failures, we can
further refine handling here.

Signed-off-by: Chris Patterson <email address hidden>