Phablet Tools

Merge lp:~sergiusens/phablet-tools/shotspaces into lp:phablet-tools

  1. shotspaces
  2. Merge into trunk
Proposed by Sergio Schvezov
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 266
Merged at revision: 266
Proposed branch: lp:~sergiusens/phablet-tools/shotspaces
Merge into: lp:phablet-tools
Diff against target: 29 lines (+3/-3)
1 file modified
phablet-screenshot (+3/-3)
To merge this branch: bzr merge lp:~sergiusens/phablet-tools/shotspaces
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
Review via email: mp+215771@code.launchpad.net

Commit message

phablet-screenshot: allow spaces in file names and path

To post a comment you must log in.
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Works fine, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'phablet-screenshot'
2--- phablet-screenshot 2014-04-14 19:22:18 +0000
3+++ phablet-screenshot 2014-04-14 22:22:15 +0000
4@@ -113,7 +113,7 @@
5 adb $ADBOPTS pull /tmp/mir_screencast_$1.$sfx ${PICDIR}/fb
6
7 [ ! -e "${PICDIR}/fb" ] && echo "E: Capture failed!" && return
8- convert $CONVERTOPTS $sfx:${PICDIR}/fb[0] $DST
9+ convert $CONVERTOPTS $sfx:${PICDIR}/fb[0] "$DST"
10 }
11
12 get_device() {
13@@ -130,7 +130,7 @@
14 adb $ADBOPTS pull /tmp/$capfile ${PICDIR}/$capfile
15
16 [ ! -e "${PICDIR}/${capfile}" ] && echo "E: Capture failed!" && return
17- convert $CONVERTOPTS ${PICDIR}/$capfile $DST
18+ convert $CONVERTOPTS ${PICDIR}/$capfile "$DST"
19 }
20
21 SHORTOPTS="hdr:s:z:"
22@@ -162,7 +162,7 @@
23 done
24
25 [ $# -eq 0 ] && usage
26-DST=$1
27+DST="$1"
28
29 check_prerequisites
30

Subscribers

People subscribed via source and target branches