Merge lp:~sergiusens/phablet-tools/package_install into lp:phablet-tools

Proposed by Sergio Schvezov on 2014-04-14
Status: Needs review
Proposed branch: lp:~sergiusens/phablet-tools/package_install
Merge into: lp:phablet-tools
Diff against target: 13 lines (+1/-2)
1 file modified
phablet-config (+1/-2)
To merge this branch: bzr merge lp:~sergiusens/phablet-tools/package_install
Reviewer Review Type Date Requested Status
Paul Larson (community) Needs Fixing on 2014-04-15
Ricardo Salveti 2014-04-14 Approve on 2014-04-15
PS Jenkins bot continuous-integration Approve on 2014-04-14
Review via email: mp+215777@code.launchpad.net

Commit message

phablet-config: always apt-get update if packages need to be installed after writable image is set

To post a comment you must log in.
Ricardo Salveti (rsalveti) wrote :

Good, thanks.

review: Approve
Paul Larson (pwlars) wrote :

If I'm reading this correctly, this would cause every writable image to also run apt-get update. As asac mentioned on IRC, that would not be good, since it could cause unwanted updates to come in when autopilot debs are installed for those packages that still use debs for their tests.

review: Needs Fixing
Ricardo Salveti (rsalveti) wrote :

I don't think this is an issue, but indeed it might cause other side effects we're not yet able to handle.

The problem of not updating the archive index is that it might not be able to find the desirable packages, which is also a problem. If the testing tool really want to make sure a specific version is installed, it should for that instead.

Unmerged revisions

266. By Sergio Schvezov on 2014-04-14

phablet-config: always apt-get update if packages need to be installed after writable image is set

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'phablet-config'
--- phablet-config 2013-12-12 23:45:16 +0000
+++ phablet-config 2014-04-14 23:30:54 +0000
@@ -154,8 +154,7 @@
154 for ppa in args.ppa:154 for ppa in args.ppa:
155 adb.shell('add-apt-repository -y %s' % ppa, False)155 adb.shell('add-apt-repository -y %s' % ppa, False)
156156
157 if args.package_dir or args.ppa:157 adb.shell('apt-get update -qq')
158 adb.shell('apt-get update -qq')
159158
160 if args.package:159 if args.package:
161 package = ' '.join(args.package)160 package = ' '.join(args.package)

Subscribers

People subscribed via source and target branches