Merge lp:~sergiusens/phablet-tools/package_install into lp:phablet-tools

[Sergio Schvezov]

phablet-config: always apt-get update if packages need to be installed after writable image is set

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:266
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/310/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-amd64-ci/82
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-armhf-ci/82
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-i386-ci/82

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/310/rebuild

review: Approve (continuous-integration)

[Ricardo Salveti (rsalveti)]

Good, thanks.

review: Approve

[Paul Larson (pwlars)]

If I'm reading this correctly, this would cause every writable image to also run apt-get update. As asac mentioned on IRC, that would not be good, since it could cause unwanted updates to come in when autopilot debs are installed for those packages that still use debs for their tests.

review: Needs Fixing

[Ricardo Salveti (rsalveti)]

I don't think this is an issue, but indeed it might cause other side effects we're not yet able to handle.

The problem of not updating the archive index is that it might not be able to find the desirable packages, which is also a problem. If the testing tool really want to make sure a specific version is installed, it should for that instead.

Unmerged revisions

266. By Sergio Schvezov on 2014-04-14

phablet-config: always apt-get update if packages need to be installed after writable image is set

=== modified file 'phablet-config'
--- phablet-config	2013-12-12 23:45:16 +0000
+++ phablet-config	2014-04-14 23:30:54 +0000
@@ -154,8 +154,7 @@
             for ppa in args.ppa:
                 adb.shell('add-apt-repository -y %s' % ppa, False)
 
-        if args.package_dir or args.ppa:
-            adb.shell('apt-get update -qq')
+        adb.shell('apt-get update -qq')
 
         if args.package:
             package = ' '.join(args.package)