Merge lp:~sergiusens/phablet-tools/no_validate_bootstrap into lp:phablet-tools

Proposed by Sergio Schvezov
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 97
Merged at revision: 97
Proposed branch: lp:~sergiusens/phablet-tools/no_validate_bootstrap
Merge into: lp:phablet-tools
Diff against target: 36 lines (+5/-5)
1 file modified
phablet-flash (+5/-5)
To merge this branch: bzr merge lp:~sergiusens/phablet-tools/no_validate_bootstrap
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+165589@code.launchpad.net

Commit message

Don't validate device when bootstraping and move wait logic to only happen when needed which was increased to 15.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gema Gomez (gema) wrote :

I have tested the change and it works fine for me. Now I can use the -b flag on mako successfully. +1

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

LGTM, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'phablet-flash'
2--- phablet-flash 2013-05-21 15:34:15 +0000
3+++ phablet-flash 2013-05-24 12:11:36 +0000
4@@ -218,10 +218,12 @@
5 ''' Pushes artifact to devices sdcard and deploys'''
6 if not artifact:
7 return
8+ # Can't wait-for-device here
9+ sleep(15)
10 adb.push(artifact, '/sdcard/autodeploy.zip')
11 log.info('Deploying Ubuntu')
12- adb.shell('/sbin/recovery')
13- log.info('Installation complete, rebooting into Ubuntu')
14+ adb.reboot(recovery=True)
15+ log.info('Installation will complete soon and reboot into Ubuntu')
16
17
18 @adb_errors
19@@ -356,7 +358,7 @@
20 # Initializes the adb server if it is not running
21 adb.start()
22 device = detect_device(adb, args.device)
23- if not args.download_only:
24+ if not args.download_only and not args.bootstrap:
25 if settings.validate_device:
26 validate_device(adb)
27 if not args.series:
28@@ -411,8 +413,6 @@
29 if args.bootstrap:
30 fastboot = Fastboot(args.device)
31 bootstrap(adb, fastboot, download_mgr.files)
32- # Can't wait-for-device here
33- sleep(10)
34 autodeploy(adb, download_mgr.files.get(ubuntu_img))
35 else:
36 recovery_file = create_recovery_file(adb,

Subscribers

People subscribed via source and target branches