Merge lp:~sergiusens/phablet-tools/image_updates into lp:phablet-tools

Proposed by Sergio Schvezov
Status: Merged
Approved by: Sergio Schvezov
Approved revision: 141
Merged at revision: 139
Proposed branch: lp:~sergiusens/phablet-tools/image_updates
Merge into: lp:phablet-tools
Diff against target: 80 lines (+26/-10)
3 files modified
phablet-flash (+6/-4)
phabletutils/downloads.py (+2/-1)
phabletutils/ubuntuimage.py (+18/-5)
To merge this branch: bzr merge lp:~sergiusens/phablet-tools/image_updates
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Stéphane Graber Approve
Ubuntu Phablet Team Pending
Review via email: mp+175960@code.launchpad.net

Commit message

Added image signing and master download and copy to device

To post a comment you must log in.
140. By Sergio Schvezov

Uncomment the downloader.download statement

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
141. By Sergio Schvezov

Downloading the right files.

Revision history for this message
Stéphane Graber (stgraber) wrote :

Looks good to me.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'phablet-flash'
2--- phablet-flash 2013-07-19 01:33:58 +0000
3+++ phablet-flash 2013-07-19 22:57:26 +0000
4@@ -357,7 +357,8 @@
5 str(json_latest['version'])))
6 setup_download_directory(download_dir)
7 files = ubuntuimage.download_images(download_dir, json_latest)
8- ubuntu_command_path = create_ubuntu_command_file(download_dir, files)
9+ ubuntu_command_path = create_ubuntu_command_file(download_dir,
10+ files['updates'])
11 return files, ubuntu_command_path
12
13
14@@ -365,9 +366,10 @@
15 ubuntu_command_path):
16 adb.reboot(recovery=True)
17 wipe_device(adb)
18- for entry in files:
19- adb.push(entry['filename'], '/cache/recovery/')
20- adb.push(entry['signame'], '/cache/recovery/')
21+ for key in files:
22+ for entry in files[key]:
23+ adb.push(entry['filename'], '/cache/recovery/')
24+ adb.push(entry['signame'], '/cache/recovery/')
25 adb.push(ubuntu_command_path, '/cache/recovery/ubuntu_command')
26 adb.reboot(bootloader=True)
27 fastboot.flash('recovery', recovery_img)
28
29=== modified file 'phabletutils/downloads.py'
30--- phabletutils/downloads.py 2013-07-11 03:26:21 +0000
31+++ phabletutils/downloads.py 2013-07-19 22:57:26 +0000
32@@ -25,7 +25,8 @@
33 def download(uri, target):
34 '''Downloads an artifact into target.'''
35 log.info('Downloading %s' % uri)
36- if uri.startswith('http://cdimage.ubuntu.com'):
37+ if uri.startswith('http://cdimage.ubuntu.com') or \
38+ uri.startswith('https://system-image.ubuntu.com'):
39 subprocess.check_call(['wget', '-c', uri, '-O', target])
40 else:
41 subprocess.check_call(['curl', '-L', '-C', '-', uri, '-o', target])
42
43=== modified file 'phabletutils/ubuntuimage.py'
44--- phabletutils/ubuntuimage.py 2013-07-19 01:32:59 +0000
45+++ phabletutils/ubuntuimage.py 2013-07-19 22:57:26 +0000
46@@ -33,7 +33,8 @@
47
48
49 def download_images(download_dir, json_list):
50- files = []
51+ files = {}
52+ files['updates'] = []
53 for entry in sorted(json_list['files'], key=lambda entry: entry['order']):
54 filename = entry['path'].split("/")[-1]
55 signame = entry['signature'].split("/")[-1]
56@@ -41,8 +42,20 @@
57 signame_path = os.path.join(download_dir, signame)
58 filename_uri = '%s/%s' % (settings.system_image_uri, entry['path'])
59 signame_uri = '%s/%s' % (settings.system_image_uri, entry['signature'])
60-
61- downloads.download(filename_uri, filename_path)
62- downloads.download(signame_uri, signame_path)
63- files.append({'filename': filename_path, 'signame': signame_path})
64+ downloads.download(filename_uri, filename_path)
65+ downloads.download(signame_uri, signame_path)
66+ files['updates'].append({'filename': filename_path,
67+ 'signame': signame_path})
68+ files['base'] = []
69+ for keyring in ('image-master', 'image-signing'):
70+ filename = '%s.tar.xz' % keyring
71+ signame = '%s.asc' % filename
72+ filename_path = os.path.join(download_dir, filename)
73+ signame_path = os.path.join(download_dir, signame)
74+ filename_uri = '%s/gpg/%s' % (settings.system_image_uri, filename)
75+ signame_uri = '%s.asc' % filename_uri
76+ downloads.download(filename_uri, filename_path)
77+ downloads.download(signame_uri, signame_path)
78+ files['base'].append({'filename': filename_path,
79+ 'signame': signame_path})
80 return files

Subscribers

People subscribed via source and target branches