Merge lp:~sergiusens/phablet-tools/grab_latest into lp:phablet-tools

Proposed by Sergio Schvezov
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 72
Merged at revision: 72
Proposed branch: lp:~sergiusens/phablet-tools/grab_latest
Merge into: lp:phablet-tools
Diff against target: 37 lines (+8/-1)
2 files modified
debian/changelog (+5/-0)
phablet-flash (+3/-1)
To merge this branch: bzr merge lp:~sergiusens/phablet-tools/grab_latest
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+156837@code.launchpad.net

Commit message

Grabbing the latest is now the default. The option is marked as deprecated.

Description of the change

Grabbing the latest build is going to be the default action, to grab a tagged build -r is going to be reworked to fetch for tags, although -u 'download path' should also suffice for the purpose.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
72. By Sergio Schvezov

Merging trunk. Re arranging original changelog

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Shouldn't we remove the pieces from mwc or at least have that as an option?

review: Needs Information
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

> Shouldn't we remove the pieces from mwc or at least have that as an option?

What pieces exactly? there's another bug to make -r download from a tag, so you can do

phablet-flash -r mwc-demo

I'll do that fixing there.

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

download_uri points out to mwc-demo for example.

Ok, will check your other mr later then ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-02 19:16:40 +0000
3+++ debian/changelog 2013-04-03 13:11:21 +0000
4@@ -1,5 +1,6 @@
5 phablet-tools (0.9-0phablet1) UNRELEASED; urgency=low
6
7+ [ Mathieu Trudel-Lapierre ]
8 * debian/control:
9 - Wrap and sort Depends/Build-Depends, use trailing commas.
10 - Add/Update Vcs-Bzr, Vcs-Browser, add comment to developers.
11@@ -7,6 +8,10 @@
12 * debian/rules:
13 - Override dh_install to use --fail-missing.
14
15+ [ Sergio Schvezov ]
16+ * Grabbing the latest is now the default (LP: #1163274)
17+ - The -l option is now deprecated
18+
19 -- Mathieu Trudel-Lapierre <mathieu-tl@ubuntu.com> Mon, 25 Mar 2013 14:31:18 -0400
20
21 phablet-tools (0.8-0phablet2) raring; urgency=low
22
23=== modified file 'phablet-flash'
24--- phablet-flash 2013-03-27 00:10:57 +0000
25+++ phablet-flash 2013-04-03 13:11:21 +0000
26@@ -80,8 +80,10 @@
27 action='store_const',
28 const=settings.daily_uri,
29 required=False,
30+ default=settings.daily_uri,
31 dest='uri',
32- help='''Pulls the latest daily image.'''
33+ help='''(DEPRECATED) Pulls the latest daily image.
34+ This is the default action.'''
35 )
36 group.add_argument('-p',
37 '--base-path',

Subscribers

People subscribed via source and target branches