Merge lp:~sergiusens/nuntium/not_attached into lp:nuntium

Proposed by Sergio Schvezov
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 83
Merged at revision: 78
Proposed branch: lp:~sergiusens/nuntium/not_attached
Merge into: lp:nuntium
Prerequisite: lp:~sergiusens/nuntium/deactivate
Diff against target: 20 lines (+2/-1)
1 file modified
ofono/modem.go (+2/-1)
To merge this branch: bzr merge lp:~sergiusens/nuntium/not_attached
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+236767@code.launchpad.net

Commit message

Retry on NotAttached ofono errors

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

LGTM

review: Approve
lp:~sergiusens/nuntium/not_attached updated
84. By Sergio Schvezov

bzr pump

85. By Sergio Schvezov

format fix

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ofono/modem.go'
2--- ofono/modem.go 2014-10-02 01:24:38 +0000
3+++ ofono/modem.go 2014-10-02 01:24:38 +0000
4@@ -42,6 +42,7 @@
5 const (
6 ofonoAttachInProgressError = "org.ofono.AttachInProgress"
7 ofonoInProgressError = "org.ofono.InProgress"
8+ ofonoNotAttachedError = "org.ofono.Error.NotAttached"
9 )
10
11 type OfonoContext struct {
12@@ -269,7 +270,7 @@
13
14 func activationErrorNeedsWait(err error) bool {
15 if dbusErr, ok := err.(*dbus.Error); ok {
16- return dbusErr.Name == ofonoInProgressError || dbusErr.Name == ofonoAttachInProgressError
17+ return dbusErr.Name == ofonoInProgressError || dbusErr.Name == ofonoAttachInProgressError || dbusErr.Name == ofonoNotAttachedError
18 }
19 return false
20 }

Subscribers

People subscribed via source and target branches