Merge lp:~sergiusens/nuntium/deactivate into lp:nuntium
Proposed by
Sergio Schvezov
Status: | Merged |
---|---|
Approved by: | Tony Espy |
Approved revision: | 84 |
Merged at revision: | 77 |
Proposed branch: | lp:~sergiusens/nuntium/deactivate |
Merge into: | lp:nuntium |
Prerequisite: | lp:~sergiusens/nuntium/select_that |
Diff against target: |
260 lines (+111/-37) 2 files modified
mediator.go (+24/-1) ofono/modem.go (+87/-36) |
To merge this branch: | bzr merge lp:~sergiusens/nuntium/deactivate |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alfonso Sanchez-Beato | Approve | ||
Tony Espy | Approve | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+236724@code.launchpad.net |
Commit message
Syncing upload/download operations with activation/
Moving all the ofono context property checks and reflection logic to proper functions for easier reuse and readability.
To post a comment you must log in.
PASSED: Continuous integration, rev:81 jenkins. qa.ubuntu. com/job/ nuntium- ci/16/ jenkins. qa.ubuntu. com/job/ nuntium- utopic- amd64-ci/ 16 jenkins. qa.ubuntu. com/job/ nuntium- utopic- armhf-ci/ 16 jenkins. qa.ubuntu. com/job/ nuntium- utopic- armhf-ci/ 16/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ nuntium- utopic- i386-ci/ 16
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/nuntium- ci/16/rebuild
http://