notes-app

Merge lp:~sergiusens/notes-app/app_domain into lp:notes-app

  1. app_domain
  2. Merge into trunk
Proposed by Sergio Schvezov
Status: Merged
Approved by: Olivier Tilloy
Approved revision: 209
Merged at revision: 206
Proposed branch: lp:~sergiusens/notes-app/app_domain
Merge into: lp:notes-app
Diff against target: 148 lines (+17/-17)
8 files modified
CMakeLists.txt (+1/-1)
NotesApp.qml (+1/-1)
debian/notes-app.install (+1/-1)
debian/rules (+1/-1)
notes-app.desktop.in (+1/-1)
po/CMakeLists.txt (+1/-1)
po/com.ubuntu.notes.pot (+10/-10)
tests/autopilot/notes_app/tests/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~sergiusens/notes-app/app_domain
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Olivier Tilloy Approve
David Planella (community) Approve
Review via email: mp+189798@code.launchpad.net

Commit message

Changing applicationName so QtStandardPaths writes to the apparmor confined locations. Making gettext domain follow this change

Description of the change

When built as a click package, the name of pkg name is set to com.ubuntu.notes

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:206
http://jenkins.qa.ubuntu.com/job/notes-app-ci/202/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4761/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2589/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/97/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/100/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/97/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/636/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2591/console

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/notes-app-ci/202/rebuild

review: Needs Fixing (continuous-integration)
lp:~sergiusens/notes-app/app_domain updated
207. By Sergio Schvezov

Fixing debian install for translations

Revision history for this message
Olivier Tilloy (osomon) wrote :

debian/notes-app.install needs updating (s/notes-app.mo/com.ubuntu.notes.mo/)

You also need to re-generate the pot file: in a clean source tree, run the following commands:

    bzr mv po/notes-app.pot po/com.ubuntu.notes.pot
    cmake .
    make com.ubuntu.notes.pot

review: Needs Fixing
Revision history for this message
Olivier Tilloy (osomon) wrote :

In po/CMakeLists.txt, the value passed to --package-name should probably be changed to "com.ubuntu.notes".

lp:~sergiusens/notes-app/app_domain updated
208. By Sergio Schvezov

Regenarating notes pot

209. By Sergio Schvezov

Changing package target

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:206
http://jenkins.qa.ubuntu.com/job/notes-app-ci/204/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4766
    None: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2595/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/99
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/102
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/102/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/99
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/946
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/641
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/641/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2597
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2597/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/notes-app-ci/204/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:209
http://jenkins.qa.ubuntu.com/job/notes-app-ci/205/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/4767
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/2596
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-amd64-ci/100
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/103
        deb: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-armhf-ci/103/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notes-app-saucy-i386-ci/100
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/947
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/642
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-amd64/642/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2598
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/2598/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2145
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/2158

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/notes-app-ci/205/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
David Planella (dpm) wrote :

This looks good to me, thanks!

The only area of concern that I've got is how Launchpad and other parts of the i18n infrastructure will handle the com.ubuntu.$APPNAME.pot domain/file name. The parts I'm thinking of for example are Launchpad and the (I think it's glib?) patch that loads translations specified in the desktop file as X-Gettext-Domain.

I don't think Launchpad will accept the dots in the name, so on the LP side we might have to manually rename the templates to be com-ubuntu.com-$APPNAME. Which will work, but it might be a bit of a burden to maintain. For now, I'll manually rename the template for the notes app to see how it works.

review: Approve
Revision history for this message
David Planella (dpm) wrote :

Done the changes on https://translations.launchpad.net/notes-app/trunk/+pots/com-ubuntu-notes but I'm not really sure how this will work out.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

> This looks good to me, thanks!
>
> The only area of concern that I've got is how Launchpad and other parts of the
> i18n infrastructure will handle the com.ubuntu.$APPNAME.pot domain/file name.
> The parts I'm thinking of for example are Launchpad and the (I think it's
> glib?) patch that loads translations specified in the desktop file as X
> -Gettext-Domain.

from the translation point of view, doing

LANGUAGE=es_ES notes-app

with this package just works

> I don't think Launchpad will accept the dots in the name, so on the LP side we
> might have to manually rename the templates to be com-ubuntu.com-$APPNAME.
> Which will work, but it might be a bit of a burden to maintain. For now, I'll
> manually rename the template for the notes app to see how it works.

Ack, I'm not familiar with this part of the infra, so I'll leave it to you.
we can always rename the pot at install time, right?

Revision history for this message
David Planella (dpm) wrote :

45 + $(MAKE) -C obj-$(DEB_HOST_GNU_TYPE) com.ubuntu.notes.pot

5 + $(MAKE) -C obj-$(DEB_HOST_GNU_TYPE) com.ubuntu.notes.pot

66 + --package-name=com.ubuntu.notes

I'm not familiar with CMake, but would it not make sense to put com.ubuntu.notes in a variable name rather than hardcoding it and repeating it multiple times? On autotools with gettext, this is generally defined as the GETTEXT_PACKAGE variable

Revision history for this message
Olivier Tilloy (osomon) wrote :

Looks good to me now.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-09-23 18:03:09 +0000
3+++ CMakeLists.txt 2013-10-08 10:38:14 +0000
4@@ -93,7 +93,7 @@
5
6 # for dh_translations to extract the domain
7 # (regarding syntax consistency, see http://pad.lv/1181187)
8-set (GETTEXT_PACKAGE "notes-app")
9+set (GETTEXT_PACKAGE "com.ubuntu.notes")
10
11 add_subdirectory(po)
12 add_subdirectory(click)
13
14=== modified file 'NotesApp.qml'
15--- NotesApp.qml 2013-08-30 07:18:41 +0000
16+++ NotesApp.qml 2013-10-08 10:38:14 +0000
17@@ -24,7 +24,7 @@
18
19 MainView {
20 id: notesMainWindow
21- applicationName: "notes-app"
22+ applicationName: "com.ubuntu.notes"
23 width: units.gu(40)
24 height: units.gu(71)
25 automaticOrientation: true
26
27=== modified file 'debian/notes-app.install'
28--- debian/notes-app.install 2013-05-20 11:26:53 +0000
29+++ debian/notes-app.install 2013-10-08 10:38:14 +0000
30@@ -2,4 +2,4 @@
31 usr/lib/*/qt5/qml/NotesApp
32 usr/share/applications/notes-app.desktop
33 usr/share/notes-app
34-usr/share/locale/*/LC_MESSAGES/notes-app.mo
35+usr/share/locale/*/LC_MESSAGES/com.ubuntu.notes.mo
36
37=== modified file 'debian/rules'
38--- debian/rules 2013-06-17 15:04:55 +0000
39+++ debian/rules 2013-10-08 10:38:14 +0000
40@@ -20,4 +20,4 @@
41 # Override dh_translations to work around http://pad.lv/1183262.
42 # Unfortunately, the default build directory is not exposed
43 # (see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=601774).
44- $(MAKE) -C obj-$(DEB_HOST_GNU_TYPE) notes-app.pot
45+ $(MAKE) -C obj-$(DEB_HOST_GNU_TYPE) com.ubuntu.notes.pot
46
47=== modified file 'notes-app.desktop.in'
48--- notes-app.desktop.in 2013-09-30 15:51:16 +0000
49+++ notes-app.desktop.in 2013-10-08 10:38:14 +0000
50@@ -9,5 +9,5 @@
51 Terminal=false
52 X-Ubuntu-Touch=true
53 X-Ubuntu-StageHint=SideStage
54-X-Ubuntu-Gettext-Domain=notes-app
55+X-Ubuntu-Gettext-Domain=com.ubuntu.notes
56 X-Ubuntu-Single-Instance=true
57
58=== modified file 'po/CMakeLists.txt'
59--- po/CMakeLists.txt 2013-06-17 15:04:55 +0000
60+++ po/CMakeLists.txt 2013-10-08 10:38:14 +0000
61@@ -13,7 +13,7 @@
62 --from-code=UTF-8
63 --c++ --qt --add-comments=TRANSLATORS
64 --keyword=tr --keyword=tr:1,2
65- --package-name=notes-app
66+ --package-name=com.ubuntu.notes
67 --copyright-holder='Canonical Ltd.'
68 ${I18N_SRC_FILES})
69
70
71=== renamed file 'po/notes-app.pot' => 'po/com.ubuntu.notes.pot'
72--- po/notes-app.pot 2013-06-17 15:35:29 +0000
73+++ po/com.ubuntu.notes.pot 2013-10-08 10:38:14 +0000
74@@ -8,7 +8,7 @@
75 msgstr ""
76 "Project-Id-Version: notes-app\n"
77 "Report-Msgid-Bugs-To: \n"
78-"POT-Creation-Date: 2013-06-17 17:34+0200\n"
79+"POT-Creation-Date: 2013-10-08 07:29-0300\n"
80 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
81 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
82 "Language-Team: LANGUAGE <LL@li.org>\n"
83@@ -17,19 +17,19 @@
84 "Content-Type: text/plain; charset=CHARSET\n"
85 "Content-Transfer-Encoding: 8bit\n"
86
87-#: Components/ClipboardPopover.qml:43
88+#: Components/ClipboardPopover.qml:42
89 msgid "Select All"
90 msgstr ""
91
92-#: Components/ClipboardPopover.qml:48
93+#: Components/ClipboardPopover.qml:47
94 msgid "Cut"
95 msgstr ""
96
97-#: Components/ClipboardPopover.qml:53
98+#: Components/ClipboardPopover.qml:52
99 msgid "Copy"
100 msgstr ""
101
102-#: Components/ClipboardPopover.qml:58
103+#: Components/ClipboardPopover.qml:57
104 msgid "Paste"
105 msgstr ""
106
107@@ -37,23 +37,23 @@
108 msgid "Clear"
109 msgstr ""
110
111-#: NotesApp.qml:39 NotesApp.qml:75
112+#: NotesApp.qml:34 NotesApp.qml:69
113 msgid "Add"
114 msgstr ""
115
116-#: NotesApp.qml:40
117+#: NotesApp.qml:35
118 msgid "Create New Note"
119 msgstr ""
120
121-#: NotesApp.qml:44
122+#: NotesApp.qml:39
123 msgid "Delete"
124 msgstr ""
125
126-#: NotesApp.qml:45
127+#: NotesApp.qml:40
128 msgid "Trash;Erase Note"
129 msgstr ""
130
131-#: NotesApp.qml:70 notes-app.desktop.in:6
132+#: NotesApp.qml:64 notes-app.desktop.in:6
133 msgid "Notes"
134 msgstr ""
135
136
137=== modified file 'tests/autopilot/notes_app/tests/__init__.py'
138--- tests/autopilot/notes_app/tests/__init__.py 2013-10-06 04:33:44 +0000
139+++ tests/autopilot/notes_app/tests/__init__.py 2013-10-08 10:38:14 +0000
140@@ -185,7 +185,7 @@
141
142 def _get_db_path(self):
143 db_path_list = [
144- "~/.local/share/notes-app/Databases",
145+ "~/.local/share/com.ubuntu.notes/Databases",
146 "~/.local/share/Qt Project/QtQmlViewer/QML/OfflineStorage/"
147 "Databases/"]
148 for path in db_path_list:

Subscribers

People subscribed via source and target branches