Merge lp:~sergiusens/livecd-rootfs/byeByeDebbie into lp:livecd-rootfs

Proposed by Sergio Schvezov on 2015-06-23
Status: Merged
Approved by: Oliver Grawert on 2015-06-25
Approved revision: 1153
Merged at revision: 1156
Proposed branch: lp:~sergiusens/livecd-rootfs/byeByeDebbie
Merge into: lp:livecd-rootfs
Diff against target: 28 lines (+24/-0)
1 file modified
live-build/ubuntu-core/hooks/600-no-debian.binary (+24/-0)
To merge this branch: bzr merge lp:~sergiusens/livecd-rootfs/byeByeDebbie
Reviewer Review Type Date Requested Status
Oliver Grawert 2015-06-23 Approve on 2015-06-25
Michael Vogt 2015-06-23 Pending
Review via email: mp+262786@code.launchpad.net
To post a comment you must log in.
Oliver Grawert (ogra) wrote :

why not just:

rm usr/bin/dpkg-*

Sergio Schvezov (sergiusens) wrote :

On Thu, Jun 25, 2015 at 10:53:14AM -0000, Oliver Grawert wrote:
> why not just:
>
> rm usr/bin/dpkg-*

I want to keep dpkg-deb for now so people can easily run

    dpkg-deb x [deb] /

Oliver Grawert (ogra) wrote :

ah, ok

review: Approve
Martin Pitt (pitti) wrote :

What is the rationale for killing dpkg-query? This makes it a lot harder to figure out the package versions when encountering/bisecting a regression, and also causes autopkgtest to fail (bug 1469647). Snappy is still built from debs, and that won't change anytime soon, so dropping dpkg-query seems overzealous to me.

Sergio Schvezov (sergiusens) wrote :

On Mon, Jun 29, 2015 at 10:27:07AM -0000, Martin Pitt wrote:
> What is the rationale for killing dpkg-query? This makes it a lot harder to figure out the package versions when encountering/bisecting a regression, and also causes autopkgtest to fail (bug 1469647). Snappy is still built from debs, and that won't change anytime soon, so dropping dpkg-query seems overzealous to me.

Is dpkg-query of any use if /var/lib/dpkg is not there anymore?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'live-build/ubuntu-core/hooks/600-no-debian.binary'
2--- live-build/ubuntu-core/hooks/600-no-debian.binary 1970-01-01 00:00:00 +0000
3+++ live-build/ubuntu-core/hooks/600-no-debian.binary 2015-06-23 19:33:29 +0000
4@@ -0,0 +1,24 @@
5+#!/bin/sh
6+#
7+# removing debian packaging artifacts
8+
9+set -ex
10+
11+echo "I: Removing the debian legacy"
12+
13+PREFIX=binary/boot/filesystem.dir
14+
15+# dpkg-deb and dpkg purposefully left behind
16+(cd $PREFIX
17+ chroot . dpkg --purge apt
18+ rm -r \
19+ var/lib/dpkg \
20+ var/log/apt
21+ rm \
22+ usr/bin/dpkg-query \
23+ usr/bin/dpkg-split \
24+ usr/bin/dpkg-divert \
25+ usr/bin/dpkg-trigger \
26+ usr/bin/dpkg-statoverride \
27+ usr/bin/dpkg-maintscript-helper
28+)

Subscribers

People subscribed via source and target branches