Merge lp:~sergiusens/goget-ubuntu-touch/automan into lp:goget-ubuntu-touch

Proposed by Sergio Schvezov
Status: Work in progress
Proposed branch: lp:~sergiusens/goget-ubuntu-touch/automan
Merge into: lp:goget-ubuntu-touch
Prerequisite: lp:~sergiusens/goget-ubuntu-touch/properDeps
Diff against target: 32 lines (+5/-8)
2 files modified
debian/rules (+4/-0)
ubuntu-device-flash/main.go (+1/-8)
To merge this branch: bzr merge lp:~sergiusens/goget-ubuntu-touch/automan
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Review via email: mp+256874@code.launchpad.net

Commit message

automan for ubuntu-device-flash

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

If you're going to generate debian/ubuntu-device-flash.1 as part of the dh_installman target, it's preferable to then also remove it on clean. The other option is to generate it on clean so that it's included in the source package.

review: Needs Fixing
172. By Sergio Schvezov

Generate manpage for u-d-f on dh_clean

Unmerged revisions

172. By Sergio Schvezov

Generate manpage for u-d-f on dh_clean

171. By Sergio Schvezov

Automan page for ubuntu-device-flash

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/rules'
2--- debian/rules 2014-10-15 12:42:09 +0000
3+++ debian/rules 2015-04-21 11:24:28 +0000
4@@ -15,3 +15,7 @@
5 rm -rf ${CURDIR}/debian/tmp/usr/share/gocode/src/launchpad.net/goget-ubuntu-touch/ubuntu-device-do
6 rm -rf ${CURDIR}/debian/tmp/usr/share/gocode/src/launchpad.net/goget-ubuntu-touch/diskimage
7 rm -rf ${CURDIR}/debian/tmp/usr/share/gocode/src/launchpad.net/goget-ubuntu-touch/sysutils
8+
9+override_dh_clean:
10+ MANPAGE=1 ${CURDIR}/debian/tmp/usr/bin/ubuntu-device-flash > ${CURDIR}/debian/ubuntu-device-flash.1
11+ dh_clean
12
13=== modified file 'ubuntu-device-flash/main.go'
14--- ubuntu-device-flash/main.go 2015-04-13 13:29:36 +0000
15+++ ubuntu-device-flash/main.go 2015-04-21 11:24:28 +0000
16@@ -46,15 +46,8 @@
17 args := os.Args
18
19 if v := os.Getenv("MANPAGE"); v != "" {
20- manpagePath := "/tmp/ubuntu-device-flash.manpage"
21- w, err := os.Create(manpagePath)
22- if err != nil {
23- fmt.Println(err)
24- return
25- }
26
27- parser.WriteManPage(w)
28- fmt.Println("Created manpage at", manpagePath)
29+ parser.WriteManPage(os.Stdout)
30
31 return
32 }

Subscribers

People subscribed via source and target branches