Merge lp:~sergiusens/goget-ubuntu-touch/1329374 into lp:goget-ubuntu-touch

Proposed by Sergio Schvezov
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 61
Merged at revision: 63
Proposed branch: lp:~sergiusens/goget-ubuntu-touch/1329374
Merge into: lp:goget-ubuntu-touch
Diff against target: 20 lines (+1/-2)
1 file modified
ubuntu-emulator/run.go (+1/-2)
To merge this branch: bzr merge lp:~sergiusens/goget-ubuntu-touch/1329374
Reviewer Review Type Date Requested Status
Ricardo Salveti (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+229890@code.launchpad.net

Commit message

Unhooking stdin from the emulator and removing -shell switch as it's not needed anymore

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Great, tested, works fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-emulator/run.go'
2--- ubuntu-emulator/run.go 2014-07-08 19:31:13 +0000
3+++ ubuntu-emulator/run.go 2014-08-07 02:52:59 +0000
4@@ -113,7 +113,7 @@
5 "-force-32bit", "-no-snapstorage",
6 "-gpu", "on",
7 "-scale", runCmd.Scale,
8- "-shell", "-no-jni", "-show-kernel", "-verbose",
9+ "-no-jni", "-show-kernel", "-verbose",
10 "-qemu",
11 }
12
13@@ -135,7 +135,6 @@
14 cmd := exec.Command(emulatorCmd, cmdOpts...)
15 cmd.Stdout = os.Stdout
16 cmd.Stderr = os.Stderr
17- cmd.Stdin = os.Stdin
18
19 if err := cmd.Run(); err != nil {
20 return err

Subscribers

People subscribed via source and target branches