Merge lp:~sergiusens/demo-assets/1182549 into lp:demo-assets

Proposed by Sergio Schvezov
Status: Merged
Approved by: Ricardo Salveti
Approved revision: 43
Merged at revision: 37
Proposed branch: lp:~sergiusens/demo-assets/1182549
Merge into: lp:demo-assets
Diff against target: 269 lines (+78/-35)
10 files modified
debian/changelog (+8/-0)
debian/control (+38/-5)
debian/demo-assets-contacts.install (+3/-0)
debian/demo-assets-music.install (+2/-0)
debian/demo-assets-pictures.install (+1/-0)
debian/demo-assets-shell.install (+2/-0)
debian/demo-assets-videos.install (+3/-0)
debian/demo-assets.install (+0/-9)
usr/bin/inject-data-into-friends-model (+1/-1)
usr/bin/manage-address-books (+20/-20)
To merge this branch: bzr merge lp:~sergiusens/demo-assets/1182549
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ricardo Salveti (community) Approve
Bill Filler (community) Approve
Review via email: mp+165500@code.launchpad.net

Commit message

Splitting all the packages into smaller ones and changing the contact address tool to be python3

To post a comment you must log in.
lp:~sergiusens/demo-assets/1182549 updated
40. By Sergio Schvezov

Marking for release

41. By Sergio Schvezov

Adding demo-assets-pictures

Revision history for this message
Bill Filler (bfiller) wrote :

approve

review: Approve
lp:~sergiusens/demo-assets/1182549 updated
42. By Sergio Schvezov

Changing demo-assets-shell description

43. By Sergio Schvezov

Making the transition package depend on the binary:Version of what it builds

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Good, built and tested fine.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-05-10 05:53:01 +0000
3+++ debian/changelog 2013-05-24 18:06:38 +0000
4@@ -1,3 +1,11 @@
5+demo-assets (0.24-0ubuntu1) raring; urgency=low
6+
7+ * Splitting up into multiple packages (LP: #1182549).
8+ * Updating packaging standards.
9+ * Updating contacts creation script to python3
10+
11+ -- Sergio Schvezov <sergio.schvezov@canonical.com> Thu, 23 May 2013 17:00:47 -0300
12+
13 demo-assets (0.24) raring; urgency=low
14
15 * drop users xml data and move backgrounds to /usr/share
16
17=== modified file 'debian/control'
18--- debian/control 2013-02-20 20:29:58 +0000
19+++ debian/control 2013-05-24 18:06:38 +0000
20@@ -4,11 +4,44 @@
21 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
22 XSBC-Original-Maintainer: Ricardo Mendoza <ricardo.mendoza@canonical.com>
23 Build-Depends: debhelper (>= 9.0.0)
24-Standards-Version: 3.9.3
25+Standards-Version: 3.9.4
26
27 Package: demo-assets
28 Architecture: all
29-Depends: ${shlibs:Depends}, ${misc:Depends}, unity-lens-mock
30-Description: Demo Assets
31- DEMO ONLY: Videos and images for demo applications
32-
33+Depends: demo-assets-shell (= ${binary:Version}),
34+ demo-assets-contacts (= ${binary:Version}),
35+ demo-assets-music (= ${binary:Version}),
36+ demo-assets-videos (= ${binary:Version}),
37+ demo-assets-pictures (= ${binary:Version}),
38+Description: Demo Assets transitionary package
39+ DEMO ONLY: Transition package that depends on all others.
40+
41+Package: demo-assets-shell
42+Architecture: all
43+Depends: ${shlibs:Depends}, ${misc:Depends}
44+Description: Demo Assets for Shell
45+ DEMO ONLY: infographics and backgrounds for greeter
46+
47+Package: demo-assets-contacts
48+Architecture: all
49+Depends: ${shlibs:Depends}, ${misc:Depends}, python3
50+Description: Demo Assets for Contacts
51+ DEMO ONLY: Contacts and fake conversations for demoing.
52+
53+Package: demo-assets-music
54+Architecture: all
55+Depends: ${shlibs:Depends}, ${misc:Depends}, unity-lens-mock
56+Description: Demo Assets for Music
57+ DEMO ONLY: Music mocks for the shell.
58+
59+Package: demo-assets-videos
60+Architecture: all
61+Depends: ${shlibs:Depends}, ${misc:Depends}, unity-lens-mock
62+Description: Demo Assets for Video
63+ DEMO ONLY: Video mocks for the shell.
64+
65+Package: demo-assets-pictures
66+Architecture: all
67+Depends: ${shlibs:Depends}, ${misc:Depends}, python3
68+Description: Demo Assets for Gallery
69+ DEMO ONLY: Fake pictures for demoing.
70
71=== added file 'debian/demo-assets-contacts.install'
72--- debian/demo-assets-contacts.install 1970-01-01 00:00:00 +0000
73+++ debian/demo-assets-contacts.install 2013-05-24 18:06:38 +0000
74@@ -0,0 +1,3 @@
75+contacts-data /usr/share/demo-assets/
76+telephony-app /usr/share/demo-assets/
77+/usr/bin
78
79=== added file 'debian/demo-assets-music.install'
80--- debian/demo-assets-music.install 1970-01-01 00:00:00 +0000
81+++ debian/demo-assets-music.install 2013-05-24 18:06:38 +0000
82@@ -0,0 +1,2 @@
83+services/com.canonical.Unity.Lens.MockMusic.service /usr/share/dbus-1/services
84+lenses/mockmusic /usr/share/unity/lenses
85
86=== added file 'debian/demo-assets-pictures.install'
87--- debian/demo-assets-pictures.install 1970-01-01 00:00:00 +0000
88+++ debian/demo-assets-pictures.install 2013-05-24 18:06:38 +0000
89@@ -0,0 +1,1 @@
90+pictures.tgz /usr/share/demo-assets/
91
92=== added file 'debian/demo-assets-shell.install'
93--- debian/demo-assets-shell.install 1970-01-01 00:00:00 +0000
94+++ debian/demo-assets-shell.install 2013-05-24 18:06:38 +0000
95@@ -0,0 +1,2 @@
96+shell/backgrounds/* /usr/share/backgrounds/
97+shell/infographics /usr/share/demo-assets/shell/
98
99=== added file 'debian/demo-assets-videos.install'
100--- debian/demo-assets-videos.install 1970-01-01 00:00:00 +0000
101+++ debian/demo-assets-videos.install 2013-05-24 18:06:38 +0000
102@@ -0,0 +1,3 @@
103+videos /usr/share/demo-assets/
104+services/com.canonical.Unity.Lens.MockVideos.service /usr/share/dbus-1/services
105+lenses/mockvideos /usr/share/unity/lenses
106
107=== removed file 'debian/demo-assets.install'
108--- debian/demo-assets.install 2013-05-10 05:53:01 +0000
109+++ debian/demo-assets.install 1970-01-01 00:00:00 +0000
110@@ -1,9 +0,0 @@
111-pictures.tgz /usr/share/demo-assets/
112-videos /usr/share/demo-assets/
113-telephony-app /usr/share/demo-assets/
114-contacts-data /usr/share/demo-assets/
115-shell/backgrounds/* /usr/share/backgrounds/
116-shell/infographics /usr/share/demo-assets/shell/
117-/usr/bin
118-services/* /usr/share/dbus-1/services
119-lenses/* /usr/share/unity/lenses
120
121=== renamed file 'usr/bin/inject-data-into-friends-model.py' => 'usr/bin/inject-data-into-friends-model'
122--- usr/bin/inject-data-into-friends-model.py 2013-02-21 01:01:40 +0000
123+++ usr/bin/inject-data-into-friends-model 2013-05-24 18:06:38 +0000
124@@ -1,4 +1,4 @@
125-#!/usr/bin/env python3
126+#!/usr/bin/python3
127 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
128 # Copyright 2013 Canonical
129 #
130
131=== renamed file 'usr/bin/manage-address-books.py' => 'usr/bin/manage-address-books'
132--- usr/bin/manage-address-books.py 2013-02-21 01:01:40 +0000
133+++ usr/bin/manage-address-books 2013-05-24 18:06:38 +0000
134@@ -1,4 +1,4 @@
135-#!/usr/bin/env python
136+#!/usr/bin/python3
137 # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
138 # Copyright 2013 Canonical
139 #
140@@ -51,7 +51,7 @@
141 return create_eds_source(book_name)
142
143 def create_eds_source(book_name):
144- print("Create EDS source %s", book_name)
145+ print(("Create EDS source %s", book_name))
146 source = EDataServer.Source.new(None, None)
147 source.set_display_name(book_name)
148 source.set_parent('local-stub')
149@@ -67,12 +67,12 @@
150 source_registry.set_default_address_book(source)
151 return source.get_uid()
152 else:
153- print("Error CREATING ADDRESS BOOK %s", book_name)
154+ print(("Error CREATING ADDRESS BOOK %s", book_name))
155 sys.exit()
156
157 def prep_data():
158 print("prep_data")
159- ifile = open('/usr/share/demo-assets/contacts-data/data.csv', "rb")
160+ ifile = open('/usr/share/demo-assets/contacts-data/data.csv', "r")
161 reader = csv.reader(ifile)
162 rownum = 0
163 for row in reader:
164@@ -92,12 +92,12 @@
165 for filename in os.listdir("/usr/share/demo-assets/contacts-data/avatars"):
166 parts = os.path.splitext(filename)[0].split("_")
167 if int(parts[-1]) == int(facebook_id):
168- f = open("/usr/share/demo-assets/contacts-data/avatars/" + filename, 'r')
169+ f = open("/usr/share/demo-assets/contacts-data/avatars/" + filename, 'rb')
170 p = EBook.ContactPhoto.new()
171 p.set_mime_type("image/jpeg")
172 p.set_inlined(f.read())
173 contact.set_property("photo", p)
174- print("found {} for {} who has id {} {} ".format(filename, name, facebook_id, str(contact.inline_local_photos())))
175+ print(("found {} for {} who has id {} {} ".format(filename, name, facebook_id, str(contact.inline_local_photos()))))
176 f.close()
177
178
179@@ -106,7 +106,7 @@
180 source_match = source_registry.ref_source(source_uid)
181
182 if(source_match is None):
183- print("No source match from reg %s", source_uid)
184+ print(("No source match from reg %s", source_uid))
185 sys.exit()
186
187
188@@ -131,7 +131,7 @@
189 name = c["Name"]
190 param.add_value(name)
191 vcard_attr.add_param(param);
192- if ("FacebookID" in c.keys()):
193+ if ("FacebookID" in list(c.keys())):
194 param = EBook.VCardAttributeParam.new('facebook-id')
195 param.add_value(c["FacebookID"])
196 vcard_attr.add_param(param)
197@@ -144,27 +144,27 @@
198
199 contact = EBook.Contact.new_from_vcard(vcard.to_string(EBook.VCardFormat(1)))
200
201- for key,value in c.items():
202+ for key,value in list(c.items()):
203 if key == "Name":
204 contact.set_property("full-name", value)
205 elif key == "Favorite" and value == "1":
206 print("Favorite = TRUE")
207 contact.set_property("categories", 'Favorites')
208 elif (key.find("E-mail 1") > -1):
209- print("email 1 = {}".format(value))
210+ print(("email 1 = {}".format(value)))
211 contact.set_property("email-1", value)
212 elif (key.find("E-mail 2") > -1):
213- print("email 2 = {}".format(value))
214+ print(("email 2 = {}".format(value)))
215 contact.set_property("email-2", value)
216 elif (key.find("Phone 1 - Value") > -1):
217- print("phone 1 = {}".format(value))
218+ print(("phone 1 = {}".format(value)))
219 contact.set_property("home-phone", value)
220 elif (key.find("Phone 2 - Value") > -1):
221- print("phone 2 = {}".format(value))
222+ print(("phone 2 = {}".format(value)))
223 contact.set_property("home-phone-2", value)
224 elif (key.find("FacebookID") > -1):
225 if (value.isdigit()):
226- print("facebookid = {}".format(value))
227+ print(("facebookid = {}".format(value)))
228 find_and_set_image_path(contact, value, name)
229 client.add_contact_sync(contact, None)
230 ml.quit()
231@@ -173,17 +173,17 @@
232 client = EBook.BookClient.new(source)
233 client.open_sync(False, None)
234 if client is None:
235- print "cannot create bookclient!"
236+ print("cannot create bookclient!")
237 sys.exit()
238 query = EBook.book_query_any_field_contains('')
239 success, results = client.get_contacts_sync(query.to_string(), None)
240 if not success:
241 log.error('EDS search for delete all contacts failed')
242 sys.exit()
243- print('Found {} contacts to delete'.format(len(results)))
244+ print(('Found {} contacts to delete'.format(len(results))))
245 for contact in results:
246- print('Deleting contact {}'.format(
247- contact.get_property('full-name')))
248+ print(('Deleting contact {}'.format(
249+ contact.get_property('full-name'))))
250 client.remove_contact_sync(contact, None)
251
252 def create(ml):
253@@ -194,7 +194,7 @@
254 def delete(a_book_name, ml):
255 book = address_book_name if a_book_name is None else a_book_name
256 source_uid = get_source(book)
257- print "delete book {}".format(book)
258+ print("delete book {}".format(book))
259 source_match = source_registry.ref_source(source_uid)
260 delete_contacts(source_match)
261 ml.quit()
262@@ -207,7 +207,7 @@
263 else:
264 book_name = book_name[0]
265
266-print("Carry out '{}'' action on '{}' book".format(action, book_name))
267+print(("Carry out '{}'' action on '{}' book".format(action, book_name)))
268
269 ml = GLib.MainLoop()
270

Subscribers

People subscribed via source and target branches