Merge lp:~sergiusens/cloud-init/snappy into lp:~smoser/cloud-init/snappy

[Sergio Schvezov]

[Scott Moser (smoser)]

some questions
a.) why 'status' after 'start' ?
   the output of that command wont go anywhere where you could see it
b.) will 'start' fail if already started ?
    will 'stop' fail if not started ?

we dont want to raise exception in the event of either of 'b' erroring out if the end result is correct.

[Sergio Schvezov (sergiusens)]

> some questions
> a.) why 'status' after 'start' ?
> the output of that command wont go anywhere where you could see it
> b.) will 'start' fail if already started ?
> will 'stop' fail if not started ?
>
> we dont want to raise exception in the event of either of 'b' erroring out if
> the end result is correct.

Given 'a' and 'b' I'll remove status; I thought we wanted to error if it failed to start for whatever reason and status returns '3' if the service is stopped;

wrt 'b' specifically, it's idempotent

ubuntu@localhost:~$ sudo systemctl start ssh
ubuntu@localhost:~$ echo $?
0
ubuntu@localhost:~$ sudo systemctl start ssh
ubuntu@localhost:~$ echo $?
0
ubuntu@localhost:~$ sudo systemctl start ssh
ubuntu@localhost:~$ sudo systemctl status ssh
● ssh.service - OpenBSD Secure Shell server
   Loaded: loaded (/lib/systemd/system/ssh.service; enabled)
   Active: active (running) since Tue 2014-12-02 16:32:39 UTC; 34s ago
 Main PID: 759 (sshd)
   CGroup: /system.slice/ssh.service
           └─759 /usr/sbin/sshd -D

Dec 02 16:32:39 localhost.localdomain systemd[1]: Started OpenBSD Secure Shel...
Dec 02 16:32:39 localhost.localdomain sshd[759]: Could not load host key: /e...y
Dec 02 16:32:39 localhost.localdomain sshd[759]: Server listening on 0.0.0.0....
Dec 02 16:32:39 localhost.localdomain sshd[759]: Server listening on :: port 22.
Dec 02 16:32:44 localhost.localdomain systemd[1]: Started OpenBSD Secure Shel...
Dec 02 16:33:08 localhost.localdomain systemd[1]: Started OpenBSD Secure Shel...
Hint: Some lines were ellipsized, use -l to show in full.
ubuntu@localhost:~$ sudo systemctl stop ssh
ubuntu@localhost:~$ sudo systemctl status ssh
● ssh.service - OpenBSD Secure Shell server
   Loaded: loaded (/lib/systemd/system/ssh.service; enabled)
   Active: inactive (dead) since Tue 2014-12-02 16:33:17 UTC; 2s ago
  Process: 759 ExecStart=/usr/sbin/sshd -D $SSHD_OPTS (code=exited, status=0/SUCCESS)
 Main PID: 759 (code=exited, status=0/SUCCESS)

Dec 02 16:32:39 localhost.localdomain systemd[1]: Started OpenBSD Secure Shel...
Dec 02 16:32:39 localhost.localdomain sshd[759]: Could not load host key: /e...y
Dec 02 16:32:39 localhost.localdomain sshd[759]: Server listening on 0.0.0.0....
Dec 02 16:32:39 localhost.localdomain sshd[759]: Server listening on :: port 22.
Dec 02 16:32:44 localhost.localdomain systemd[1]: Started OpenBSD Secure Shel...
Dec 02 16:33:08 localhost.localdomain systemd[1]: Started OpenBSD Secure Shel...
Dec 02 16:33:17 localhost.localdomain systemd[1]: Stopping OpenBSD Secure She...
Dec 02 16:33:17 localhost.localdomain systemd[1]: Stopped OpenBSD Secure Shel...
Hint: Some lines were ellipsized, use -l to show in full.
ubuntu@localhost:~$ echo $?
3
ubuntu@localhost:~$ sudo systemctl stop ssh
ubuntu@localhost:~$ echo $?
0

[lp:~sergiusens/cloud-init/snappy]

1040. By Scott Moser on 2014-12-02

start or stop ssh based on enable_ssh

=== modified file 'cloudinit/config/cc_snappy.py'
--- cloudinit/config/cc_snappy.py	2014-12-01 20:28:37 +0000
+++ cloudinit/config/cc_snappy.py	2014-12-02 16:40:46 +0000
@@ -89,7 +89,11 @@
     not_to_be_run = "/etc/ssh/sshd_not_to_be_run"
     if enabled:
         util.write_file(not_to_be_run, "cloud-init\n")
+        # this is an indempotent operation
+        util.subp(["systemctl", "start", "ssh"])
     else:
+        # this is an indempotent operation
+        util.subp(["systemctl", "stop", "ssh"])
         util.del_file(not_to_be_run)