~sergiusens/+git/snapcraft-sergiusens:core20-gadget

Last commit made on 2019-10-23
Get this branch:
git clone -b core20-gadget https://git.launchpad.net/~sergiusens/+git/snapcraft-sergiusens
Only Sergio Schvezov can upload to this branch. If you are Sergio Schvezov please log in for upload directions.

Branch merges

Branch information

Name:
core20-gadget
Repository:
lp:~sergiusens/+git/snapcraft-sergiusens

Recent commits

cac26b9... by Sergio Schvezov

make plugin: support for core20

Signed-off-by: Sergio Schvezov <email address hidden>

39ca3d4... by Sergio Schvezov

meta: force grade devel when using non stable bases

Check the channel used to install the base snap and set the grade of the snap
build accordingly with appropriate warnings.

Override user set grades when in conflict with a specific warning.

Signed-off-by: Sergio Schvezov <email address hidden>

98bff79... by Sergio Schvezov

snaps: allow installation of non stable bases

Add checks to verify the channel the base lives on and use that channel (risk) to install.

Signed-off-by: Sergio Schvezov <email address hidden>

00829ac... by Sergio Schvezov

snaps: invalidate cache on refresh or install

Invalidate the existing cache for local information once and install or refresh is executed.

This allows use of the same SnapPackage instance after one of those two operations.

Signed-off-by: Sergio Schvezov <email address hidden>

194ae90... by Anatoli Babenia

docker: use apt-get to avoid warnings (#2672)

93fd282... by Nick Zatkovich

nodejs plugin: fix errors when building with sudo (#2747)

Pop the SUDO environment variables so that the npm tooling works as expected.

Additionally, only complete package listing for the manifest when using npm
as yarn has no ls to get this and produces conflicting results.

be72589... by Chris Patterson

errors: migrate handful of errors to SnapcraftException

- Add SnapcraftReportableException helper class for reportable
  errors, which simply flips the default value for get_reportable().
- Convert MissingStateClean, StepOutdatedError,
  SnapcraftEnvironmentError, SnapcraftDataDirectoryMissingError,
  and SnapcraftMissingLinkerInBaseError and associated tests.
- Add missing test for SnapcraftDataDirectoryMissingError.
- Update tests to verify expected "reportable" value as well.
- Drop `dependents` from StepOutdatedError. It's unused in the
  codebase. Drop associated test as well.
- Add CLEAN_RESOLUTION string to share commonly used clean/retry msg.

The error messages are being shortened and I am also using
this opportunity to simplify them (and the resolution messages).

For example, when StepOutdatedError occurs, instead of suggesting
that the user clean just one part/step when something is out of date,
ask them to instead clean the whole project. Something unusual has
happened and it's probably a good idea to clean the whole tree. Use
introduced CLEAN_RESOLUTION for this.

Adding type checking as well to converted exceptions.

Signed-off-by: Chris Patterson <email address hidden>

6fc8167... by Merlijn Sebrechts

appstream: support legacy ids without desktop suffix

If no launchables are found and component id does not have `.desktop`
suffix, use the component id + .desktop as possible desktop file id.

This is not required per the spec, but some applications such
as Foliate use this and other tools such as Flatpak support it.

LP: #1778546

b819c7a... by Merlijn Sebrechts

docs: use real testing examples

c4ccbc3... by Merlijn Sebrechts

appstream: extract title and version

This PR extracts title and version from AppStream's name tag and
from the version property of the first release tag.

According to the AppStream docs:

> name: A human-readable name for this software component. For
> example, if the component ID was "libc", its name might be
> "GNU Standard C Library".

> Each release of the software component should have a <release/>
> tag describing it, but at least one release child must be present
> for the current release of the software. The release children
> should be sorted in a latest-to-oldest order to simplify reading
> the metadata file.