Merge lp:~sergiomeneses/testdrive/ubuntugnome-release into lp:testdrive

[Andres Rodriguez]

[Andres Rodriguez (andreserl)]

Looks good to me, just change the label

TAB_LABEL.append({"dist":"ubuntugnome", "label":"UbuntuGnome"})

to be 'Ubuntu Gnome'

Cheers.

review: Approve

[lp:~sergiomeneses/testdrive/ubuntugnome-release]

432. By Sergio Meneses on 2013-10-24

tab for ubuntugnome isos

[Sergio Meneses (sergiomeneses)]

Ok! it's done. thanks for your help Andres.

[Andres Rodriguez (andreserl)]

Traceback (most recent call last):
  File "bin/testdrive-gtk", line 1002, in <module>
    window = TestdrivegtkWindow()
  File "bin/testdrive-gtk", line 115, in __new__
    new_object.finish_initializing(builder)
  File "bin/testdrive-gtk", line 141, in finish_initializing
    dlg = PreferencesTestdrivegtkDialog.PreferencesTestdrivegtkDialog()
  File "/home/roaksoax/Desktop/project/testdrive/testdrivegtk/PreferencesTestdrivegtkDialog.py", line 56, in __new__
    new_object.finish_initializing(builder, logger1)
  File "/home/roaksoax/Desktop/project/testdrive/testdrivegtk/PreferencesTestdrivegtkDialog.py", line 96, in finish_initializing
    self.initialize_widgets()
  File "/home/roaksoax/Desktop/project/testdrive/testdrivegtk/PreferencesTestdrivegtkDialog.py", line 203, in initialize_widgets
    self.chk_flavor_ubuntugnome.connect("clicked", self.on_select_flavors)
AttributeError: 'NoneType' object has no attribute 'connect'

review: Needs Fixing

[Andres Rodriguez (andreserl)]

UI changes seem missing in data/ui/PreferencesTestdrivegtkDialog.ui

[Andres Rodriguez (andreserl)]

I'll approve this but there was other fixes that needed to get done.

review: Approve

[Bhavani Shankar (bhavi)]

Hey,

When I try to run the testdrive-gtk with this branch I get:

bhavani@bhavani-Vostro1510:~/devel/ubuntugnome-release$ testdrive-gtk
Traceback (most recent call last):
  File "/usr/local/bin/testdrive-gtk", line 1002, in <module>
    window = TestdrivegtkWindow()
  File "/usr/local/bin/testdrive-gtk", line 113, in __new__
    builder = get_builder('TestdrivegtkWindow')
  File "/usr/local/lib/python2.7/dist-packages/testdrivegtk/helpers.py", line 44, in get_builder
    ui_filename = get_data_file('ui', '%s.ui' % (builder_file_name,))
  File "/usr/local/lib/python2.7/dist-packages/testdrivegtk/testdrivegtkconfig.py", line 54, in get_data_file
    return os.path.join(get_data_path(), *path_segments)
  File "/usr/local/lib/python2.7/dist-packages/testdrivegtk/testdrivegtkconfig.py", line 71, in get_data_path
    raise project_path_not_found
testdrivegtk.testdrivegtkconfig.project_path_not_found

Is there anything I'm missing here?

Regards
Bhavani

=== modified file 'bin/testdrive'
--- bin/testdrive	2013-08-10 20:52:38 +0000
+++ bin/testdrive	2013-10-24 15:57:18 +0000
@@ -204,7 +204,7 @@
         help=_('hardcode Ubuntu RELEASE codename'))
     parser.add_option('-l', '--flavor', action='store', type='string', dest='flavor',
         help=_('hardcode Ubuntu flavor. Available Flavors:\n\
-             ubuntu/kubuntu/xubuntu/edubuntu/mythbuntu/ubuntustudio/lubuntu/ubuntukylin'))
+             ubuntu/kubuntu/xubuntu/edubuntu/mythbuntu/ubuntustudio/lubuntu/ubuntukylin/ubuntugnome'))
     parser.add_option('-p', '--repo', action='store', type='string', dest='repository',
         help=_('hardcode Ubuntu repository from where to obtain ISOs:\n\
              releases/cdimage/cloud-daily/cloud-releases'))

=== modified file 'bin/testdrive-gtk'
--- bin/testdrive-gtk	2013-08-10 20:52:38 +0000
+++ bin/testdrive-gtk	2013-10-24 15:57:18 +0000
@@ -46,6 +46,7 @@
 TAB_LABEL.append({"dist":"ubuntustudio", "label":"Ubuntu Studio"})
 TAB_LABEL.append({"dist":"lubuntu", "label":"Lubuntu"})
 TAB_LABEL.append({"dist":"ubuntukylin", "label":"UbuntuKylin"})
+TAB_LABEL.append({"dist":"ubuntugnome", "label":"Ubuntu Gnome"})
 TAB_LABEL.append({"dist":"other", "label":_("Other")})
 
 global ISOLIST

=== modified file 'testdrivegtk/PreferencesTestdrivegtkDialog.py'
--- testdrivegtk/PreferencesTestdrivegtkDialog.py	2013-08-10 21:31:38 +0000
+++ testdrivegtk/PreferencesTestdrivegtkDialog.py	2013-10-24 15:57:18 +0000
@@ -199,6 +199,8 @@
         self.chk_flavor_lubuntu.connect("clicked", self.on_select_flavors)
         self.chk_flavor_ubuntukylin = self.builder.get_object("chk_flavor_ubuntukylin")
         self.chk_flavor_ubuntukylin.connect("clicked", self.on_select_flavors)
+        self.chk_flavor_ubuntugnome = self.builder.get_object("chk_flavor_ubuntugnome")
+        self.chk_flavor_ubuntugnome.connect("clicked", self.on_select_flavors)
         self.chk_flavor_other = self.builder.get_object("chk_flavor_other")
         self.chk_flavor_other.connect("clicked", self.on_select_flavors)
 
@@ -302,6 +304,8 @@
                     self.chk_flavor_lubuntu.set_active(True)
                 elif flavor == 'ubuntukylin':
                     self.chk_flavor_ubuntukylin.set_active(True)
+                elif flavor == 'ubuntugnome':
+                    self.chk_flavor_ubuntugnome.set_active(True)
                 elif flavor == 'other':
                     self.chk_flavor_other.set_active(True)
                 else:
@@ -447,6 +451,8 @@
             self.flavors = self.flavors + "lubuntu, "
         if self.chk_flavor_ubuntukylin.get_active():
             self.flavors = self.flavors + "ubuntukylin, "
+        if self.chk_flavor_ubuntugnome.get_active():
+            self.flavors = self.flavors + "ubuntugnome, "
         if self.chk_flavor_other.get_active():
             self.flavors = self.flavors + "other, "