TestDrive

Merge lp:~sergiomeneses/testdrive/FixingCdImage into lp:testdrive

  1. FixingCdImage
  2. Merge into trunk
Proposed by Sergio Meneses
Status: Merged
Approved by: Andres Rodriguez
Approved revision: 399
Merged at revision: 399
Proposed branch: lp:~sergiomeneses/testdrive/FixingCdImage
Merge into: lp:testdrive
Diff against target: 12 lines (+1/-1)
1 file modified
testdrive/testdrive.py (+1/-1)
To merge this branch: bzr merge lp:~sergiomeneses/testdrive/FixingCdImage
Reviewer Review Type Date Requested Status
Andres Rodriguez Approve
Review via email: mp+159080@code.launchpad.net

Description of the change

As solution, we only go to filter the entries and let one, re-editing the line 339 in the file "testdrive.py"... you can see the final code-line here:

(status, output) = commands.getstatusoutput("wget -q -O- http://cdimage.ubuntu.com/.manifest-daily | egrep '(amd64|i386)' | egrep '(current)'")

I expect this will be helpful!

To post a comment you must log in.
Revision history for this message
Sergio Meneses (sergiomeneses) wrote :

Ok, first at all, I could solve my previous error: I was merging to the
wrong project! =/

But now everything works OK :)

Sergio Meneses
Linux User: #478743
Ubuntu User: #24056

On Tue, Apr 16, 2013 at 12:54 AM, Sergio Meneses <
<email address hidden>> wrote:

> Sergio Meneses has proposed merging
> lp:~sergiomeneses/testdrive/FixingCdImage into lp:testdrive.
>
> Requested reviews:
> testdrive (testdrive)
> Related bugs:
> Bug #1162057 in testdrive (Ubuntu): "Testdrive has two entries per iso"
> https://bugs.launchpad.net/ubuntu/+source/testdrive/+bug/1162057
>
> For more details, see:
>
> https://code.launchpad.net/~sergiomeneses/testdrive/FixingCdImage/+merge/159080
>
> As solution, we only go to filter the entries and let one, re-editing the
> line 339 in the file "testdrive.py"... you can see the final code-line here:
>
> (status, output) = commands.getstatusoutput("wget -q -O-
> http://cdimage.ubuntu.com/.manifest-daily | egrep '(amd64|i386)' | egrep
> '(current)'")
>
>
> I expect this will be helpful!
> --
>
> https://code.launchpad.net/~sergiomeneses/testdrive/FixingCdImage/+merge/159080
> You are the owner of lp:~sergiomeneses/testdrive/FixingCdImage.
>
> === modified file 'testdrive/testdrive.py'
> --- testdrive/testdrive.py 2013-04-15 16:03:39 +0000
> +++ testdrive/testdrive.py 2013-04-16 05:53:31 +0000
> @@ -350,7 +350,7 @@
>
> def obtain_ubuntu_iso_list_from_repo(self):
> if self.p == 'cdimage':
> - (status, output) = commands.getstatusoutput("wget -q -O-
> http://cdimage.ubuntu.com/.manifest-daily | egrep '(amd64|i386)'")
> + (status, output) = commands.getstatusoutput("wget -q -O-
> http://cdimage.ubuntu.com/.manifest-daily | egrep '(amd64|i386)' | egrep
> '(current)'")
> elif self.p == 'releases':
> (status, output) = commands.getstatusoutput("wget -q -O-
> http://releases.ubuntu.com/.manifest | egrep '(amd64|i386)'")
> elif self.p == 'cloud-daily':
>
>
>

Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'testdrive/testdrive.py'
2--- testdrive/testdrive.py 2013-04-15 16:03:39 +0000
3+++ testdrive/testdrive.py 2013-04-16 05:53:31 +0000
4@@ -350,7 +350,7 @@
5
6 def obtain_ubuntu_iso_list_from_repo(self):
7 if self.p == 'cdimage':
8- (status, output) = commands.getstatusoutput("wget -q -O- http://cdimage.ubuntu.com/.manifest-daily | egrep '(amd64|i386)'")
9+ (status, output) = commands.getstatusoutput("wget -q -O- http://cdimage.ubuntu.com/.manifest-daily | egrep '(amd64|i386)' | egrep '(current)'")
10 elif self.p == 'releases':
11 (status, output) = commands.getstatusoutput("wget -q -O- http://releases.ubuntu.com/.manifest | egrep '(amd64|i386)'")
12 elif self.p == 'cloud-daily':

Subscribers

People subscribed via source and target branches