Merge ~sergiodj/ubuntu/+source/sssd:bug1900642-condpathexists-groovy into ubuntu/+source/sssd:ubuntu/groovy-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Sergio Durigan Junior | ||||
Approved revision: | 948bc31f6574058cd94234d80b561213c03ba654 | ||||
Merged at revision: | 948bc31f6574058cd94234d80b561213c03ba654 | ||||
Proposed branch: | ~sergiodj/ubuntu/+source/sssd:bug1900642-condpathexists-groovy | ||||
Merge into: | ubuntu/+source/sssd:ubuntu/groovy-devel | ||||
Diff against target: |
160 lines (+96/-37) 4 files modified
debian/changelog (+9/-0) debian/patches/0003-Only-start-sssd.service-if-there-s-a-configuration-f.patch (+86/-0) debian/patches/series (+1/-1) dev/null (+0/-36) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington (community) | Approve | ||
Canonical Server | Pending | ||
Review via email: mp+396186@code.launchpad.net |
Description of the change
This is a new MP to address bug 1900642. The difference between it and the previous one (here: https:/
The previous MP had been approved, and the SRU team had even accepted the package, but I decided to not proceed with the verification process and re-do everything. This is the result.
In a nutshell, what the new patch does is to include some conditions in the sssd.service file that are responsible for checking whether the user as (a) a file named /etc/sssd/
It's important to mention that these conditions will only be added to the service file if sssd has been compiled without --enable-
The good thing is that the SRU template can be left unmodified. I asked Robie how I should proceed in the specific case that a package has already been accepted (but not verified) by the SRU team, and he told me I should bump the version number, so that's what I did. Hopefully everything is correct.
Looks like this needs to be addressed in hirsute, prior to the SRUs? That will need-fixing, since the SRU won't be accepted without it landing in hirsute.
Otherwise, the merge proposal looks good, and is a logical refinement over the previously reviewed & approved MP, https:/ /code.launchpad .net/~sergiodj/ ubuntu/ +source/ sssd/+git/ sssd/+merge/ 395175
Approving, contingent on the fix also going into hirsute.