Merge ~sergiodj/ubuntu/+source/sendmail:disable-nix-fix-ftbfs into ubuntu/+source/sendmail:ubuntu/devel

[Sergio Durigan Junior]

This change disables NIS/NIS+ on sendmail and fixes an FTBFS that is Ubuntu-specific.

It all started when I noticed that sendmail was FTBFSing in the PPA I'm using for the OpenLDAP transition. A quick glance at the build logs told me that the problem was unrelated to the transition, and so I started investigating.

I could reproduce the FTBFS locally on Ubuntu, but could not make the package fail to build on Debian. I fired up a container where I could manually reproduce the build steps and notice what was really happening: the sendmail package has a "configure" script inside the debian/ directory, which is responsible for (duh) configuring the upstream sources. One of the steps involved in the execution of the "configure" was to generate a "control.new" file (by doing some variable substitutions in the "control.in" file), and then assert that "control.new" is exactly the same as the existing "control" file. On Debian they are the same. On Ubuntu they aren't.

I hacked the "configure" script to tell me exactly what differs between both files, and noticed that on Ubuntu the following line:

  This package supports REGEX, DB, NIS, NIS+, LDAP, DNS maps,

becomes:

  This package supports REGEX, DB, NIS, LDAP, DNS maps

So, no NIS+. Strange. I looked at "configure.ac" and noticed that, in order to check for NIS+, the script was checking for the presence of the "/usr/include/rpcsvc/nis.h" header, which does exist. However, "config.log" told me that the actual error was that gcc wasn't able to find "rpc/rpc.h". Aha!

Long story short, glibc >= 2.32 doesn't ship this file anymore. There is precedence for removing NIS/NIS+ support from packages due to this breakage; for example:

https://bugs.launchpad.net/ubuntu/+source/squid/+bug/1895694

As Balint wrote there, it may not be trivial/possible to port sendmail to use tirpc, and I don't know if it's a drop-in replacement. Also, NIS is deprecated and I don't think we should be offering it to our users.

Debian is still not affected by this because they're shipping glibc 2.31. They will be, and that's why I will *also* propose this change to Debian's sendmail (which unfortunately is orphaned, but that's another story). But for now, I think we should fix this in Ubuntu.

There's a PPA with the proposed changes here:

https://launchpad.net/~sergiodj/+archive/ubuntu/sendmail-ftbfs-nis

The good news after all this work is that I was able to confirm that sendmail is not affected by the openldap transition, so yay, I guess :-).

[Athos Ribeiro (athos-ribeiro)]

LGTM

review: Approve

[Sergio Durigan Junior (sergiodj)]

Thanks! Uploaded & pushed:

$ git push pkg upload/8.15.2-22ubuntu1
Enumerating objects: 21, done.
Counting objects: 100% (21/21), done.
Delta compression using up to 8 threads
Compressing objects: 100% (15/15), done.
Writing objects: 100% (15/15), 1.93 KiB | 659.00 KiB/s, done.
Total 15 (delta 11), reused 0 (delta 0)
To ssh://git.launchpad.net/ubuntu/+source/sendmail
 * [new tag] upload/8.15.2-22ubuntu1 -> upload/8.15.2-22ubuntu1

$ dput sendmail_8.15.2-22ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/sendmail/sendmail_8.15.2-22ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/sendmail/sendmail_8.15.2-22ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading sendmail_8.15.2-22ubuntu1.dsc: done.
  Uploading sendmail_8.15.2-22ubuntu1.debian.tar.xz: done.
  Uploading sendmail_8.15.2-22ubuntu1_source.buildinfo: done.
  Uploading sendmail_8.15.2-22ubuntu1_source.changes: done.
Successfully uploaded packages.

diff --git a/debian/changelog b/debian/changelog
index fb8ca3b..f83026a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+sendmail (8.15.2-22ubuntu1) impish; urgency=medium
+
+  * d/configure.options: Disable NIS and NIS+.  Fix FTBFS with
+    glibc >= 2.32 due to missing "rpc/rpc.h".
+  * d/control: Update description of sendmail and sendmail-bin to
+    reflect the fact that NIS and NIS+ have been disabled.
+
+ -- Sergio Durigan Junior <[e-mail]>  Thu, 13 May 2021 17:58:13 -0400
+
 sendmail (8.15.2-22) unstable; urgency=medium
 
   * QA upload.
diff --git a/debian/configure.options b/debian/configure.options
index 9775d2a..abe5b26 100644
--- a/debian/configure.options
+++ b/debian/configure.options
@@ -80,9 +80,9 @@
 #  --enable-newdb=.........Allow NEWDB maps [auto]
 --enable-newdb=yes
 #  --enable-nis=...........Allow NIS maps [auto]
---enable-nis=auto
+--enable-nis=no
 #  --enable-nisplus=.......Allow NISPLUS maps [auto]
---enable-nisplus=auto
+--enable-nisplus=no
 #  --enable-ldap=..........Allow LDAP maps [auto]
 --enable-ldap=yes
 #  --enable-hesiod=........Allow HESIOD maps [auto]
diff --git a/debian/control b/debian/control
index 8b5691c..48fb980 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: sendmail
 Priority: optional
 Section: mail
-Maintainer: Debian QA Group <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian QA Group <[e-mail]>
 Build-Depends-Indep:
  groff,
  bsdmainutils,
@@ -57,7 +58,7 @@ Description: powerful, efficient, and scalable Mail Transport Agent
  Sendmail includes *no* Mail User Agents (MUA), you'll have to
  pick from the plethora of available MUAs (mutt, vm, etc.)
  .
- This package supports REGEX, DB, NIS, NIS+, LDAP, DNS maps,
+ This package supports REGEX, DB, LDAP, DNS maps,
  and has enabled TCPWrappers, IPv6, LockFile, SMTP AUTH(SASL), STARTTLS(SSL).
 
 Package: rmail
@@ -185,7 +186,7 @@ Description: powerful, efficient, and scalable Mail Transport Agent (metapackage
  Sendmail includes *no* Mail User Agents (MUA), you'll have to
  pick from the plethora of available MUAs (mutt, vm, etc.)
  .
- This package supports REGEX, DB, NIS, NIS+, LDAP, DNS maps,
+ This package supports REGEX, DB, LDAP, DNS maps,
  and has enabled TCPWrappers, IPv6, LockFile, SMTP AUTH(SASL), STARTTLS(SSL).
  .
  This package is to make installation/upgrading easier (Do NOT delete it)
diff --git a/debian/control.in b/debian/control.in
index f8838f3..9977bc5 100644
--- a/debian/control.in
+++ b/debian/control.in
@@ -1,7 +1,8 @@
 Source: sendmail
 Priority: optional
 Section: mail
-Maintainer: Debian QA Group <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian QA Group <[e-mail]>
 Build-Depends-Indep:
  groff,
  bsdmainutils,