Merge ~sergiodj/ubuntu/+source/samba:samba-merge-4.13.2+dfsg-3 into ubuntu/+source/samba:debian/sid

Proposed by Sergio Durigan Junior
Status: Merged
Merge reported by: Sergio Durigan Junior
Merged at revision: 6ab3026dae9958cf96722f5a56b23cecf6073e1a
Proposed branch: ~sergiodj/ubuntu/+source/samba:samba-merge-4.13.2+dfsg-3
Merge into: ubuntu/+source/samba:debian/sid
Diff against target: 2808 lines (+2199/-103)
17 files modified
debian/changelog (+1868/-0)
debian/control (+9/-8)
debian/patches/VERSION.patch (+2/-2)
debian/patches/ctdb-config-enable-syslog-by-default.patch (+49/-0)
debian/patches/fix-nfs-service-name-to-nfs-kernel-server.patch (+34/-14)
debian/patches/series (+1/-0)
debian/rules (+30/-10)
debian/samba-common.config (+4/-4)
debian/smb.conf (+15/-9)
debian/tests/cifs-share-access (+13/-24)
debian/tests/cifs-share-access-uring (+41/-0)
debian/tests/control (+8/-0)
debian/tests/smbclient-anonymous-share-list (+4/-1)
debian/tests/smbclient-authenticated-share-list (+9/-8)
debian/tests/smbclient-share-access (+12/-23)
debian/tests/smbclient-share-access-uring (+35/-0)
debian/tests/util (+65/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  (community) Approve
Bryce Harrington Pending
Canonical Server Pending
Review via email: mp+394442@code.launchpad.net

Description of the change

This is the merge of samba 4.13.2+dfsg-3.

I did my best to analyze everything that changed between the current version in hirsute (4.12.5+dfsg-3ubuntu4.1) and this one. Here is what happened with the delta we carry:

1) The patches recently added by the security team in order to fix several CVEs have been incorporated upstream, so it's safe to drop them.

2) Andreas has an MR open on salsa proposing that we enable vfs_io_uring on Debian as well. There's been some movement when he filed the MR, but it's stale (and still not accepted, of course) now. The MR is:

https://salsa.debian.org/samba-team/samba/-/merge_requests/49

3) Everything else was there already. I haven't touched anything.

The package builds fine on the PPA:

https://launchpad.net/~sergiodj/+archive/ubuntu/samba-merge

However, two of its dep8 tests are failing:

autopkgtest [21:55:30]: @@@@@@@@@@@@@@@@@@@@ summary
cifs-share-access FAIL non-zero exit status 32
cifs-share-access-uring FAIL non-zero exit status 32
python-smoke PASS
smbclient-anonymous-share-list PASS
smbclient-authenticated-share-list PASS
smbclient-share-access PASS
smbclient-share-access-uring PASS

Note: these tests only run when you invoke autopkgtest using qemu.

Upon some investigation, I found that the reason for the failure is not related to samba itself, but with util-linux. I found the following bugs:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=975003
https://github.com/karelzak/util-linux/issues/1193

Given what I found, I filed a bug against util-linux on Ubuntu:

https://bugs.launchpad.net/debian/+source/util-linux/+bug/1905510

This bug will need to be fixed before samba can migrate, of course. I will see about working with the Foundations team to have this fixed.

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

I'm adding Bryce to the reviewer list because he told me he could take a look at this tomorrow, but if someone else would like to review it, go for it, please!

Also, you may have noticed that I had filed an MP for a previous version of samba. Well, I decided to bite the bullet and update what I had to the latest version available in Debian. Please ignore that other MP (which has been deleted anyway...).

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Ack on the CVE Drops
Also in general Ack on mostly keeping things/delta as-is while we are short on resources.

One thing before I go much deeper, usually this was accompanied by new ldb/tdb/talloc/?more? that built together in a PPA. I see all those are syncs now (thanks Andreas I guess). And e.g. a new talloc/ldb is in -proposed already. Is that enough or did Andreas outline anything else that we need to do for those on an update?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Changelog:
- [✓] old content and logical tag match as expected
      Well, sergiodj/logical/2%4.12.5+dfsg-3ubuntu4.1 already has CVEs patches dropped.
      Not matching the process, but understandable and not a review problem
- [✓] changelog entry correct version and targeted codename
- [✓] changelog entries correct
- [✓] update-maintainer has been run

Actual changes:
- [✓] no major upstream changes to consider
- [✓] no further upstream version to consider
- [✓] debian changes look safe

Old Delta:
- [✓] dropped changes are ok to be dropped
- [✓] nothing else to drop
- [✓] changes forwarded upstream/debian (if appropriate)

New Delta:
- [✓] no new patches added

Build/Test:
- [✓] build is ok
- [✓] verified PPA package installs/uninstalls
- [✓] autopkgtest against the PPA package passes as reported
   Ack on the extra bug you identified, samba will trigger enough other tests that we might
   need to resolve while waiting for this.
- [✓] sanity checks test fine

+1 for enabling all arches in your PPA BTW - thanks.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Builds used libldb-dev amd64 2:2.2.0-3build1 which is what I asked about above - seems to work fine

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

You might want to FYI Rick about the util-linux bug so that he can make Matt aware to assign someone.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

+1 for a merge that intends to keep delta as-is.

review: Approve
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

This has migrated a while ago, sorry about not posting the "git push" output.

Update scan failed

At least one of the branches involved have failed to scan. You can manually schedule a rescan if required.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 9ce02be..a95ac42 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,90 @@
6+samba (2:4.13.2+dfsg-3ubuntu1) hirsute; urgency=medium
7+
8+ * Merge with Debian unstable (LP: #1905048). Remaining changes:
9+ - d/p/VERSION.patch: Update vendor string to "Ubuntu".
10+ - debian/smb.conf;
11+ + Add "(Samba, Ubuntu)" to server string.
12+ + Comment out the default [homes] share, and add a comment about
13+ "valid users = %s" to show users how to restrict access to
14+ \\server\username to only username.
15+ - debian/samba-common.config:
16+ + Do not change priority to high if dhclient3 is installed.
17+ - d/control, d/rules: Disable glusterfs support because it's not in main.
18+ MIR bug is https://launchpad.net/bugs/1274247
19+ - d/p/fix-nfs-service-name-to-nfs-kernel-server.patch:
20+ change nfs service name from nfs to nfs-kernel-server
21+ (LP #722201)
22+ - d/p/ctdb-config-enable-syslog-by-default.patch:
23+ enable syslog and systemd journal by default
24+ - debian/rules: Ubuntu i386 binary compatibility:
25+ + drop ceph support
26+ + disable the following binary packages:
27+ - ctdb
28+ - libnss-winbind
29+ - libpam-winbind
30+ - python3-samba
31+ - samba
32+ - samba-common-bin
33+ - samba-testsuite
34+ - winbind
35+ - debian/control: Ubuntu i386 binary compatibility:
36+ + drop ceph support
37+ - debian/rules: Ubuntu i386 binary compatibility:
38+ + re-enable the following binary packages:
39+ - libnss-winbind
40+ - samba-common-bin
41+ - python3-samba
42+ - winbind
43+ - d/control: add a versioned libgnutls28-dev build-depends to reduce
44+ the amount of in-tree crypto code that is built
45+ * d/t/smbclient-anonymous-share-list: add set -x and set -e
46+ * Factor out common DEP8 test code into d/t/util and change the tests
47+ to source from it:
48+ - d/t/util: added
49+ - d/t/cifs-share-access, d/t/smbclient-share-access: source from
50+ util, use random share name and add set -x and set -u
51+ - d/t/smbclient-authenticated-share-list: source from util and add
52+ set -x and set -u
53+ * d/control: enable the liburing vfs module, except on i386 where
54+ liburing is not available
55+ * Add new DEP8 tests for the uring vfs module:
56+ - d/t/control: add smbclient-share-access-uring and
57+ cifs-share-access-uring tests
58+ - d/t/smbclient-share-access-uring: new test
59+ - d/t/cifs-share-access-uring: new test
60+ * d/t/{util, smbclient-share-access-uring, cifs-share-access-uring}:
61+ guard uring tests with a kernel version check and skip if it's too old
62+ * Dropped changes:
63+ - SECURITY UPDATE: Unauthenticated domain controller compromise by
64+ subverting Netlogon cryptography (ZeroLogon)
65+ + debian/patches/zerologon-*.patch: backport upstream patches:
66+ + For compatibility reasons, allow specifying an insecure netlogon
67+ configuration per machine. See the following link for examples:
68+ https://www.samba.org/samba/security/CVE-2020-1472.html
69+ + Add additional server checks for the protocol attack in the
70+ client-specified challenge to provide some protection when
71+ 'server schannel = no/auto' and avoid the false-positive results
72+ when running the proof-of-concept exploit.
73+ [ Incorporated by upstream. ]
74+ - SECURITY UPDATE: Missing handle permissions check in ChangeNotify
75+ + debian/patches/CVE-2020-14318-*.patch: ensure change notifies can't
76+ get set unless the directory handle is open for SEC_DIR_LIST in
77+ source4/torture/smb2/notify.c, source3/smbd/notify.c.
78+ + CVE-2020-14318
79+ - SECURITY UPDATE: Unprivileged user can crash winbind
80+ + debian/patches/CVE-2020-14323-*.patch: fix invalid lookupsids DoS in
81+ source3/winbindd/winbindd_lookupsids.c,
82+ source4/torture/winbind/struct_based.c.
83+ + CVE-2020-14323
84+ - SECURITY UPDATE: DNS server crash via invalid records
85+ - debian/patches/CVE-2020-14383-*.patch: ensure variable initialization
86+ with NULL and do not crash when additional data not found in
87+ source4/rpc_server/dnsserver/dcerpc_dnsserver.c.
88+ + CVE-2020-14383
89+ [ Incorporated by upstream. ]
90+
91+ -- Sergio Durigan Junior <sergio.durigan@canonical.com> Tue, 24 Nov 2020 22:12:00 -0500
92+
93 samba (2:4.13.2+dfsg-3) unstable; urgency=medium
94
95 * Ensure systemd-tmpfiles is called before testparm (Closes: #975422)
96@@ -43,6 +130,138 @@ samba (2:4.13.2+dfsg-1) experimental; urgency=medium
97
98 -- Mathieu Parent <sathieu@debian.org> Thu, 12 Nov 2020 11:23:01 +0100
99
100+samba (2:4.12.5+dfsg-3ubuntu4.1) groovy-security; urgency=medium
101+
102+ * SECURITY UPDATE: Missing handle permissions check in ChangeNotify
103+ - debian/patches/CVE-2020-14318-*.patch: ensure change notifies can't
104+ get set unless the directory handle is open for SEC_DIR_LIST in
105+ source4/torture/smb2/notify.c, source3/smbd/notify.c.
106+ - CVE-2020-14318
107+ * SECURITY UPDATE: Unprivileged user can crash winbind
108+ - debian/patches/CVE-2020-14323-*.patch: fix invalid lookupsids DoS in
109+ source3/winbindd/winbindd_lookupsids.c,
110+ source4/torture/winbind/struct_based.c.
111+ - CVE-2020-14323
112+ * SECURITY UPDATE: DNS server crash via invalid records
113+ - debian/patches/CVE-2020-14383-*.patch: ensure variable initialization
114+ with NULL and do not crash when additional data not found in
115+ source4/rpc_server/dnsserver/dcerpc_dnsserver.c.
116+ - CVE-2020-14383
117+
118+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Fri, 16 Oct 2020 06:53:44 -0400
119+
120+samba (2:4.12.5+dfsg-3ubuntu4) groovy; urgency=medium
121+
122+ * SECURITY UPDATE: Unauthenticated domain controller compromise by
123+ subverting Netlogon cryptography (ZeroLogon)
124+ - debian/patches/zerologon-*.patch: backport upstream patches:
125+ + For compatibility reasons, allow specifying an insecure netlogon
126+ configuration per machine. See the following link for examples:
127+ https://www.samba.org/samba/security/CVE-2020-1472.html
128+ + Add additional server checks for the protocol attack in the
129+ client-specified challenge to provide some protection when
130+ 'server schannel = no/auto' and avoid the false-positive results
131+ when running the proof-of-concept exploit.
132+ - CVE-2020-1472
133+
134+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Mon, 28 Sep 2020 09:46:49 -0400
135+
136+samba (2:4.12.5+dfsg-3ubuntu3) groovy; urgency=medium
137+
138+ * d/t/{util, smbclient-share-access-uring, cifs-share-access-uring}:
139+ guard uring tests with a kernel version check and skip if it's too old
140+
141+ -- Andreas Hasenack <andreas@canonical.com> Tue, 11 Aug 2020 11:00:35 -0300
142+
143+samba (2:4.12.5+dfsg-3ubuntu2) groovy; urgency=medium
144+
145+ * d/t/smbclient-anonymous-share-list: add set -x and set -e
146+ * Factor out common DEP8 test code into d/t/util and change the tests
147+ to source from it:
148+ - d/t/util: added
149+ - d/t/cifs-share-access, d/t/smbclient-share-access: source from
150+ util, use random share name and add set -x and set -u
151+ - d/t/smbclient-authenticated-share-list: source from util and add
152+ set -x and set -u
153+ * d/control: enable the liburing vfs module, except on i386 where
154+ liburing is not available
155+ * Add new DEP8 tests for the uring vfs module:
156+ - d/t/control: add smbclient-share-access-uring and
157+ cifs-share-access-uring tests
158+ - d/t/smbclient-share-access-uring: new test
159+ - d/t/cifs-share-access-uring: new test
160+
161+ -- Andreas Hasenack <andreas@canonical.com> Tue, 04 Aug 2020 17:20:30 -0300
162+
163+samba (2:4.12.5+dfsg-3ubuntu1) groovy; urgency=medium
164+
165+ * Merge with Debian unstable. Remaining changes:
166+ - d/p/VERSION.patch: Update vendor string to "Ubuntu".
167+ - debian/smb.conf;
168+ + Add "(Samba, Ubuntu)" to server string.
169+ + Comment out the default [homes] share, and add a comment about
170+ "valid users = %s" to show users how to restrict access to
171+ \\server\username to only username.
172+ - debian/samba-common.config:
173+ + Do not change priority to high if dhclient3 is installed.
174+ - d/control, d/rules: Disable glusterfs support because it's not in main.
175+ MIR bug is https://launchpad.net/bugs/1274247
176+ - d/p/fix-nfs-service-name-to-nfs-kernel-server.patch:
177+ change nfs service name from nfs to nfs-kernel-server
178+ (LP #722201)
179+ - d/p/ctdb-config-enable-syslog-by-default.patch:
180+ enable syslog and systemd journal by default
181+ - debian/rules: Ubuntu i386 binary compatibility:
182+ + drop ceph support
183+ + disable the following binary packages:
184+ - ctdb
185+ - libnss-winbind
186+ - libpam-winbind
187+ - python3-samba
188+ - samba
189+ - samba-common-bin
190+ - samba-testsuite
191+ - winbind
192+ - debian/control: Ubuntu i386 binary compatibility:
193+ + drop ceph support
194+ - debian/rules: Ubuntu i386 binary compatibility:
195+ + re-enable the following binary packages:
196+ - libnss-winbind
197+ - samba-common-bin
198+ - python3-samba
199+ - winbind
200+ - d/control: add a versioned libgnutls28-dev build-depends to reduce
201+ the amount of in-tree crypto code that is built
202+ * Dropped:
203+ - d/gbp.conf, d/watch, d/README.source: update for 4.12
204+ [In 2:4.12.3+dfsg-1]
205+ - d/control: bump build-depends:
206+ + ldb: 2.1.2
207+ + tevent: 0.10.2
208+ + tdb: 1.4.3
209+ + talloc: 2.3.1
210+ [In 2:4.12.3+dfsg-1]
211+ - d/smbclient.install: add new binary mdfind and its manpage
212+ [In 2:4.12.3+dfsg-1]
213+ - d/samba-dev.install, d/samba-libs.install: new lib
214+ libdcerpc-server-core
215+ [In 2:4.12.3+dfsg-1]
216+ - d/samba-libs.install: new library libtalloc-report-printf
217+ [In 2:4.12.3+dfsg-1]
218+ - d/libwbclient0.install: remove libaesni, no longer built when
219+ gnutls provides AES CMAC
220+ [In 2:4.12.3+dfsg-1]
221+ - d/libsmbclient.symbols, d/libwbclient0.symbols: update symbols
222+ [In 2:4.12.3+dfsg-1]
223+ - d/p/build-Remove-tests-for-getdents-and-getdirentries.patch
224+ [Dropped in 2:4.12.3+dfsg-1]
225+ - d/p/wscript-remove-all-checks-for-_FUNC-and-__FUNC.patch
226+ [Dropped in 2:4.12.3+dfsg-1]
227+ - d/p/wscript-split-function-check-to-one-per-line-and-sor.patch
228+ [Dropped in 2:4.12.3+dfsg-1]
229+
230+ -- Andreas Hasenack <andreas@canonical.com> Fri, 31 Jul 2020 11:07:47 -0300
231+
232 samba (2:4.12.5+dfsg-3) unstable; urgency=high
233
234 * Add Breaks: sssd-ad-common (<< 2.3.0), due to libndr so bump
235@@ -107,6 +326,131 @@ samba (2:4.12.3+dfsg-1) experimental; urgency=medium
236
237 -- Mathieu Parent <sathieu@debian.org> Wed, 24 Jun 2020 23:12:11 +0200
238
239+samba (2:4.12.2+dfsg-0ubuntu1) groovy; urgency=medium
240+
241+ * New upstream version: 4.12.2
242+ * d/gbp.conf, d/watch, d/README.source: update for 4.12
243+ * d/control: bump build-depends:
244+ - ldb: 2.1.2
245+ - tevent: 0.10.2
246+ - tdb: 1.4.3
247+ - talloc: 2.3.1
248+ * d/smbclient.install: add new binary mdfind and its manpage
249+ * d/samba-dev.install, d/samba-libs.install: new lib libdcerpc-server-core
250+ * d/samba-libs.install: new library libtalloc-report-printf
251+ * d/libwbclient0.install: remove libaesni, no longer built when
252+ gnutls provides AES CMAC
253+ * d/libsmbclient.symbols, d/libwbclient0.symbols: update symbols
254+ * d/control: add a versioned libgnutls28-dev build-depends to reduce
255+ the amount of in-tree crypto code that is built
256+ * Dropped (applied upstream):
257+ - d/p/build-Remove-tests-for-getdents-and-getdirentries.patch
258+ - d/p/wscript-remove-all-checks-for-_FUNC-and-__FUNC.patch
259+ - d/p/wscript-split-function-check-to-one-per-line-and-sor.patch
260+ - d/p/CVE-2020-10700*.patch, d/p/CVE-2020-10704*.patch
261+
262+ -- Andreas Hasenack <andreas@canonical.com> Tue, 12 May 2020 10:42:17 -0300
263+
264+samba (2:4.11.6+dfsg-0ubuntu1.1) focal-security; urgency=medium
265+
266+ * SECURITY UPDATE: Use-after-free in AD DC LDAP server
267+ - debian/patches/CVE-2020-10700-1.patch: add test for ASQ and ASQ in
268+ combination with paged_results in selftest/knownfail.d/asq,
269+ source4/dsdb/tests/python/asq.py, source4/selftest/tests.py.
270+ - debian/patches/CVE-2020-10700-3.patch: do not permit the ASQ control
271+ for the GUID search in paged_results in selftest/knownfail.d/asq,
272+ source4/dsdb/samdb/ldb_modules/paged_results.c.
273+ - debian/control: bump libldb-dev, python3-ldb, and python3-ldb-dev
274+ Build-Depends to 2.0.10.
275+ - CVE-2020-10700
276+ * SECURITY UPDATE: Stack overflow in AD DC LDAP server
277+ - debian/patches/CVE-2020-10704-1.patch: add ASN.1 max tree depth in
278+ auth/gensec/gensec_util.c, lib/util/asn1.c, lib/util/asn1.h,
279+ lib/util/tests/asn1_tests.c, libcli/auth/spnego_parse.c,
280+ libcli/cldap/cldap.c, libcli/ldap/ldap_message.c,
281+ source3/lib/tldap.c, source3/lib/tldap_util.c,
282+ source3/libsmb/clispnego.c, source3/torture/torture.c,
283+ source4/auth/gensec/gensec_krb5.c, source4/ldap_server/ldap_server.c,
284+ source4/libcli/ldap/ldap_client.c,
285+ source4/libcli/ldap/ldap_controls.c.
286+ - debian/patches/CVE-2020-10704-3.patch: check parse tree depth in
287+ lib/util/asn1.c.
288+ - debian/patches/CVE-2020-10704-5.patch: add max ldap request sizes in
289+ docs-xml/smbdotconf/ldap/ldapmaxanonrequest.xml,
290+ docs-xml/smbdotconf/ldap/ldapmaxauthrequest.xml,
291+ lib/param/loadparm.c, source3/param/loadparm.c.
292+ - debian/patches/CVE-2020-10704-6.patch: limit request sizes in
293+ source4/ldap_server/ldap_server.c.
294+ - debian/patches/CVE-2020-10704-7.patch: add search size limits to
295+ ldap_decode in docs-xml/smbdotconf/ldap/ldapmaxsearchrequest.xml,
296+ lib/param/loadparm.c, libcli/cldap/cldap.c,
297+ libcli/ldap/ldap_message.c, libcli/ldap/ldap_message.h,
298+ source3/param/loadparm.c, source4/ldap_server/ldap_server.c,
299+ source4/libcli/ldap/ldap_client.c.
300+ - debian/patches/CVE-2020-10704-8.patch: check search request lengths
301+ in lib/util/asn1.c, lib/util/asn1.h, libcli/ldap/ldap_message.c.
302+ - CVE-2020-10704
303+
304+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Fri, 24 Apr 2020 08:08:38 -0400
305+
306+samba (2:4.11.6+dfsg-0ubuntu1) focal; urgency=medium
307+
308+ * New upstream release: 4.11.6
309+ * d/p/samba-tool-py38-*.patch: dropped, fixed upstream
310+
311+ -- Andreas Hasenack <andreas@canonical.com> Wed, 26 Feb 2020 11:55:16 -0300
312+
313+samba (2:4.11.5+dfsg-1ubuntu2) focal; urgency=medium
314+
315+ * d/p/samba-tool-py38-*.patch: use correct method flags (LP: #1864324)
316+
317+ -- Andreas Hasenack <andreas@canonical.com> Sat, 22 Feb 2020 17:22:21 -0300
318+
319+samba (2:4.11.5+dfsg-1ubuntu1) focal; urgency=medium
320+
321+ * Merge with Debian unstable. Remaining changes:
322+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
323+ - debian/smb.conf;
324+ + Add "(Samba, Ubuntu)" to server string.
325+ + Comment out the default [homes] share, and add a comment about
326+ "valid users = %s" to show users how to restrict access to
327+ \\server\username to only username.
328+ - debian/samba-common.config:
329+ + Do not change priority to high if dhclient3 is installed.
330+ - d/control, d/rules: Disable glusterfs support because it's not in main.
331+ MIR bug is https://launchpad.net/bugs/1274247
332+ - d/p/fix-nfs-service-name-to-nfs-kernel-server.patch:
333+ change nfs service name from nfs to nfs-kernel-server
334+ (LP #722201)
335+ - d/p/ctdb-config-enable-syslog-by-default.patch:
336+ enable syslog and systemd journal by default
337+ - debian/rules: Ubuntu i386 binary compatibility:
338+ + drop ceph support
339+ + disable the following binary packages:
340+ - ctdb
341+ - libnss-winbind
342+ - libpam-winbind
343+ - python3-samba
344+ - samba
345+ - samba-common-bin
346+ - samba-testsuite
347+ - winbind
348+ - debian/control: Ubuntu i386 binary compatibility:
349+ + drop ceph support
350+ - debian/rules: Ubuntu i386 binary compatibility:
351+ + re-enable the following binary packages:
352+ - libnss-winbind
353+ - samba-common-bin
354+ - python3-samba
355+ - winbind
356+ * Dropped:
357+ - d/control: drop python3-matplotlib. It's only used in
358+ script/attr_count_read which is not installed with the
359+ samba packages.
360+ [In 2:4.11.3+dfsg-1]
361+
362+ -- Andreas Hasenack <andreas@canonical.com> Mon, 17 Feb 2020 15:29:35 -0300
363+
364 samba (2:4.11.5+dfsg-1) unstable; urgency=medium
365
366 * New upstream security release
367@@ -134,6 +478,161 @@ samba (2:4.11.3+dfsg-1) unstable; urgency=high
368
369 -- Mathieu Parent <sathieu@debian.org> Mon, 16 Dec 2019 09:47:45 +0100
370
371+samba (2:4.11.1+dfsg-3ubuntu4) focal; urgency=medium
372+
373+ * Ubuntu i386 binary compatibility effort: (LP: #1861316)
374+ - debian/rules:
375+ + re-enable the following binary packages generation:
376+ - libnss-winbind
377+ - samba-common-bin
378+ - python3-samba
379+ - winbind
380+
381+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Thu, 06 Feb 2020 14:42:38 +0000
382+
383+samba (2:4.11.1+dfsg-3ubuntu3) focal; urgency=medium
384+
385+ * No-change rebuild to build with python3.8.
386+
387+ -- Matthias Klose <doko@ubuntu.com> Sat, 25 Jan 2020 06:06:11 +0000
388+
389+samba (2:4.11.1+dfsg-3ubuntu2) focal; urgency=medium
390+
391+ * Ubuntu i386 binary compatibility effort: (LP: #1858479)
392+ - debian/control:
393+ + drop ceph support
394+ - debian/rules:
395+ + drop ceph support
396+ + disable the following binary packages generation:
397+ - ctdb
398+ - libnss-winbind
399+ - libpam-winbind
400+ - python3-samba
401+ - samba
402+ - samba-common-bin
403+ - samba-testsuite
404+ - winbind
405+
406+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Thu, 09 Jan 2020 00:40:31 +0000
407+
408+samba (2:4.11.1+dfsg-3ubuntu1) focal; urgency=medium
409+
410+ * Merge with Debian unstable. Remaining changes:
411+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
412+ - debian/smb.conf;
413+ + Add "(Samba, Ubuntu)" to server string.
414+ + Comment out the default [homes] share, and add a comment about
415+ "valid users = %s" to show users how to restrict access to
416+ \\server\username to only username.
417+ - debian/samba-common.config:
418+ + Do not change priority to high if dhclient3 is installed.
419+ - d/control, d/rules: Disable glusterfs support because it's not in main.
420+ MIR bug is https://launchpad.net/bugs/1274247
421+ - d/p/fix-nfs-service-name-to-nfs-kernel-server.patch:
422+ change nfs service name from nfs to nfs-kernel-server
423+ (LP #722201)
424+ [Adopted the Debian version and added a couple of extra hunks
425+ we had]
426+ - d/p/ctdb-config-enable-syslog-by-default.patch:
427+ enable syslog and systemd journal by default
428+ * Dropped:
429+ - Add apport hook:
430+ + Created debian/source_samba.py.
431+ + debian/rules, debian/samba-common-bin.install: install hook.
432+ [In 2:4.9.4+dfsg-2]
433+ - Removed patches already applied upstream:
434+ + d/p/nsswitch-Add-try_authtok-option-to-pam_winbind.patch
435+ [Removed in 2:4.10.7+dfsg-1]
436+ + d/p/s3-auth-ignore-create_builtin_guests-failing-without.patch
437+ [Removed in 4.9.5+dfsg-1]
438+ - d/p/add-so-version-to-private-libraries: refreshed to remove fuzz
439+ [Refreshed in 2:4.1.17+dfsg-1]
440+ - d/control: Updated build dependencies (already updated in Debian):
441+ + tdb >= 1.3.17
442+ + talloc >= 2.1.15
443+ + tevent >= 0.9.38
444+ + ldb >= 1.5.3
445+ - d/samba-common.docs: README is now README.md
446+ [In 2:4.10.7+dfsg-1]
447+ - d/libsmbclient.symbols: update symbols for this version
448+ - d/libwbclient0.symbols: update symbols for this version
449+ - d/ctdb.install: new binary ctdb_local_daemons
450+ [In 2:4.10.7+dfsg-1]
451+ - d/samba-dev.install: use globbing for the header files with
452+ exceptions for wbclient.h and libsmbclient.h, which belong in
453+ other packages.
454+ [In 2:4.10.7+dfsg-1]
455+ - d/rules: fix globbing used to move the dckeytab python module to the
456+ samba package, and add a comment explaining why this is being done.
457+ [In 2:4.10.7+dfsg-1]
458+ - Switch to python3 (in 2:4.10.7+dfsg-1):
459+ + d/rules: calculate the ldb version using python3, and drop the
460+ "really" bit since the real 1.5.x series is being used now.
461+ + d/rules: make sure python3 is used for the build
462+ + d/rules: adjust globbing to remove the python3 version of tevent.so
463+ + d/rules: drop PYVERS, unused
464+ + d/control: adjust dependencies (build and runtime) for python3
465+ + d/python3-samba.install, d/control: new python3-samba package
466+ (LP #1440381)
467+ + d/control, d/python-samba.install: get rid of python-samba, which is py2
468+ + d/python3-samba.lintian-overrides: use the same overrides we had for
469+ python-samba, now deleted.
470+ + d/samba-dev.install, d/samba-libs.install: update file list
471+ + d/t/control, d/t/python-smoke: use python3
472+ + d/control: use ${python3:Depends} now instead of the python 2
473+ counterpart for samba and samba-common-bin.
474+ - d/control: drop suggests for python-gpgme, it's no longer available.
475+ [In 2:4.10.7+dfsg-1]
476+ - d/gbp.conf, d/watch, r/README.source: updated for 4.10
477+ [In 2:4.10.7+dfsg-1]
478+ - d/control: update cmocka build-depends to >= 1.1.3
479+ [In 2:4.10.7+dfsg-1]
480+ - d/samba-libs.install: bump passdb minor to 0.27.2
481+ [In 2:4.10.7+dfsg-1]
482+ - d/ctdb.install, d/rules: create ctdb run directory into tmpfiles.d
483+ to allow pid file to exist (LP #1821775)
484+ [In 2:4.10.7+dfsg-1]
485+ - Allow proper ctdb initalization (LP #1828799):
486+ + d/ctdb.dirs: added /var/lib/ctdb/* directories
487+ + d/ctdb.postrm: remove leftovers from:
488+ /var/lib/ctdb/{state,persistent,volatile,scripts}
489+ [In 2:4.10.7+dfsg-1]
490+ - d/rules: installing provided config examples and helper scripts
491+ - Examples of NFS HA CTDB config files + helper script:
492+ + d/ctdb.example.enable.nfs.sh
493+ + d/ctdb.example.nfs-common
494+ + d/ctdb.example.nfs-kernel-server
495+ + d/ctdb.example.services
496+ + d/ctdb.example.sysctl-nfs-static-ports.conf
497+ [In 2:4.10.7+dfsg-1]
498+ - debian/rules: Make DEB_HOST_ARCH_CPU initialized through
499+ dpkg-architecture (Closes: #931138)
500+ [In 2:4.10.7+dfsg-1]
501+ - d/control: update ldb build-deps to 1.5.5
502+ [In 2:4.10.7+dfsg-1]
503+ - SECURITY UPDATE: restricted share escape by user (LP #1842533)
504+ [fixed upstream in 4.11.0rc2]
505+ + debian/patches/CVE-2019-10197-01-v4-10.patch: smbd: separate
506+ out impersonation debug info into a new function.
507+ + debian/patches/CVE-2019-10197-02-v4-10.patch: smbd: make sure that
508+ change_to_user_internal() always resets current_user.done_chdir
509+ + debian/patches/CVE-2019-10197-03-v4-10.patch: smbd: make sure we
510+ reset current_user.{need,done}_chdir in become_root()
511+ + debian/patches/CVE-2019-10197-04-v4-10.patch: selftest: make
512+ fsrvp_share its own independent subdirectory
513+ + debian/patches/CVE-2019-10197-05-v4-10.patch:
514+ test_smbclient_s3.sh: add regression test for the no permission
515+ on share root problem
516+ + debian/patches/CVE-2019-10197-06-v4-10.patch: smbd: split
517+ change_to_user_impersonate() out of change_to_user_internal()
518+ + CVE-2019-10197
519+ * Added:
520+ - d/control: drop python3-matplotlib. It's only used in
521+ script/attr_count_read which is not installed with the
522+ samba packages.
523+
524+ -- Andreas Hasenack <andreas@canonical.com> Fri, 29 Nov 2019 18:00:22 -0300
525+
526 samba (2:4.11.1+dfsg-3) unstable; urgency=medium
527
528 * Add some python dependencies:
529@@ -342,6 +841,209 @@ samba (2:4.10.7+dfsg-1) experimental; urgency=medium
530
531 -- Mathieu Parent <sathieu@debian.org> Thu, 29 Aug 2019 14:32:52 +0200
532
533+samba (2:4.10.7+dfsg-0ubuntu3) focal; urgency=medium
534+
535+ * No-change rebuild to build with python3.8.
536+
537+ -- Matthias Klose <doko@ubuntu.com> Fri, 18 Oct 2019 18:53:34 +0000
538+
539+samba (2:4.10.7+dfsg-0ubuntu2) eoan; urgency=medium
540+
541+ * SECURITY UPDATE: restricted share escape by user (LP: #1842533)
542+ - debian/patches/CVE-2019-10197-01-v4-10.patch: smbd: separate
543+ out impersonation debug info into a new function.
544+ - debian/patches/CVE-2019-10197-02-v4-10.patch: smbd: make sure that
545+ change_to_user_internal() always resets current_user.done_chdir
546+ - debian/patches/CVE-2019-10197-03-v4-10.patch: smbd: make sure we
547+ reset current_user.{need,done}_chdir in become_root()
548+ - debian/patches/CVE-2019-10197-04-v4-10.patch: selftest: make
549+ fsrvp_share its own independent subdirectory
550+ - debian/patches/CVE-2019-10197-05-v4-10.patch:
551+ test_smbclient_s3.sh: add regression test for the no permission
552+ on share root problem
553+ - debian/patches/CVE-2019-10197-06-v4-10.patch: smbd: split
554+ change_to_user_impersonate() out of change_to_user_internal()
555+ - CVE-2019-10197
556+
557+ -- Steve Beattie <sbeattie@ubuntu.com> Fri, 30 Aug 2019 11:07:19 -0700
558+
559+samba (2:4.10.7+dfsg-0ubuntu1) eoan; urgency=medium
560+
561+ * New upstream version: 4.10.7
562+ - d/p/ctdb-config-depend-on-etc-default-nodes-file.patch: dropped,
563+ included upstream in 4.10.7
564+
565+ -- Andreas Hasenack <andreas@canonical.com> Thu, 22 Aug 2019 15:03:23 -0300
566+
567+samba (2:4.10.6+dfsg-0ubuntu1) eoan; urgency=medium
568+
569+ * New upstream version: 4.10.6
570+ - d/p/fix-nfs-service-name-to-nfs-kernel-server.patch: changed to update
571+ the Debian config and use it.
572+ - d/control: update ldb build-deps to 1.5.5
573+ * Dropped:
574+ - d/p/CVE-2019-12436.patch: fixed upstream in 4.10.5
575+ - d/p/CVE-2019-12435-*.patch: fixed upstream in 4.10.5
576+ - d/p/CVE-2018-16860-*.patch: fixed upstream in 4.10.3
577+ - d/p/CVE-2019-3880.patch: fixed upstream in 4.10.2
578+ - d/p/CVE-2019-3870-*.patch: fixed upstream in 4.10.2
579+ - d/p/dlz_bind_zone_update.patch: fixed upstream in 4.10.1
580+ - d/p/ctdb-scripts-fix-tcp_tw_recycle-existence-check.patch: fixed
581+ upstream in 4.10.5
582+
583+ -- Andreas Hasenack <andreas@canonical.com> Wed, 07 Aug 2019 17:20:48 -0300
584+
585+samba (2:4.10.0+dfsg-0ubuntu6) eoan; urgency=medium
586+
587+ * d/p/fix-nfs-service-name-to-nfs-kernel-server.patch:
588+ change service name from nfs to nfs-kernel-server in
589+ legacy script 06.nfs.script also (LP: #722201)
590+
591+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Thu, 11 Jul 2019 21:44:49 +0000
592+
593+samba (2:4.10.0+dfsg-0ubuntu5) eoan; urgency=medium
594+
595+ * debian/rules: Make DEB_HOST_ARCH_CPU initialized through
596+ dpkg-architecture (Closes: #931138)
597+ * d/p/ctdb-scripts-fix-tcp_tw_recycle-existence-check.patch:
598+ fix tcp_tw_recycle existence check. (LP: #722201)
599+ * d/p/fix-nfs-service-name-to-nfs-kernel-server.patch:
600+ change nfs service name from nfs to nfs-kernel-server
601+ (LP: #722201)
602+ * d/ctdb.install, d/rules: create ctdb run directory into tmpfiles.d
603+ to allow pid file to exist (LP: #1821775)
604+ * Allow proper ctdb initialization (LP: #1828799):
605+ - d/ctdb.dirs: added /var/lib/ctdb/* directories
606+ - d/ctdb.postrm: remove leftovers from:
607+ /var/lib/ctdb/{state,persistent,volatile,scripts}
608+ * d/rules: installing provided config examples and helper scripts
609+ * Examples of NFS HA CTDB config files + helper script:
610+ - d/ctdb.example.enable.nfs.sh
611+ - d/ctdb.example.nfs-common
612+ - d/ctdb.example.nfs-kernel-server
613+ - d/ctdb.example.services
614+ - d/ctdb.example.sysctl-nfs-static-ports.conf
615+ * d/p/ctdb-config-depend-on-etc-default-nodes-file.patch:
616+ do not try to start daemon if /etc/ctdb/nodes does not exist
617+ * d/p/ctdb-config-enable-syslog-by-default.patch:
618+ enable syslog and systemd journal by default
619+
620+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Fri, 28 Jun 2019 00:14:27 +0000
621+
622+samba (2:4.10.0+dfsg-0ubuntu4) eoan; urgency=medium
623+
624+ * SECURITY UPDATE: zone operations can crash rpc server
625+ - debian/patches/CVE-2019-12435-1.patch: avoid NULL deference if zone
626+ not found in DnssrvOperation in
627+ python/samba/tests/dcerpc/dnsserver.py,
628+ source4/rpc_server/dnsserver/dcerpc_dnsserver.c.
629+ - debian/patches/CVE-2019-12435-2.patch: avoid NULL deference if zone
630+ not found in DnssrvOperation2 in
631+ python/samba/tests/dcerpc/dnsserver.py,
632+ source4/rpc_server/dnsserver/dcerpc_dnsserver.c.
633+ - CVE-2019-12435
634+ * SECURITY UPDATE: paged_searches crash on LDAP and homes access
635+ - debian/patches/CVE-2019-12436.patch: ignore successful results
636+ without messages in source4/dsdb/samdb/ldb_modules/paged_results.c,
637+ source4/dsdb/tests/python/vlv.py.
638+ - CVE-2019-12436
639+
640+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Wed, 12 Jun 2019 10:08:44 -0400
641+
642+samba (2:4.10.0+dfsg-0ubuntu3) eoan; urgency=medium
643+
644+ * SECURITY UPDATE: Samba AD DC S4U2Self/S4U2Proxy unkeyed checksum
645+ - debian/patches/CVE-2018-16860-1.patch: add test for S4U2Self with
646+ unkeyed checksum in selftest/knownfail.d/mitm-s4u2self,
647+ source4/torture/krb5/kdc-canon-heimdal.c.
648+ - debian/patches/CVE-2018-16860-2.patch: reject PA-S4U2Self with
649+ unkeyed checksum in selftest/knownfail.d/mitm-s4u2self,
650+ source4/heimdal/kdc/krb5tgs.c.
651+ - CVE-2018-16860
652+
653+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Tue, 14 May 2019 09:10:24 -0400
654+
655+samba (2:4.10.0+dfsg-0ubuntu2) disco; urgency=medium
656+
657+ * SECURITY UPDATE: world writable files in Samba AD DC private/ dir
658+ - debian/patches/CVE-2019-3870-1.patch: extend smbd tests to check for
659+ umask being overwritten in python/samba/tests/ntacls_backup.py,
660+ python/samba/tests/posixacl.py, python/samba/tests/smbd_base.py,
661+ selftest/knownfail.d/umask-leak.
662+ - debian/patches/CVE-2019-3870-2.patch: add test to check
663+ file-permissions are correct after provision in
664+ selftest/knownfail.d/provision_fileperms, source4/selftest/tests.py,
665+ source4/setup/tests/provision_fileperms.sh.
666+ - debian/patches/CVE-2019-3870-3.patch: include tests to show the
667+ outside umask has no impact in python/samba/tests/ntacls_backup.py,
668+ python/samba/tests/smbd_base.py, selftest/knownfail.d/pymkdir-umask.
669+ - debian/patches/CVE-2019-3870-4.patch: move umask manipuations as
670+ close as possible to users in source3/smbd/pysmbd.c,
671+ selftest/knownfail.d/provision_fileperms,
672+ selftest/knownfail.d/umask-leak.
673+ - debian/patches/CVE-2019-3870-5.patch: ensure a zero umask is set for
674+ smbd.mkdir() in selftest/knownfail.d/pymkdir-umask,
675+ source3/smbd/pysmbd.c.
676+ - CVE-2019-3870
677+ * SECURITY UPDATE: save registry file outside share as unprivileged user
678+ - debian/patches/CVE-2019-3880.patch: remove implementations of
679+ SaveKey/RestoreKey in source3/rpc_server/winreg/srv_winreg_nt.c.
680+ - CVE-2019-3880
681+
682+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Mon, 08 Apr 2019 10:32:30 -0400
683+
684+samba (2:4.10.0+dfsg-0ubuntu1) disco; urgency=medium
685+
686+ * New upstream version: 4.10.0
687+ - d/gbp.conf, d/watch, r/README.source: updated for 4.10
688+ - d/control: update cmocka build-depends to >= 1.1.3
689+ - d/samba-libs.install: bump passdb minor to 0.27.2
690+ * d/p/dlz_bind_zone_update.patch: make b9_has_soa check dc=@ node. Thanks to
691+ Michael Saxl <mike@mwsys.mine.bz>. (LP: #1820846)
692+
693+ -- Andreas Hasenack <andreas@canonical.com> Thu, 21 Mar 2019 14:40:32 -0300
694+
695+samba (2:4.10.0~rc4+dfsg-0ubuntu1) disco; urgency=medium
696+
697+ * New upstream version 4.10.0rc4 (LP: #1818518):
698+ - Removed patches already applied upstream:
699+ + d/p/nsswitch-Add-try_authtok-option-to-pam_winbind.patch
700+ + d/p/s3-auth-ignore-create_builtin_guests-failing-without.patch
701+ - d/p/add-so-version-to-private-libraries: refreshed to remove fuzz
702+ - d/control: Updated build dependencies:
703+ + tdb >= 1.3.17
704+ + talloc >= 2.1.15
705+ + tevent >= 0.9.38
706+ + ldb >= 1.5.3
707+ - d/samba-common.docs: README is now README.md
708+ - d/libsmbclient.symbols: update symbols for this version
709+ - d/libwbclient0.symbols: update symbols for this version
710+ - d/ctdb.install: new binary ctdb_local_daemons
711+ - d/samba-dev.install: use globbing for the header files with
712+ exceptions for wbclient.h and libsmbclient.h, which belong in
713+ other packages.
714+ - d/rules: fix globbing used to move the dckeytab python module to the
715+ samba package, and add a comment explaining why this is being done.
716+ * Switch to python3:
717+ - d/rules: calculate the ldb version using python3, and drop the
718+ "really" bit since the real 1.5.x series is being used now.
719+ - d/rules: make sure python3 is used for the build
720+ - d/rules: adjust globbing to remove the python3 version of tevent.so
721+ - d/rules: drop PYVERS, unused
722+ - d/control: adjust dependencies (build and runtime) for python3
723+ - d/python3-samba.install, d/control: new python3-samba package
724+ (LP: #1440381)
725+ - d/control, d/python-samba.install: get rid of python-samba, which is py2
726+ - d/python3-samba.lintian-overrides: use the same overrides we had for
727+ python-samba, now deleted.
728+ - d/samba-dev.install, d/samba-libs.install: update file list
729+ - d/t/control, d/t/python-smoke: use python3
730+ - d/control: use ${python3:Depends} now instead of the python 2
731+ counterpart for samba and samba-common-bin.
732+ * d/control: drop suggests for python-gpgme, it's no longer available.
733+
734+ -- Andreas Hasenack <andreas@canonical.com> Sat, 09 Mar 2019 12:45:25 +0000
735+
736 samba (2:4.9.5+dfsg-1) experimental; urgency=medium
737
738 * New upstream release
739@@ -386,6 +1088,31 @@ samba (2:4.9.4+dfsg-2) unstable; urgency=medium
740
741 -- Mathieu Parent <sathieu@debian.org> Wed, 23 Jan 2019 20:59:08 +0100
742
743+samba (2:4.9.4+dfsg-1ubuntu1) disco; urgency=medium
744+
745+ * Merge with Debian unstable. Remaining changes:
746+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
747+ - debian/smb.conf;
748+ + Add "(Samba, Ubuntu)" to server string.
749+ + Comment out the default [homes] share, and add a comment about
750+ "valid users = %s" to show users how to restrict access to
751+ \\server\username to only username.
752+ - debian/samba-common.config:
753+ + Do not change priority to high if dhclient3 is installed.
754+ - Add apport hook:
755+ + Created debian/source_samba.py.
756+ + debian/rules, debian/samba-common-bin.install: install hook.
757+ - d/control, d/rules: Disable glusterfs support because it's not in main.
758+ MIR bug is https://launchpad.net/bugs/1274247
759+ * Dropped:
760+ - d/p/smbd-startup-with-winbind.patch: ignore create_builtin_guests()
761+ failing without a valid idmap configuration. This fixes the smbd startup
762+ on a standalone server where winbind is available and running. Thanks to
763+ Stefan Metzmacher <metze@samba.org>. (LP #1806035)
764+ [Fixed in 2:4.9.4+dfsg-1]
765+
766+ -- Andreas Hasenack <andreas@canonical.com> Thu, 17 Jan 2019 18:23:52 -0200
767+
768 samba (2:4.9.4+dfsg-1) unstable; urgency=medium
769
770 * New upstream release
771@@ -396,6 +1123,44 @@ samba (2:4.9.4+dfsg-1) unstable; urgency=medium
772
773 -- Mathieu Parent <sathieu@debian.org> Sat, 22 Dec 2018 18:32:00 +0100
774
775+samba (2:4.9.2+dfsg-2ubuntu3) disco; urgency=medium
776+
777+ * No-change rebuild for readline soname change.
778+
779+ -- Matthias Klose <doko@ubuntu.com> Mon, 14 Jan 2019 20:03:58 +0000
780+
781+samba (2:4.9.2+dfsg-2ubuntu2) disco; urgency=medium
782+
783+ * d/p/smbd-startup-with-winbind.patch: ignore create_builtin_guests()
784+ failing without a valid idmap configuration. This fixes the smbd startup
785+ on a standalone server where winbind is available and running. Thanks to
786+ Stefan Metzmacher <metze@samba.org>. (LP: #1806035)
787+
788+ -- Andreas Hasenack <andreas@canonical.com> Fri, 21 Dec 2018 10:39:23 -0200
789+
790+samba (2:4.9.2+dfsg-2ubuntu1) disco; urgency=medium
791+
792+ * Merge with Debian unstable. Remaining changes:
793+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
794+ - debian/smb.conf;
795+ + Add "(Samba, Ubuntu)" to server string.
796+ + Comment out the default [homes] share, and add a comment about
797+ "valid users = %s" to show users how to restrict access to
798+ \\server\username to only username.
799+ - debian/samba-common.config:
800+ + Do not change priority to high if dhclient3 is installed.
801+ - Add apport hook:
802+ + Created debian/source_samba.py.
803+ + debian/rules, debian/samba-common-bin.install: install hook.
804+ - d/control, d/rules: Disable glusterfs support because it's not in main.
805+ MIR bug is https://launchpad.net/bugs/1274247
806+ * Dropped:
807+ - d/p/fix-rmdir.patch: Fix to make smbclient report directory-not-empty
808+ errors (LP: 1795772)
809+ [Fixed upstream]
810+
811+ -- Andreas Hasenack <andreas@canonical.com> Wed, 28 Nov 2018 20:06:47 -0200
812+
813 samba (2:4.9.2+dfsg-2) unstable; urgency=high
814
815 * New upstream security release
816@@ -505,6 +1270,58 @@ samba (2:4.8.5+dfsg-1) unstable; urgency=medium
817
818 -- Mathieu Parent <sathieu@debian.org> Thu, 30 Aug 2018 19:32:24 +0200
819
820+samba (2:4.8.4+dfsg-2ubuntu3) disco; urgency=medium
821+
822+ * No-change rebuild against libldb1 1.4.2
823+
824+ -- Steve Langasek <steve.langasek@ubuntu.com> Wed, 14 Nov 2018 22:46:24 +0000
825+
826+samba (2:4.8.4+dfsg-2ubuntu2) cosmic; urgency=high
827+
828+ [ Karl Stenerud ]
829+ * d/p/fix-rmdir.patch: Fix to make the samba client library report
830+ directory-not-empty errors (LP: #1795772)
831+
832+ -- Andreas Hasenack <andreas@canonical.com> Tue, 09 Oct 2018 14:32:16 -0300
833+
834+samba (2:4.8.4+dfsg-2ubuntu1) cosmic; urgency=medium
835+
836+ * Merge with Debian unstable (LP: #1778125). Remaining changes:
837+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
838+ - debian/smb.conf;
839+ + Add "(Samba, Ubuntu)" to server string.
840+ + Comment out the default [homes] share, and add a comment about
841+ "valid users = %s" to show users how to restrict access to
842+ \\server\username to only username.
843+ - debian/samba-common.config:
844+ + Do not change priority to high if dhclient3 is installed.
845+ - Add apport hook:
846+ + Created debian/source_samba.py.
847+ + debian/rules, debian/samba-common-bin.install: install hook.
848+ - d/control, d/rules: Disable glusterfs support because it's not in main.
849+ MIR bug is https://launchpad.net/bugs/1274247
850+ * Drop:
851+ - Add extra DEP8 tests to samba (LP #1696823):
852+ + d/t/control, d/t/cifs-share-access: access a file in a share using cifs
853+ + d/t/control, d/t/smbclient-anonymous-share-list: list available shares
854+ anonymously
855+ + d/t/control, d/t/smbclient-authenticated-share-list: list available
856+ shares using an authenticated connection
857+ + d/t/control, d/t/smbclient-share-access: create a share and download a
858+ file from it
859+ [Accepted by Debian in 2:4.7.4+dfsg-2]
860+ - d/samba-common.dhcp: If systemctl is available, use it to query the
861+ status of the smbd service before trying to reload it. Otherwise,
862+ keep the same check as before and reload the service based on the
863+ existence of the initscript. (LP #1579597)
864+ [In Debian since 2:4.7.4+dfsg-2]
865+ - debian/patches/passdb_dont_return_ok_if_pinfo_not_filled.patch:
866+ [PATCH] s3:passdb: Do not return OK if we don't have pinfo filled.
867+ Thanks to Andreas Schneider <asn@samba.org>. (LP #1761737)
868+ [Fixed upstream]
869+
870+ -- Andreas Hasenack <andreas@canonical.com> Tue, 21 Aug 2018 09:57:57 -0300
871+
872 samba (2:4.8.4+dfsg-2) unstable; urgency=high
873
874 * Fix typo in previous release: s/usefull/useful/
875@@ -662,6 +1479,55 @@ samba (2:4.8.0+dfsg-1) experimental; urgency=medium
876
877 -- Mathieu Parent <sathieu@debian.org> Mon, 19 Mar 2018 13:02:51 +0100
878
879+samba (2:4.7.6+dfsg~ubuntu-0ubuntu3) cosmic; urgency=medium
880+
881+ * No change rebuild to link with new ldb 1.3.3
882+
883+ -- Andreas Hasenack <andreas@canonical.com> Tue, 03 Jul 2018 09:57:24 -0300
884+
885+samba (2:4.7.6+dfsg~ubuntu-0ubuntu2) bionic; urgency=medium
886+
887+ * debian/patches/passdb_dont_return_ok_if_pinfo_not_filled.patch:
888+ [PATCH] s3:passdb: Do not return OK if we don't have pinfo filled.
889+ Thanks to Andreas Schneider <asn@samba.org>. (LP: #1761737)
890+
891+ -- Andreas Hasenack <andreas@canonical.com> Wed, 18 Apr 2018 11:49:55 -0300
892+
893+samba (2:4.7.6+dfsg~ubuntu-0ubuntu1) bionic; urgency=medium
894+
895+ * New upstream version:
896+ - Fix database corruption bug when upgrading from samba 4.6 or lower
897+ AD controllers (LP: #1755057)
898+ - Fix security issues: CVE-2018-1050 and CVE-2018-1057 (LP: #1755059)
899+ * Remaining changes:
900+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
901+ - debian/smb.conf;
902+ + Add "(Samba, Ubuntu)" to server string.
903+ + Comment out the default [homes] share, and add a comment about
904+ "valid users = %s" to show users how to restrict access to
905+ \\server\username to only username.
906+ - debian/samba-common.config:
907+ + Do not change priority to high if dhclient3 is installed.
908+ - Add apport hook:
909+ + Created debian/source_samba.py.
910+ + debian/rules, debian/samba-common-bin.install: install hook.
911+ - Add extra DEP8 tests to samba (LP #1696823):
912+ + d/t/control, d/t/cifs-share-access: access a file in a share using cifs
913+ + d/t/control, d/t/smbclient-anonymous-share-list: list available shares
914+ anonymously
915+ + d/t/control, d/t/smbclient-authenticated-share-list: list available
916+ shares using an authenticated connection
917+ + d/t/control, d/t/smbclient-share-access: create a share and download a
918+ file from it
919+ - d/samba-common.dhcp: If systemctl is available, use it to query the
920+ status of the smbd service before trying to reload it. Otherwise,
921+ keep the same check as before and reload the service based on the
922+ existence of the initscript. (LP #1579597)
923+ - d/control, d/rules: Disable glusterfs support because it's not in main.
924+ MIR bug is https://launchpad.net/bugs/1274247
925+
926+ -- Andreas Hasenack <andreas@canonical.com> Tue, 13 Mar 2018 16:58:49 -0300
927+
928 samba (2:4.7.4+dfsg-2) unstable; urgency=high
929
930 [ Mathieu Parent ]
931@@ -692,6 +1558,37 @@ samba (2:4.7.4+dfsg-2) unstable; urgency=high
932
933 -- Mathieu Parent <sathieu@debian.org> Fri, 02 Mar 2018 20:55:06 +0100
934
935+samba (2:4.7.4+dfsg-1ubuntu1) bionic; urgency=medium
936+
937+ * Merge with Debian unstable (LP: #1744779). Remaining changes:
938+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
939+ - debian/smb.conf;
940+ + Add "(Samba, Ubuntu)" to server string.
941+ + Comment out the default [homes] share, and add a comment about
942+ "valid users = %s" to show users how to restrict access to
943+ \\server\username to only username.
944+ - debian/samba-common.config:
945+ + Do not change priority to high if dhclient3 is installed.
946+ - Add apport hook:
947+ + Created debian/source_samba.py.
948+ + debian/rules, debian/samba-common-bin.install: install hook.
949+ - Add extra DEP8 tests to samba (LP #1696823):
950+ + d/t/control, d/t/cifs-share-access: access a file in a share using cifs
951+ + d/t/control, d/t/smbclient-anonymous-share-list: list available shares
952+ anonymously
953+ + d/t/control, d/t/smbclient-authenticated-share-list: list available
954+ shares using an authenticated connection
955+ + d/t/control, d/t/smbclient-share-access: create a share and download a
956+ file from it
957+ - d/samba-common.dhcp: If systemctl is available, use it to query the
958+ status of the smbd service before trying to reload it. Otherwise,
959+ keep the same check as before and reload the service based on the
960+ existence of the initscript. (LP #1579597)
961+ - d/control, d/rules: Disable glusterfs support because it's not in main.
962+ MIR bug is https://launchpad.net/bugs/1274247
963+
964+ -- Andreas Hasenack <andreas@canonical.com> Mon, 22 Jan 2018 16:31:41 -0200
965+
966 samba (2:4.7.4+dfsg-1) unstable; urgency=medium
967
968 * New upstream version
969@@ -708,6 +1605,42 @@ samba (2:4.7.4+dfsg-1) unstable; urgency=medium
970
971 -- Mathieu Parent <sathieu@debian.org> Thu, 11 Jan 2018 20:49:28 +0100
972
973+samba (2:4.7.3+dfsg-1ubuntu1) bionic; urgency=medium
974+
975+ * Merge with Debian; remaining changes:
976+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
977+ - debian/smb.conf;
978+ + Add "(Samba, Ubuntu)" to server string.
979+ + Comment out the default [homes] share, and add a comment about
980+ "valid users = %s" to show users how to restrict access to
981+ \\server\username to only username.
982+ - debian/samba-common.config:
983+ + Do not change priority to high if dhclient3 is installed.
984+ - Add apport hook:
985+ + Created debian/source_samba.py.
986+ + debian/rules, debian/samba-common-bin.install: install hook.
987+ - Add extra DEP8 tests to samba (LP #1696823):
988+ + d/t/control: enable the new DEP8 tests
989+ + d/t/smbclient-anonymous-share-list: list available shares anonymously
990+ + d/t/smbclient-authenticated-share-list: list available shares using
991+ an authenticated connection
992+ + d/t/smbclient-share-access: create a share and download a file from it
993+ + d/t/cifs-share-access: access a file in a share using cifs
994+ - Ask the user if we can run testparm against the config file. If yes,
995+ include its stderr and exit status in the bug report. Otherwise, only
996+ include the exit status. (LP #1694334)
997+ - If systemctl is available, use it to query the status of the smbd
998+ service before trying to reload it. Otherwise, keep the same check
999+ as before and reload the service based on the existence of the
1000+ initscript. (LP #1579597)
1001+ - d/rules: Compile winbindd/winbindd statically.
1002+ - Disable glusterfs support because it's not in main.
1003+ MIR bug is https://launchpad.net/bugs/1274247
1004+ - d/source_samba.py: use the new recommended findmnt(8) tool to list
1005+ mountpoints and correctly filter by the cifs filesystem type.
1006+
1007+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Tue, 05 Dec 2017 12:49:20 -0500
1008+
1009 samba (2:4.7.3+dfsg-1) unstable; urgency=high
1010
1011 * New upstream version
1012@@ -731,6 +1664,42 @@ samba (2:4.7.1+dfsg-2) unstable; urgency=high
1013
1014 -- Mathieu Parent <sathieu@debian.org> Sun, 12 Nov 2017 10:02:19 +0100
1015
1016+samba (2:4.7.1+dfsg-1ubuntu1) bionic; urgency=medium
1017+
1018+ * Merge with Debian; remaining changes:
1019+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
1020+ - debian/smb.conf;
1021+ + Add "(Samba, Ubuntu)" to server string.
1022+ + Comment out the default [homes] share, and add a comment about
1023+ "valid users = %s" to show users how to restrict access to
1024+ \\server\username to only username.
1025+ - debian/samba-common.config:
1026+ + Do not change priority to high if dhclient3 is installed.
1027+ - Add apport hook:
1028+ + Created debian/source_samba.py.
1029+ + debian/rules, debian/samba-common-bin.install: install hook.
1030+ - Add extra DEP8 tests to samba (LP #1696823):
1031+ + d/t/control: enable the new DEP8 tests
1032+ + d/t/smbclient-anonymous-share-list: list available shares anonymously
1033+ + d/t/smbclient-authenticated-share-list: list available shares using
1034+ an authenticated connection
1035+ + d/t/smbclient-share-access: create a share and download a file from it
1036+ + d/t/cifs-share-access: access a file in a share using cifs
1037+ - Ask the user if we can run testparm against the config file. If yes,
1038+ include its stderr and exit status in the bug report. Otherwise, only
1039+ include the exit status. (LP #1694334)
1040+ - If systemctl is available, use it to query the status of the smbd
1041+ service before trying to reload it. Otherwise, keep the same check
1042+ as before and reload the service based on the existence of the
1043+ initscript. (LP #1579597)
1044+ - d/rules: Compile winbindd/winbindd statically.
1045+ - Disable glusterfs support because it's not in main.
1046+ MIR bug is https://launchpad.net/bugs/1274247
1047+ - d/source_samba.py: use the new recommended findmnt(8) tool to list
1048+ mountpoints and correctly filter by the cifs filesystem type.
1049+
1050+ -- Matthias Klose <doko@ubuntu.com> Fri, 10 Nov 2017 10:03:57 +0100
1051+
1052 samba (2:4.7.1+dfsg-1) unstable; urgency=medium
1053
1054 * New upstream version
1055@@ -779,6 +1748,87 @@ samba (2:4.6.7+dfsg-2) unstable; urgency=high
1056
1057 -- Mathieu Parent <sathieu@debian.org> Tue, 19 Sep 2017 22:00:13 +0200
1058
1059+samba (2:4.6.7+dfsg-1ubuntu3) artful; urgency=medium
1060+
1061+ * SECURITY UPDATE: SMB1/2/3 connections may not require signing where
1062+ they should
1063+ - debian/patches/CVE-2017-12150-1.patch: don't turn a guessed username
1064+ into a specified one in source3/include/auth_info.h,
1065+ source3/lib/popt_common.c, source3/lib/util_cmdline.c.
1066+ - debian/patches/CVE-2017-12150-2.patch: add SMB_SIGNING_REQUIRED to
1067+ source3/lib/util_cmdline.c.
1068+ - debian/patches/CVE-2017-12150-3.patch: add SMB_SIGNING_REQUIRED to
1069+ source3/libsmb/pylibsmb.c.
1070+ - debian/patches/CVE-2017-12150-4.patch: add SMB_SIGNING_REQUIRED to
1071+ libgpo/gpo_fetch.c.
1072+ - debian/patches/CVE-2017-12150-5.patch: add check for
1073+ NTLM_CCACHE/SIGN/SEAL to auth/credentials/credentials.c.
1074+ - debian/patches/CVE-2017-12150-6.patch: add
1075+ smbXcli_conn_signing_mandatory() to libcli/smb/smbXcli_base.*.
1076+ - debian/patches/CVE-2017-12150-7.patch: only fallback to anonymous if
1077+ authentication was not requested in source3/libsmb/clidfs.c.
1078+ - CVE-2017-12150
1079+ * SECURITY UPDATE: SMB3 connections don't keep encryption across DFS
1080+ redirects
1081+ - debian/patches/CVE-2017-12151-1.patch: add
1082+ cli_state_is_encryption_on() helper function to
1083+ source3/libsmb/clientgen.c, source3/libsmb/proto.h.
1084+ - debian/patches/CVE-2017-12151-2.patch: make use of
1085+ cli_state_is_encryption_on() in source3/libsmb/clidfs.c,
1086+ source3/libsmb/libsmb_context.c.
1087+ - CVE-2017-12151
1088+ * SECURITY UPDATE: Server memory information leak over SMB1
1089+ - debian/patches/CVE-2017-12163.patch: prevent client short SMB1 write
1090+ from writing server memory to file in source3/smbd/reply.c.
1091+ - CVE-2017-12163
1092+
1093+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Thu, 21 Sep 2017 08:10:03 -0400
1094+
1095+samba (2:4.6.7+dfsg-1ubuntu2) artful; urgency=medium
1096+
1097+ * d/source_samba.py: use the new recommended findmnt(8) tool to list
1098+ mountpoints and correctly filter by the cifs filesystem type.
1099+ (LP: #1703604)
1100+
1101+ -- Andreas Hasenack <andreas@canonical.com> Fri, 01 Sep 2017 09:47:58 -0300
1102+
1103+samba (2:4.6.7+dfsg-1ubuntu1) artful; urgency=medium
1104+
1105+ * Merge with Debian unstable (LP: #1710281).
1106+ - Upstream version 4.6.7 fixes the CVE-2017-2619 regression with non-wide
1107+ symlinks to directories (LP: #1701073)
1108+ * Remaining changes:
1109+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
1110+ - debian/smb.conf;
1111+ + Add "(Samba, Ubuntu)" to server string.
1112+ + Comment out the default [homes] share, and add a comment about
1113+ "valid users = %s" to show users how to restrict access to
1114+ \\server\username to only username.
1115+ - debian/samba-common.config:
1116+ + Do not change priority to high if dhclient3 is installed.
1117+ - Add apport hook:
1118+ + Created debian/source_samba.py.
1119+ + debian/rules, debian/samba-common-bin.install: install hook.
1120+ - Add extra DEP8 tests to samba (LP #1696823):
1121+ + d/t/control: enable the new DEP8 tests
1122+ + d/t/smbclient-anonymous-share-list: list available shares anonymously
1123+ + d/t/smbclient-authenticated-share-list: list available shares using
1124+ an authenticated connection
1125+ + d/t/smbclient-share-access: create a share and download a file from it
1126+ + d/t/cifs-share-access: access a file in a share using cifs
1127+ - Ask the user if we can run testparm against the config file. If yes,
1128+ include its stderr and exit status in the bug report. Otherwise, only
1129+ include the exit status. (LP #1694334)
1130+ - If systemctl is available, use it to query the status of the smbd
1131+ service before trying to reload it. Otherwise, keep the same check
1132+ as before and reload the service based on the existence of the
1133+ initscript. (LP #1579597)
1134+ - d/rules: Compile winbindd/winbindd statically.
1135+ - Disable glusterfs support because it's not in main.
1136+ MIR bug is https://launchpad.net/bugs/1274247
1137+
1138+ -- Andreas Hasenack <andreas@canonical.com> Mon, 21 Aug 2017 17:27:08 -0300
1139+
1140 samba (2:4.6.7+dfsg-1) unstable; urgency=medium
1141
1142 * New upstream version
1143@@ -790,6 +1840,60 @@ samba (2:4.6.7+dfsg-1) unstable; urgency=medium
1144
1145 -- Mathieu Parent <sathieu@debian.org> Tue, 15 Aug 2017 23:06:36 +0200
1146
1147+samba (2:4.6.5+dfsg-8ubuntu1) artful; urgency=medium
1148+
1149+ * Merge with Debian unstable (LP: #1700644). Remaining changes:
1150+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
1151+ - debian/smb.conf;
1152+ + Add "(Samba, Ubuntu)" to server string.
1153+ + Comment out the default [homes] share, and add a comment about
1154+ "valid users = %s" to show users how to restrict access to
1155+ \\server\username to only username.
1156+ - debian/samba-common.config:
1157+ + Do not change priority to high if dhclient3 is installed.
1158+ - Add apport hook:
1159+ + Created debian/source_samba.py.
1160+ + debian/rules, debian/samba-common-bin.install: install hook.
1161+ - Add extra DEP8 tests to samba (LP #1696823):
1162+ + d/t/control: enable the new DEP8 tests
1163+ + d/t/smbclient-anonymous-share-list: list available shares anonymously
1164+ + d/t/smbclient-authenticated-share-list: list available shares using
1165+ an authenticated connection
1166+ + d/t/smbclient-share-access: create a share and download a file from it
1167+ + d/t/cifs-share-access: access a file in a share using cifs
1168+ - Ask the user if we can run testparm against the config file. If yes,
1169+ include its stderr and exit status in the bug report. Otherwise, only
1170+ include the exit status. (LP #1694334)
1171+ - If systemctl is available, use it to query the status of the smbd
1172+ service before trying to reload it. Otherwise, keep the same check
1173+ as before and reload the service based on the existence of the
1174+ initscript. (LP #1579597)
1175+ * Drop:
1176+ - d/rules: Compile winbindd/winbindd statically. (LP: #1700527)
1177+ [This hunk was missed in 2:4.5.8+dfsg-2ubuntu2 when patch
1178+ fix-1584485.patch was dropped there.]
1179+ - d/p/krb_zero_cursor.patch - apply proposed-upstream fix for
1180+ pam_winbind krb5_ccache_type=FILE failure
1181+ [Replaced by d/p/s3-gse_krb5-fix-a-possible-crash-in-fill_mem_keytab.patch
1182+ in 2:4.6.5+dfsg-3 that closed Debian's bug #739768]
1183+ - debian/patches/winbind_trusted_domains.patch: make sure domain
1184+ members can talk to trusted domains DCs.
1185+ [Upstream committed a different fix, see updated patch attached to
1186+ https://bugzilla.samba.org/show_bug.cgi?id=11830]
1187+ - d/control: add libcephfs-dev as b-d to build vfs_ceph
1188+ [Adopted by Debian in 2:4.6.5+dfsg-1]
1189+ - debian/patches/CVE-2017-11103.patch: use encrypted service
1190+ name rather than unencrypted (and therefore spoofable) version
1191+ in heimdal
1192+ [Adopted by Debian as
1193+ d/p/CVE-2017-11103-Orpheus-Lyre-KDC-REP-service-name-val.patch]
1194+ - Cherrypick upstream patch to fix FTBFS with new ceph lib.
1195+ [Merged upstream in 4.6.0rc1]
1196+ * Disable glusterfs support because it's not in main.
1197+ MIR bug is https://launchpad.net/bugs/1274247
1198+
1199+ -- Andreas Hasenack <andreas@canonical.com> Thu, 10 Aug 2017 22:20:22 -0300
1200+
1201 samba (2:4.6.5+dfsg-8) unstable; urgency=medium
1202
1203 * Remove dependency on update-inetd, not used anymore
1204@@ -909,6 +2013,77 @@ samba (2:4.6.5+dfsg-1) experimental; urgency=medium
1205
1206 -- Mathieu Parent <sathieu@debian.org> Mon, 12 Jun 2017 08:09:43 +0200
1207
1208+samba (2:4.5.8+dfsg-2ubuntu5) artful; urgency=medium
1209+
1210+ * Cherrypick upstream patch to fix FTBFS with new ceph lib.
1211+
1212+ -- Dimitri John Ledkov <xnox@ubuntu.com> Wed, 26 Jul 2017 08:34:24 +0100
1213+
1214+samba (2:4.5.8+dfsg-2ubuntu4) artful; urgency=medium
1215+
1216+ * SECURITY UPDATE: KDC-REP service name impersonation
1217+ - debian/patches/CVE-2017-11103.patch: use encrypted service
1218+ name rather than unencrypted (and therefore spoofable) version
1219+ in heimdal
1220+ - CVE-2017-11103
1221+
1222+ -- Steve Beattie <sbeattie@ubuntu.com> Mon, 17 Jul 2017 16:22:28 -0700
1223+
1224+samba (2:4.5.8+dfsg-2ubuntu3) artful; urgency=medium
1225+
1226+ * No-change rebuild against libldb 1.1.29
1227+
1228+ -- Steve Langasek <steve.langasek@ubuntu.com> Sun, 25 Jun 2017 16:09:33 -0700
1229+
1230+samba (2:4.5.8+dfsg-2ubuntu2) artful; urgency=medium
1231+
1232+ * Add extra DEP8 tests to samba (LP: #1696823):
1233+ - d/t/control: enable the new DEP8 tests
1234+ - d/t/smbclient-anonymous-share-list: list available shares anonymously
1235+ - d/t/smbclient-authenticated-share-list: list available shares using
1236+ an authenticated connection
1237+ - d/t/smbclient-share-access: create a share and download a file from it
1238+ - d/t/cifs-share-access: access a file in a share using cifs
1239+ * Ask the user if we can run testparm against the config file. If yes,
1240+ include its stderr and exit status in the bug report. Otherwise, only
1241+ include the exit status. (LP: #1694334)
1242+ * If systemctl is available, use it to query the status of the smbd
1243+ service before trying to reload it. Otherwise, keep the same check
1244+ as before and reload the service based on the existence of the
1245+ initscript. (LP: #1579597)
1246+ * Remove d/p/fix-1584485.patch as it builds a broken pam_winbind
1247+ module. There is a fixed version of that patch attached to
1248+ #1677329 but it has not been vetted yet, so for now it's best
1249+ to revert (again) so that pam_winbind can be used.
1250+ (LP: #1677329, LP: #1644428)
1251+
1252+ -- Andreas Hasenack <andreas@canonical.com> Mon, 19 Jun 2017 10:49:29 -0700
1253+
1254+samba (2:4.5.8+dfsg-2ubuntu1) artful; urgency=medium
1255+
1256+ * Merge from Debian unstable. Remaining changes:
1257+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
1258+ - debian/smb.conf;
1259+ + Add "(Samba, Ubuntu)" to server string.
1260+ + Comment out the default [homes] share, and add a comment about
1261+ "valid users = %s" to show users how to restrict access to
1262+ \\server\username to only username.
1263+ - debian/samba-common.config:
1264+ + Do not change priority to high if dhclient3 is installed.
1265+ - Add apport hook:
1266+ + Created debian/source_samba.py.
1267+ + debian/rules, debian/samba-common-bin.install: install hook.
1268+ - d/p/krb_zero_cursor.patch - apply proposed-upstream fix for
1269+ pam_winbind krb5_ccache_type=FILE failure
1270+ - debian/patches/winbind_trusted_domains.patch: make sure domain
1271+ members can talk to trusted domains DCs.
1272+ - d/p/fix-1584485.patch: Make libnss-winbind and libpam-winbind
1273+ to be statically linked
1274+ - d/rules: Compile winbindd/winbindd statically.
1275+ - d/control: add libcephfs-dev as b-d to build vfs_ceph
1276+
1277+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Thu, 15 Jun 2017 14:17:43 -0400
1278+
1279 samba (2:4.5.8+dfsg-2) unstable; urgency=high
1280
1281 * CVE-2017-7494: rpc_server3: Refuse to open pipe names with / inside
1282@@ -923,6 +2098,23 @@ samba (2:4.5.8+dfsg-1) unstable; urgency=high
1283
1284 -- Mathieu Parent <sathieu@debian.org> Sat, 01 Apr 2017 20:39:17 +0200
1285
1286+samba (2:4.5.8+dfsg-0ubuntu1) artful; urgency=medium
1287+
1288+ * SECURITY UPDATE: remote code execution from a writable share
1289+ - debian/patches/CVE-2017-7494.patch: refuse to open pipe names with a
1290+ slash inside in source3/rpc_server/srv_pipe.c.
1291+ - CVE-2017-7494
1292+
1293+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Wed, 24 May 2017 07:39:13 -0400
1294+
1295+samba (2:4.5.8+dfsg-0ubuntu0.17.04.1) zesty-security; urgency=medium
1296+
1297+ * SECURITY UPDATE: Symlink race allows access outside share definition
1298+ - Updated to new upstream release 4.5.8.
1299+ - CVE-2017-2619
1300+
1301+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Fri, 21 Apr 2017 07:33:25 -0400
1302+
1303 samba (2:4.5.6+dfsg-2) unstable; urgency=high
1304
1305 * This is a security release in order to address the following defects:
1306@@ -952,6 +2144,61 @@ samba (2:4.5.5+dfsg-1) unstable; urgency=medium
1307
1308 -- Mathieu Parent <sathieu@debian.org> Sun, 05 Mar 2017 23:21:09 +0100
1309
1310+samba (2:4.5.4+dfsg-1ubuntu2) zesty; urgency=medium
1311+
1312+ * d/control: add libcephfs-dev as b-d to build vfs_ceph
1313+ (LP: #1668940).
1314+
1315+ -- Nishanth Aravamudan <nish.aravamudan@canonical.com> Mon, 06 Mar 2017 11:13:41 -0800
1316+
1317+samba (2:4.5.4+dfsg-1ubuntu1) zesty; urgency=medium
1318+
1319+ * Merge from Debian unstable (LP: #1659707, LP: #1639962). Remaining
1320+ changes:
1321+ + debian/VERSION.patch: Update vendor string to "Ubuntu".
1322+ + debian/smb.conf;
1323+ - Add "(Samba, Ubuntu)" to server string.
1324+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1325+ to show users how to restrict access to \\server\username to only username.
1326+ + debian/samba-common.config:
1327+ - Do not change prioritiy to high if dhclient3 is installed.
1328+ + Add apport hook:
1329+ - Created debian/source_samba.py.
1330+ - debian/rules, debia/samb-common-bin.install: install hook.
1331+ + d/p/krb_zero_cursor.patch - apply proposed-upstream fix for
1332+ pam_winbind krb5_ccache_type=FILE failure (LP #1310919)
1333+ + debian/patches/winbind_trusted_domains.patch: make sure domain members
1334+ can talk to trusted domains DCs.
1335+ [ update patch based upon upstream discussion ]
1336+ + d/p/fix-1584485.patch: Make libnss-winbind and libpam-winbind
1337+ to be statically linked fixes LP #1584485.
1338+ + d/rules: Compile winbindd/winbindd statically.
1339+ * Drop:
1340+ - Delete debian/.gitignore
1341+ [ Previously undocumented ]
1342+ - debian/patches/git_smbclient_cpu.patch:
1343+ + backport upstream patch to fix smbclient users hanging/eating cpu on
1344+ trying to contact a machine which is not there (lp #1572260)
1345+ [ Fixed upstream ]
1346+ - SECURITY UPDATE: remote code execution via heap overflow in NDR parsing
1347+ + debian/patches/CVE-2016-2123.patch: check lengths in
1348+ librpc/ndr/ndr_dnsp.c.
1349+ + CVE-2016-2123
1350+ [ Fixed in Debian ]
1351+ - SECURITY UPDATE: unconditional privilege delegation to Kerberos servers
1352+ + debian/patches/CVE-2016-2125.patch: don't use GSS_C_DELEG_FLAG in
1353+ source4/scripting/bin/nsupdate-gss, source3/librpc/crypto/gse.c,
1354+ source4/auth/gensec/gensec_gssapi.c.
1355+ + CVE-2016-2125
1356+ [ Fixed in Debian ]
1357+ - SECURITY UPDATE: privilege elevation in Kerberos PAC validation
1358+ + debian/patches/CVE-2016-2126.patch: only allow known checksum types
1359+ in auth/kerberos/kerberos_pac.c.
1360+ + CVE-2016-2126
1361+ [ Fixed in Debian ]
1362+
1363+ -- Nishanth Aravamudan <nish.aravamudan@canonical.com> Thu, 26 Jan 2017 17:20:15 -0800
1364+
1365 samba (2:4.5.4+dfsg-1) unstable; urgency=medium
1366
1367 [ Mathieu Parent ]
1368@@ -1079,6 +2326,77 @@ samba (2:4.4.5+dfsg-3) unstable; urgency=medium
1369
1370 -- Mathieu Parent <sathieu@debian.org> Fri, 09 Sep 2016 13:00:54 +0200
1371
1372+samba (2:4.4.5+dfsg-2ubuntu7) zesty; urgency=medium
1373+
1374+ * SECURITY UPDATE: remote code execution via heap overflow in NDR parsing
1375+ - debian/patches/CVE-2016-2123.patch: check lengths in
1376+ librpc/ndr/ndr_dnsp.c.
1377+ - CVE-2016-2123
1378+ * SECURITY UPDATE: unconditional privilege delegation to Kerberos servers
1379+ - debian/patches/CVE-2016-2125.patch: don't use GSS_C_DELEG_FLAG in
1380+ source4/scripting/bin/nsupdate-gss, source3/librpc/crypto/gse.c,
1381+ source4/auth/gensec/gensec_gssapi.c.
1382+ - CVE-2016-2125
1383+ * SECURITY UPDATE: privilege elevation in Kerberos PAC validation
1384+ - debian/patches/CVE-2016-2126.patch: only allow known checksum types
1385+ in auth/kerberos/kerberos_pac.c.
1386+ - CVE-2016-2126
1387+
1388+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Fri, 20 Jan 2017 12:32:25 -0500
1389+
1390+samba (2:4.4.5+dfsg-2ubuntu6) zesty; urgency=high
1391+
1392+ * d/p/fix-1584485.patch: Make libnss-winbind and libpam-winbind
1393+ to be statically linked fixes LP: #1584485.
1394+
1395+ * d/rules: Compile winbindd/winbindd statically.
1396+
1397+ -- Jorge Niedbalski <jorge.niedbalski@canonical.com> Wed, 02 Nov 2016 13:59:10 +0100
1398+
1399+samba (2:4.4.5+dfsg-2ubuntu5) yakkety; urgency=medium
1400+
1401+ * No-change rebuild for readline soname change.
1402+
1403+ -- Matthias Klose <doko@ubuntu.com> Sun, 18 Sep 2016 10:26:52 +0000
1404+
1405+samba (2:4.4.5+dfsg-2ubuntu4) yakkety; urgency=medium
1406+
1407+ * No-change rebuild for readline soname change.
1408+
1409+ -- Matthias Klose <doko@ubuntu.com> Sat, 17 Sep 2016 12:09:21 +0000
1410+
1411+samba (2:4.4.5+dfsg-2ubuntu3) yakkety; urgency=medium
1412+
1413+ * debian/patches/git_smbclient_cpu.patch:
1414+ - backport upstream patch to fix smbclient users hanging/eating cpu on
1415+ trying to contact a machine which is not there (lp: #1572260)
1416+
1417+ -- Sebastien Bacher <seb128@ubuntu.com> Fri, 05 Aug 2016 17:32:43 +0200
1418+
1419+samba (2:4.4.5+dfsg-2ubuntu1) yakkety; urgency=low
1420+
1421+ * Merge from Debian unstable. Remaining changes:
1422+ + debian/VERSION.patch: Update vendor string to "Ubuntu".
1423+ + debian/smb.conf;
1424+ - Add "(Samba, Ubuntu)" to server string.
1425+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1426+ to show users how to restrict access to \\server\username to only username.
1427+ + debian/samba-common.config:
1428+ - Do not change prioritiy to high if dhclient3 is installed.
1429+ + Add apport hook:
1430+ - Created debian/source_samba.py.
1431+ - debian/rules, debia/samb-common-bin.install: install hook.
1432+ + d/p/krb_zero_cursor.patch - apply proposed-upstream fix for
1433+ pam_winbind krb5_ccache_type=FILE failure (LP: #1310919)
1434+ + debian/patches/winbind_trusted_domains.patch: make sure domain members
1435+ can talk to trusted domains DCs.
1436+ * Dropped changes:
1437+ - build-depends on libgnutls-dev instead of libgnutsl28-dev: rename was
1438+ never done in Debian, revert.
1439+ - ufw integration: included in Debian.
1440+
1441+ -- Steve Langasek <steve.langasek@ubuntu.com> Thu, 14 Jul 2016 17:45:46 -0700
1442+
1443 samba (2:4.4.5+dfsg-2) unstable; urgency=medium
1444
1445 * Disable running of 'make quicktest' during build, as it takes very
1446@@ -1206,6 +2524,20 @@ samba (2:4.4.0+dfsg-1) experimental; urgency=medium
1447
1448 -- Andrew Bartlett <abartlet+debian@catalyst.net.nz> Wed, 06 Apr 2016 17:08:20 +1200
1449
1450+samba (2:4.3.9+dfsg-0ubuntu1) yakkety; urgency=medium
1451+
1452+ * SECURITY REGRESSION: Updated to 4.3.9 to fix multiple regressions in
1453+ the previous security updates. (LP: #1577739)
1454+ - debian/control: bump tevent Build-Depends to 0.9.28.
1455+ * SECURITY REGRESSION: NTLM authentication issues (LP: #1578576)
1456+ - debian/patches/samba-bug11912.patch: let msrpc_parse() return
1457+ talloc'ed empty strings in libcli/auth/msrpc_parse.c.
1458+ - debian/patches/samba-bug11914.patch: make
1459+ ntlm_auth_generate_session_info() more complete in
1460+ source3/utils/ntlm_auth.c.
1461+
1462+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Wed, 25 May 2016 09:29:15 -0400
1463+
1464 samba (2:4.3.8+dfsg-1) unstable; urgency=low
1465
1466 [ Jelmer Vernooij ]
1467@@ -1220,6 +2552,25 @@ samba (2:4.3.8+dfsg-1) unstable; urgency=low
1468
1469 -- Jelmer Vernooij <jelmer@debian.org> Sat, 16 Apr 2016 01:18:36 +0000
1470
1471+samba (2:4.3.8+dfsg-0ubuntu1) xenial; urgency=medium
1472+
1473+ * SECURITY UPDATE: Updated to 4.3.8 to fix multiple security issues
1474+ - CVE-2015-5370: Multiple errors in DCE-RPC code
1475+ - CVE-2016-2110: Man in the middle attacks possible with NTLMSSP
1476+ - CVE-2016-2111: NETLOGON Spoofing Vulnerability
1477+ - CVE-2016-2112: The LDAP client and server don't enforce integrity
1478+ protection
1479+ - CVE-2016-2113: Missing TLS certificate validation allows man in the
1480+ middle attacks
1481+ - CVE-2016-2114: "server signing = mandatory" not enforced
1482+ - CVE-2016-2115: SMB client connections for IPC traffic are not
1483+ integrity protected
1484+ - CVE-2016-2118: SAMR and LSA man in the middle attacks possible
1485+ * debian/patches/winbind_trusted_domains.patch: make sure domain members
1486+ can talk to trusted domains DCs.
1487+
1488+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Tue, 12 Apr 2016 07:26:29 -0400
1489+
1490 samba (2:4.3.7+dfsg-1) unstable; urgency=high
1491
1492 * New upstream release.
1493@@ -1262,6 +2613,29 @@ samba (2:4.3.6+dfsg-2) unstable; urgency=low
1494
1495 -- Mathieu Parent <sathieu@debian.org> Thu, 31 Mar 2016 22:26:11 +0200
1496
1497+samba (2:4.3.6+dfsg-1ubuntu1) xenial; urgency=medium
1498+
1499+ * Merge with Debian; remaining changes:
1500+ + debian/VERSION.patch: Update vendor string to "Ubuntu".
1501+ + debian/smb.conf;
1502+ - Add "(Samba, Ubuntu)" to server string.
1503+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1504+ to show users how to restrict access to \\server\username to only username.
1505+ + debian/samba-common.config:
1506+ - Do not change prioritiy to high if dhclient3 is installed.
1507+ + debian/control:
1508+ - Switch build depends from transitional libgnutsl28-dev to libgnutls-dev
1509+ + Add ufw integration:
1510+ - Created debian/samba.ufw.profile:
1511+ - debian/rules, debian/samba.install: install profile
1512+ + Add apport hook:
1513+ - Created debian/source_samba.py.
1514+ - debian/rules, debia/samb-common-bin.install: install hook.
1515+ + d/p/krb_zero_cursor.patch - apply proposed-upstream fix for
1516+ pam_winbind krb5_ccache_type=FILE failure (LP: #1310919)
1517+
1518+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Wed, 09 Mar 2016 08:49:12 -0500
1519+
1520 samba (2:4.3.6+dfsg-1) unstable; urgency=medium
1521
1522 * New upstream release.
1523@@ -1307,6 +2681,42 @@ samba (2:4.3.3+dfsg-2) unstable; urgency=medium
1524
1525 -- Mathieu Parent <sathieu@debian.org> Thu, 04 Feb 2016 13:25:01 +0100
1526
1527+samba (2:4.3.3+dfsg-1ubuntu3) xenial; urgency=medium
1528+
1529+ * No-change rebuild for gnutls transition.
1530+
1531+ -- Matthias Klose <doko@ubuntu.com> Wed, 17 Feb 2016 22:41:43 +0000
1532+
1533+samba (2:4.3.3+dfsg-1ubuntu2) xenial; urgency=medium
1534+
1535+ * Fixes regression introduced by debian/patches/CVE-2015-5252.patch.
1536+ (LP: #1545750)
1537+
1538+ -- Dariusz Gadomski <dariusz.gadomski@canonical.com> Mon, 15 Feb 2016 16:05:12 +0100
1539+
1540+samba (2:4.3.3+dfsg-1ubuntu1) xenial; urgency=medium
1541+
1542+ * Merge with Debian; remaining changes:
1543+ + debian/VERSION.patch: Update vendor string to "Ubuntu".
1544+ + debian/smb.conf;
1545+ - Add "(Samba, Ubuntu)" to server string.
1546+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1547+ to show users how to restrict access to \\server\username to only username.
1548+ + debian/samba-common.config:
1549+ - Do not change prioritiy to high if dhclient3 is installed.
1550+ + debian/control:
1551+ - Switch build depends from transitional libgnutsl28-dev to libgnutls-dev
1552+ + Add ufw integration:
1553+ - Created debian/samba.ufw.profile:
1554+ - debian/rules, debian/samba.install: install profile
1555+ + Add apport hook:
1556+ - Created debian/source_samba.py.
1557+ - debian/rules, debia/samb-common-bin.install: install hook.
1558+ + d/p/krb_zero_cursor.patch - apply proposed-upstream fix for
1559+ pam_winbind krb5_ccache_type=FILE failure (LP: #1310919)
1560+
1561+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Wed, 06 Jan 2016 07:41:39 -0500
1562+
1563 samba (2:4.3.3+dfsg-1) unstable; urgency=medium
1564
1565 * New upstream release. Closes: #808133.
1566@@ -1391,6 +2801,63 @@ samba (2:4.2.1+dfsg-1) experimental; urgency=medium
1567
1568 -- Jelmer Vernooij <jelmer@debian.org> Sun, 07 Dec 2014 15:34:36 +0000
1569
1570+samba (2:4.1.20+dfsg-1ubuntu5) xenial; urgency=medium
1571+
1572+ * Resolve small merge error in the rules
1573+
1574+ -- Sebastien Bacher <seb128@ubuntu.com> Wed, 16 Dec 2015 12:02:12 +0100
1575+
1576+samba (2:4.1.20+dfsg-1ubuntu4) xenial; urgency=medium
1577+
1578+ * Backport Debian change to remove libpam-smbpasswd, it segfaults
1579+ leading to non working session (lp: #1515207)
1580+
1581+ -- Sebastien Bacher <seb128@ubuntu.com> Wed, 16 Dec 2015 11:47:44 +0100
1582+
1583+samba (2:4.1.20+dfsg-1ubuntu3) xenial; urgency=medium
1584+
1585+ * Build with the new ldb
1586+
1587+ -- Sebastien Bacher <seb128@ubuntu.com> Wed, 18 Nov 2015 11:45:32 +0100
1588+
1589+samba (2:4.1.20+dfsg-1ubuntu2) xenial; urgency=medium
1590+
1591+ * debian/samba.logrotate:
1592+ - revert to Debian version of the logrotate reload command, fix an
1593+ invalid syntax introduced in the upstart->systemd transition
1594+ (lp: #1385868)
1595+
1596+ -- Sebastien Bacher <seb128@ubuntu.com> Tue, 10 Nov 2015 19:01:06 +0100
1597+
1598+samba (2:4.1.20+dfsg-1ubuntu1) xenial; urgency=medium
1599+
1600+ * Merge with Debian; remaining changes:
1601+ + debian/VERSION.patch: Update vendor string to "Ubuntu".
1602+ + debian/smb.conf;
1603+ - Add "(Samba, Ubuntu)" to server string.
1604+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1605+ to show users how to restrict access to \\server\username to only username.
1606+ + debian/samba-common.config:
1607+ - Do not change prioritiy to high if dhclient3 is installed.
1608+ + debian/control:
1609+ - Don't build against or suggest ctdb and tdb.
1610+ - Switch build depends from transitional libgnutsl28-dev to libgnutls-dev
1611+ + debian/rules:
1612+ - Drop explicit configuration options for ctdb and tdb.
1613+ + Add ufw integration:
1614+ - Created debian/samba.ufw.profile:
1615+ - debian/rules, debian/samba.install: install profile
1616+ + Add apport hook:
1617+ - Created debian/source_samba.py.
1618+ - debian/rules, debia/samb-common-bin.install: install hook.
1619+ + debian/samba.logrotate: use service command to reload (send SIGHUP) the main
1620+ processes such that it works under both upstart and systemd.
1621+ + debian/samba-common.dirs: Move /var/lib/samba/private from samba.dirs.
1622+ + d/p/krb_zero_cursor.patch - apply proposed-upstream fix for
1623+ pam_winbind krb5_ccache_type=FILE failure (LP: #1310919)
1624+
1625+ -- Matthias Klose <doko@ubuntu.com> Sat, 24 Oct 2015 14:57:47 +0200
1626+
1627 samba (2:4.1.20+dfsg-1) unstable; urgency=medium
1628
1629 * New upstream release (last compatible with current OpenChange).
1630@@ -1404,6 +2871,44 @@ samba (2:4.1.17+dfsg-5) unstable; urgency=medium
1631
1632 -- Jelmer Vernooij <jelmer@debian.org> Sun, 20 Sep 2015 13:20:53 +0000
1633
1634+samba (2:4.1.17+dfsg-4ubuntu2) wily; urgency=medium
1635+
1636+ * debian/control:
1637+ - Switch build depends from transitional libgnutsl28-dev to libgnutls-dev
1638+
1639+ -- Robert Ancell <robert.ancell@canonical.com> Tue, 11 Aug 2015 11:34:50 +1200
1640+
1641+samba (2:4.1.17+dfsg-4ubuntu1) wily; urgency=medium
1642+
1643+ * Merge from Debian unstable. Remaining changes:
1644+ + debian/VERSION.patch: Update vendor string to "Ubuntu".
1645+ + debian/smb.conf;
1646+ - Add "(Samba, Ubuntu)" to server string.
1647+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1648+ to show users how to restrict access to \\server\username to only username.
1649+ + debian/samba-common.config:
1650+ - Do not change prioritiy to high if dhclient3 is installed.
1651+ + debian/control:
1652+ - Don't build against or suggest ctdb and tdb.
1653+ + debian/rules:
1654+ - Drop explicit configuration options for ctdb and tdb.
1655+ + Add ufw integration:
1656+ - Created debian/samba.ufw.profile:
1657+ - debian/rules, debian/samba.install: install profile
1658+ + Add apport hook:
1659+ - Created debian/source_samba.py.
1660+ - debian/rules, debia/samb-common-bin.install: install hook.
1661+ + debian/samba.logrotate: use service command to reload (send SIGHUP) the main
1662+ processes such that it works under both upstart and systemd.
1663+ + debian/samba-common.dirs: Move /var/lib/samba/private from samba.dirs.
1664+ + d/p/krb_zero_cursor.patch - apply proposed-upstream fix for
1665+ pam_winbind krb5_ccache_type=FILE failure (LP: #1310919)
1666+ + debian/patches/git_timeout_client_error.patch:
1667+ - don't let smb mounts timeout that leads to errors when trying to
1668+ reuse a mount after idling for a while in e.g nautilus (lp: #310932)
1669+
1670+ -- Martin Pitt <martin.pitt@ubuntu.com> Fri, 08 May 2015 10:49:12 +0200
1671+
1672 samba (2:4.1.17+dfsg-4) unstable; urgency=medium
1673
1674 * Add pidl_reproducible.patch: Make pidl output reproducible.
1675@@ -1440,6 +2945,53 @@ samba (2:4.1.17+dfsg-1) unstable; urgency=high
1676
1677 -- Ivo De Decker <ivodd@debian.org> Mon, 23 Feb 2015 20:20:21 +0100
1678
1679+samba (2:4.1.13+dfsg-4ubuntu3) vivid; urgency=medium
1680+
1681+ * debian/patches/git_timeout_client_error.patch:
1682+ - don't let smb mounts timeout that leads to errors when trying to
1683+ reuse a mount after idling for a while in e.g nautilus (lp: #310932)
1684+
1685+ -- Sebastien Bacher <seb128@ubuntu.com> Fri, 03 Apr 2015 17:20:06 +0200
1686+
1687+samba (2:4.1.13+dfsg-4ubuntu2) vivid; urgency=medium
1688+
1689+ * SECURITY UPDATE: code execution vulnerability in smbd daemon
1690+ - debian/patches/CVE-2015-0240.patch: don't call talloc_free on an
1691+ uninitialized pointer and don't dereference a NULL pointer in
1692+ source3/rpc_server/netlogon/srv_netlog_nt.c.
1693+ - CVE-2015-0240
1694+
1695+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Mon, 23 Feb 2015 08:36:51 -0500
1696+
1697+samba (2:4.1.13+dfsg-4ubuntu1) vivid; urgency=low
1698+
1699+ * Merge from Debian unstable. Remaining changes:
1700+ + debian/VERSION.patch: Update vendor string to "Ubuntu".
1701+ + debian/smb.conf;
1702+ - Add "(Samba, Ubuntu)" to server string.
1703+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1704+ to show users how to restrict access to \\server\username to only username.
1705+ + debian/samba-common.config:
1706+ - Do not change prioritiy to high if dhclient3 is installed.
1707+ + debian/control:
1708+ - Don't build against or suggest ctdb and tdb.
1709+ + debian/rules:
1710+ - Drop explicit configuration options for ctdb and tdb.
1711+ + Add ufw integration:
1712+ - Created debian/samba.ufw.profile:
1713+ - debian/rules, debian/samba.install: install profile
1714+ + Add apport hook:
1715+ - Created debian/source_samba.py.
1716+ - debian/rules, debia/samb-common-bin.install: install hook.
1717+ + debian/samba.logrotate: use service command to reload (send SIGHUP) the main
1718+ processes such that it works under both upstart and systemd.
1719+ + debian/samba-common.dirs: Move /var/lib/samba/private from samba.dirs.
1720+ + d/p/krb_zero_cursor.patch - apply proposed-upstream fix for
1721+ pam_winbind krb5_ccache_type=FILE failure (LP: #1310919)
1722+ + debian/patches/CVE-2014-8143.patch fix CVE-2014-8143.
1723+
1724+ -- Gianfranco Costamagna <costamagnagianfranco@yahoo.it> Wed, 21 Jan 2015 15:48:05 +0100
1725+
1726 samba (2:4.1.13+dfsg-4) unstable; urgency=medium
1727
1728 * Revert previous patch, since ldb has an active module version check.
1729@@ -1482,6 +3034,69 @@ samba (2:4.1.11+dfsg-2) unstable; urgency=medium
1730
1731 -- Jelmer Vernooij <jelmer@debian.org> Sun, 07 Sep 2014 20:52:27 +0200
1732
1733+samba (2:4.1.11+dfsg-1ubuntu4) vivid; urgency=medium
1734+
1735+ * SECURITY UPDATE: elevation of privilege to AD Domain Controller
1736+ - debian/patches/CVE-2014-8143.patch: check for extended access rights
1737+ before allowing changes to userAccountControl in
1738+ librpc/idl/security.idl, source4/auth/session.c,
1739+ source4/dsdb/common/util.c, source4/dsdb/pydsdb.c,
1740+ source4/dsdb/samdb/ldb_modules/samldb.c, source4/dsdb/samdb/samdb.h,
1741+ source4/rpc_server/lsa/dcesrv_lsa.c,
1742+ source4/setup/schema_samba4.ldif.
1743+ - CVE-2014-8143
1744+
1745+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Wed, 21 Jan 2015 09:19:12 -0500
1746+
1747+samba (2:4.1.11+dfsg-1ubuntu3) vivid; urgency=medium
1748+
1749+ * No-change rebuild against current ldb. Note that I'm not claiming the
1750+ merging for this package.
1751+
1752+ -- Martin Pitt <martin.pitt@ubuntu.com> Thu, 04 Dec 2014 07:50:22 +0100
1753+
1754+samba (2:4.1.11+dfsg-1ubuntu2) utopic; urgency=medium
1755+
1756+ * d/p/krb_zero_cursor.patch - apply proposed-upstream fix for
1757+ pam_winbind krb5_ccache_type=FILE failure (LP: #1310919)
1758+
1759+ -- Serge Hallyn <serge.hallyn@ubuntu.com> Thu, 11 Sep 2014 11:53:36 -0500
1760+
1761+samba (2:4.1.11+dfsg-1ubuntu1) utopic; urgency=medium
1762+
1763+ * Merge from Debian unstable. Remaining changes:
1764+ + debian/VERSION.patch: Update vendor string to "Ubuntu".
1765+ + debian/smb.conf;
1766+ - Add "(Samba, Ubuntu)" to server string.
1767+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1768+ to show users how to restrict access to \\server\username to only username.
1769+ + debian/samba-common.config:
1770+ - Do not change prioritiy to high if dhclient3 is installed.
1771+ + debian/control:
1772+ - Don't build against or suggest ctdb and tdb.
1773+ + debian/rules:
1774+ - Drop explicit configuration options for ctdb and tdb.
1775+ + Add ufw integration:
1776+ - Created debian/samba.ufw.profile:
1777+ - debian/rules, debian/samba.install: install profile
1778+ + Add apport hook:
1779+ - Created debian/source_samba.py.
1780+ - debian/rules, debia/samb-common-bin.install: install hook.
1781+ + debian/samba.logrotate: call upstart interfaces unconditionally instead
1782+ of hacking arround with pid files.
1783+ + Set sbmclients conflicts with samba4-clients less than 4.0.3+dfsg1-0.1ubuntu4,
1784+ first dummy transitional package version.
1785+ + debian/samba-common.dirs: Move /var/lib/samba/private from samba.dirs.
1786+
1787+ * In logrotate, use service command to reload (send SIGHUP) the main
1788+ processes such that it works under both upstart and systemd.
1789+ * Drop CVE patches, applied upstream.
1790+ * Drop patches absent from series: readline-ftbfs.patch,
1791+ krb5_kt_start_seq.diff, config-bind99.patch
1792+ * Drop debian/source/include-binaries, pyc files are correctly cleaned up
1793+
1794+ -- Dimitri John Ledkov <xnox@ubuntu.com> Sat, 09 Aug 2014 21:26:23 +0100
1795+
1796 samba (2:4.1.11+dfsg-1) unstable; urgency=high
1797
1798 * New upstream release. Fixes:
1799@@ -1517,6 +3132,62 @@ samba (2:4.1.9+dfsg-1) unstable; urgency=high
1800
1801 -- Ivo De Decker <ivo.dedecker@ugent.be> Mon, 23 Jun 2014 18:33:27 +0200
1802
1803+samba (2:4.1.8+dfsg-1ubuntu3) utopic; urgency=medium
1804+
1805+ * SECURITY UPDATE: remote code execution on unauthenticated nmbd
1806+ - debian/patches/CVE-2014-3560.patch: fix unstrcpy in
1807+ lib/util/string_wrappers.h.
1808+ - CVE-2014-3560
1809+
1810+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Fri, 01 Aug 2014 17:54:54 -0400
1811+
1812+samba (2:4.1.8+dfsg-1ubuntu2) utopic; urgency=medium
1813+
1814+ * SECURITY UPDATE: denial of service on nmbd malformed packet
1815+ - debian/patches/CVE-2014-0244.patch: return on EWOULDBLOCK/EAGAIN in
1816+ source3/lib/system.c.
1817+ - CVE-2014-0244
1818+ * SECURITY UPDATE: denial of service via bad unicode conversion
1819+ - debian/patches/CVE-2014-3493.patch: refactor code in
1820+ source3/lib/charcnv.c, change return code checks in
1821+ source3/libsmb/clirap.c, source3/smbd/lanman.c.
1822+ - CVE-2014-3493
1823+
1824+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Mon, 23 Jun 2014 14:10:12 -0400
1825+
1826+samba (2:4.1.8+dfsg-1ubuntu1) utopic; urgency=low
1827+
1828+ * Merge from Debian unstable. Remaining changes:
1829+ + debian/VERSION.patch: Update vendor string to "Ubuntu".
1830+ + debian/smb.conf;
1831+ - Add "(Samba, Ubuntu)" to server string.
1832+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1833+ to show users how to restrict access to \\server\username to only username.
1834+ + debian/samba-common.config:
1835+ - Do not change prioritiy to high if dhclient3 is installed.
1836+ + debian/control:
1837+ - Don't build against or suggest ctdb and tdb.
1838+ + debian/rules:
1839+ - Drop explicit configuration options for ctdb and tdb.
1840+ + Add ufw integration:
1841+ - Created debian/samba.ufw.profile:
1842+ - debian/rules, debian/samba.install: install profile
1843+ + Add apport hook:
1844+ - Created debian/source_samba.py.
1845+ - debian/rules, debia/samb-common-bin.install: install hook.
1846+ + debian/samba.logrotate: call upstart interfaces unconditionally instead
1847+ of hacking arround with pid files.
1848+ + Set sbmclients conflicts with samba4-clients less than 4.0.3+dfsg1-0.1ubuntu4,
1849+ first dummy transitional package version.
1850+ + Dropped patches:
1851+ - debian/patches/CVE-2013-4496.patch: Dropped no longer needed
1852+ - debian/patches/CVE-2013-6442.patch: Dropped no longer needed.
1853+ - debian/patches/readline-ftbfs.patch: Use the debian version.
1854+ + debian/samba-common.dirs: Move /var/lib/samba/private from samba.dirs.
1855+ (LP: #1268180)
1856+
1857+ -- Chuck Short <zulcss@ubuntu.com> Wed, 18 Jun 2014 10:50:25 -0400
1858+
1859 samba (2:4.1.8+dfsg-1) unstable; urgency=medium
1860
1861 [ Jelmer Vernooij ]
1862@@ -1554,6 +3225,74 @@ samba (2:4.1.7+dfsg-1) unstable; urgency=medium
1863
1864 -- Ivo De Decker <ivo.dedecker@ugent.be> Sat, 19 Apr 2014 13:39:09 +0200
1865
1866+samba (2:4.1.6+dfsg-1ubuntu6) utopic; urgency=medium
1867+
1868+ * Set the stack size to unlimited during the build to avoid a SIGBUS in
1869+ xsltproc on some architectures.
1870+
1871+ -- Colin Watson <cjwatson@ubuntu.com> Mon, 02 Jun 2014 23:18:40 +0100
1872+
1873+samba (2:4.1.6+dfsg-1ubuntu5) utopic; urgency=medium
1874+
1875+ * Backport from unstable (Ivo De Decker):
1876+ - Build-depend on heimdal-dev.
1877+
1878+ -- Colin Watson <cjwatson@ubuntu.com> Mon, 02 Jun 2014 15:39:54 +0100
1879+
1880+samba (2:4.1.6+dfsg-1ubuntu4) utopic; urgency=high
1881+
1882+ * No change rebuild against new dh_installinit, to call update-rc.d at
1883+ postinst.
1884+
1885+ -- Dimitri John Ledkov <xnox@ubuntu.com> Wed, 28 May 2014 10:41:32 +0100
1886+
1887+samba (2:4.1.6+dfsg-1ubuntu3) utopic; urgency=medium
1888+
1889+ * cherrypick upstream patch 1310919 to fix pam_winbind regression
1890+ (LP: #1310919)
1891+
1892+ -- Serge Hallyn <serge.hallyn@ubuntu.com> Tue, 29 Apr 2014 16:05:44 -0500
1893+
1894+samba (2:4.1.6+dfsg-1ubuntu2) trusty; urgency=medium
1895+
1896+ * Fix a grammatical error in smb.conf that showed up in a ucf prompt on
1897+ upgrade.
1898+
1899+ -- Steve Langasek <steve.langasek@ubuntu.com> Thu, 03 Apr 2014 19:08:03 -0700
1900+
1901+samba (2:4.1.6+dfsg-1ubuntu1) trusty; urgency=low
1902+
1903+ * Merge from Debian unstable. Remaining changes:
1904+ + debian/VERSION.patch: Update vendor string to "Ubuntu".
1905+ + debian/smb.conf;
1906+ - Add "(Samba, Ubuntu)" to server string.
1907+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1908+ to show users how to restrict access to \\server\username to only username.
1909+ + debian/samba-common.config:
1910+ - Do not change prioritiy to high if dhclient3 is installed.
1911+ + debian/control:
1912+ - Don't build against or suggest ctdb and tdb.
1913+ + debian/rules:
1914+ - Drop explicit configuration options for ctdb and tdb.
1915+ + Add ufw integration:
1916+ - Created debian/samba.ufw.profile:
1917+ - debian/rules, debian/samba.install: install profile
1918+ + Add apport hook:
1919+ - Created debian/source_samba.py.
1920+ - debian/rules, debia/samb-common-bin.install: install hook.
1921+ + debian/samba.logrotate: call upstart interfaces unconditionally instead
1922+ of hacking arround with pid files.
1923+ + Set sbmclients conflicts with samba4-clients less than 4.0.3+dfsg1-0.1ubuntu4,
1924+ first dummy transitional package version.
1925+ + Dropped patches:
1926+ - debian/patches/CVE-2013-4496.patch: Dropped no longer needed
1927+ - debian/patches/CVE-2013-6442.patch: Dropped no longer needed.
1928+ - debian/patches/readline-ftbfs.patch: Use the debian version.
1929+ + debian/samba-common.dirs: Move /var/lib/samba/private from samba.dirs.
1930+ (LP: #1268180)
1931+
1932+ -- Chuck Short <zulcss@ubuntu.com> Wed, 02 Apr 2014 13:40:30 -0400
1933+
1934 samba (2:4.1.6+dfsg-1) unstable; urgency=high
1935
1936 * New upstream security release. Fixes:
1937@@ -1613,6 +3352,77 @@ samba (2:4.1.4+dfsg-1) unstable; urgency=medium
1938
1939 -- Ivo De Decker <ivo.dedecker@ugent.be> Sat, 18 Jan 2014 14:07:15 +0100
1940
1941+samba (2:4.1.3+dfsg-2ubuntu5) trusty; urgency=medium
1942+
1943+ * debian/smb.conf: comment back some of the "share definitions"
1944+ options (including "valid users"). That was an Ubuntu diff and seems to
1945+ have been dropped in the trusty merge. Those changes seem needed to
1946+ get the usershare feature working (used by nautilus-share) (lp: #1261873)
1947+
1948+ -- Sebastien Bacher <seb128@ubuntu.com> Tue, 01 Apr 2014 16:01:04 +0200
1949+
1950+samba (2:4.1.3+dfsg-2ubuntu4) trusty; urgency=medium
1951+
1952+ * SECURITY UPDATE: Password lockout not enforced for SAMR password
1953+ changes
1954+ - debian/patches/CVE-2013-4496.patch: refactor password lockout code in
1955+ source3/auth/check_samsec.c,
1956+ source3/rpc_server/samr/srv_samr_chgpasswd.c,
1957+ source3/rpc_server/samr/srv_samr_nt.c,
1958+ source3/smbd/lanman.c,
1959+ source4/rpc_server/samr/samr_password.c,
1960+ source4/torture/rpc/samr.c.
1961+ - CVE-2013-4496
1962+ * SECURITY UPDATE: smbcacls can remove a file or directory ACL by
1963+ mistake
1964+ - debian/patches/CVE-2013-6442.patch: handle existing ACL in
1965+ source3/utils/smbcacls.c.
1966+ - CVE-2013-6442
1967+ * debian/patches/readline-ftbfs.patch: fix ftbfs with newer readline6.
1968+
1969+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Mon, 17 Mar 2014 08:32:30 -0400
1970+
1971+samba (2:4.1.3+dfsg-2ubuntu3) trusty; urgency=medium
1972+
1973+ * Depend on tdb-tools (LP: #1279593)
1974+ * Updated generated config for Bind9.9.
1975+
1976+ -- Stéphane Graber <stgraber@ubuntu.com> Wed, 12 Feb 2014 21:26:00 -0500
1977+
1978+samba (2:4.1.3+dfsg-2ubuntu2) trusty; urgency=medium
1979+
1980+ * Add missing python-ntdb dependency to python-samba (spotted by
1981+ autopkgtest).
1982+
1983+ -- Martin Pitt <martin.pitt@ubuntu.com> Mon, 10 Feb 2014 09:53:01 +0100
1984+
1985+samba (2:4.1.3+dfsg-2ubuntu1) trusty; urgency=low
1986+
1987+ * Merge from Debian Unstable:
1988+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
1989+ * debian/smb.conf;
1990+ - Add "(Samba, Ubuntu)" to server string.
1991+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
1992+ to show users how to restrict access to \\server\username to only username.
1993+ + debian/samba-common.config:
1994+ - Do not change prioritiy to high if dhclient3 is installed.
1995+ + debian/control:
1996+ - Don't build against or suggest ctdb and tdb.
1997+ + debian/rules:
1998+ - Drop explicit configuration options for ctdb and tdb.
1999+ + Add ufw integration:
2000+ - Created debian/samba.ufw.profile:
2001+ - debian/rules, debian/samba.install: install profile
2002+ + Add apport hook:
2003+ - Created debian/source_samba.py.
2004+ - debian/rules, debia/samb-common-bin.install: install hook.
2005+ + debian/samba.logrotate: call upstart interfaces unconditionally instead
2006+ of hacking arround with pid files.
2007+ + Set sbmclients conflicts with samba4-clients less than 4.0.3+dfsg1-0.1ubuntu4,
2008+ first dummy transitional package version.
2009+
2010+ -- Chuck Short <zulcss@ubuntu.com> Mon, 13 Jan 2014 08:52:31 -0500
2011+
2012 samba (2:4.1.3+dfsg-2) unstable; urgency=medium
2013
2014 * Add debug symbols for all binaries to samba-dbg. Closes: #732493
2015@@ -1655,6 +3465,33 @@ samba (2:4.0.13+dfsg-2) UNRELEASED; urgency=low
2016
2017 -- Steve Langasek <vorlon@debian.org> Mon, 09 Dec 2013 11:13:59 -0800
2018
2019+samba (2:4.0.13+dfsg-1ubuntu1) trusty; urgency=low
2020+
2021+ * Merge from Debian Unstable:
2022+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
2023+ * debian/smb.conf;
2024+ - Add "(Samba, Ubuntu)" to server string.
2025+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
2026+ to show users how to restrict access to \\server\username to only username.
2027+ + debian/samba-common.config:
2028+ - Do not change prioritiy to high if dhclient3 is installed.
2029+ + debian/control:
2030+ - Don't build against or suggest ctdb and tdb.
2031+ + debian/rules:
2032+ - Drop explicit configuration options for ctdb and tdb.
2033+ + Add ufw integration:
2034+ - Created debian/samba.ufw.profile:
2035+ - debian/rules, debian/samba.install: install profile
2036+ + Add apport hook:
2037+ - Created debian/source_samba.py.
2038+ - debian/rules, debia/samb-common-bin.install: install hook.
2039+ + debian/samba.logrotate: call upstart interfaces unconditionally instead
2040+ of hacking arround with pid files.
2041+ + Set sbmclients conflicts with samba4-clients less than 4.0.3+dfsg1-0.1ubuntu4,
2042+ first dummy transitional package version.
2043+
2044+ -- Chuck Short <zulcss@ubuntu.com> Wed, 11 Dec 2013 19:55:47 -0500
2045+
2046 samba (2:4.0.13+dfsg-1) unstable; urgency=high
2047
2048 [ Steve Langasek ]
2049@@ -1709,6 +3546,37 @@ samba (2:4.0.11+dfsg-1) unstable; urgency=high
2050
2051 -- Ivo De Decker <ivo.dedecker@ugent.be> Mon, 11 Nov 2013 15:42:40 +0100
2052
2053+samba (2:4.0.10+dfsg-4ubuntu2) trusty; urgency=low
2054+
2055+ * Set sbmclients conflicts with samba4-clients less than 4.0.3+dfsg1-0.1ubuntu4, first dummy transitional package version.
2056+
2057+ -- Dmitrijs Ledkovs <xnox@ubuntu.com> Wed, 27 Nov 2013 21:50:43 +0000
2058+
2059+samba (2:4.0.10+dfsg-4ubuntu1) trusty; urgency=low
2060+
2061+ * Merge from Debian Unstable:
2062+ - debian/VERSION.patch: Update vendor string to "Ubuntu".
2063+ * debian/smb.conf;
2064+ - Add "(Samba, Ubuntu)" to server string.
2065+ - Comment out the default [homes] share, and add a comment about "valid users = %s"
2066+ to show users how to restrict access to \\server\username to only username.
2067+ + debian/samba-common.config:
2068+ - Do not change prioritiy to high if dhclient3 is installed.
2069+ + debian/control:
2070+ - Don't build against or suggest ctdb and tdb.
2071+ + debian/rules:
2072+ - Drop explicit configuration options for ctdb and tdb.
2073+ + Add ufw integration:
2074+ - Created debian/samba.ufw.profile:
2075+ - debian/rules, debian/samba.install: install profile
2076+ + Add apport hook:
2077+ - Created debian/source_samba.py.
2078+ - debian/rules, debia/samb-common-bin.install: install hook.
2079+ + debian/samba.logrotate: call upstart interfaces unconditionally instead
2080+ of hacking arround with pid files.
2081+
2082+ -- Chuck Short <zulcss@ubuntu.com> Fri, 08 Nov 2013 13:47:46 +0800
2083+
2084 samba (2:4.0.10+dfsg-4) unstable; urgency=low
2085
2086 [ Christian Perrier ]
2087diff --git a/debian/control b/debian/control
2088index b27e7f0..3941757 100644
2089--- a/debian/control
2090+++ b/debian/control
2091@@ -1,7 +1,8 @@
2092 Source: samba
2093 Section: net
2094 Priority: optional
2095-Maintainer: Debian Samba Maintainers <pkg-samba-maint@lists.alioth.debian.org>
2096+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
2097+XSBC-Original-Maintainer: Debian Samba Maintainers <pkg-samba-maint@lists.alioth.debian.org>
2098 Uploaders: Steve Langasek <vorlon@debian.org>,
2099 Jelmer Vernooij <jelmer@debian.org>,
2100 Mathieu Parent <sathieu@debian.org>,
2101@@ -22,12 +23,11 @@ Build-Depends: bison,
2102 libblkid-dev,
2103 libbsd-dev,
2104 libcap-dev [linux-any],
2105- libcephfs-dev [amd64 arm64 armel armhf i386 mips64el mipsel ppc64el ppc64 s390x x32],
2106+ libcephfs-dev [amd64 arm64 armel armhf mips64el mipsel ppc64el ppc64 s390x x32],
2107 libcmocka-dev (>= 1.1.3),
2108 libcups2-dev,
2109 libdbus-1-dev,
2110- libglusterfs-dev [linux-any],
2111- libgnutls28-dev,
2112+ libgnutls28-dev (>= 3.6.5),
2113 libgpgme11-dev,
2114 libicu-dev,
2115 libjansson-dev,
2116@@ -38,7 +38,7 @@ Build-Depends: bison,
2117 libparse-yapp-perl,
2118 libpcap-dev [hurd-i386 kfreebsd-any],
2119 libpopt-dev,
2120- librados-dev [amd64 arm64 armel armhf i386 mips64el mipsel ppc64el ppc64 s390x x32],
2121+ librados-dev [amd64 arm64 armel armhf mips64el mipsel ppc64el ppc64 s390x x32],
2122 libreadline-dev,
2123 libsystemd-dev [linux-any],
2124 libtalloc-dev (>= 2.3.1~),
2125@@ -46,6 +46,7 @@ Build-Depends: bison,
2126 libtasn1-bin,
2127 libtdb-dev (>= 1.4.3~),
2128 libtevent-dev (>= 0.10.2~),
2129+ liburing-dev [!i386],
2130 perl,
2131 pkg-config,
2132 po-debconf,
2133@@ -287,7 +288,7 @@ Multi-Arch: same
2134 Breaks: samba (<< 2:4.3.2+dfsg-1), samba-libs (<< 2:4.3.2+dfsg-1)
2135 Replaces: samba (<< 2:4.3.2+dfsg-1), samba-libs (<< 2:4.3.2+dfsg-1)
2136 Depends: samba-libs (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends}
2137-Recommends: ${vfsceph:Recommends}, ${vfsglusterfs:Recommends}, ${vfssnapper:Recommends}
2138+Recommends: ${vfsceph:Recommends}, ${vfssnapper:Recommends}
2139 Enhances: samba
2140 Description: Samba Virtual FileSystem plugins
2141 Samba is an implementation of the SMB/CIFS protocol for Unix systems,
2142@@ -304,8 +305,8 @@ Description: Samba Virtual FileSystem plugins
2143 * vfs_shadow_copy2: Expose snapshots to Windows clients as shadow copies
2144 * vfs_worm: Disallow writes for older file
2145 .
2146- Note: The runtime dependencies of vfs_ceph, vfs_glusterfs and vfs_snapper are
2147- moved to Recommends.
2148+ Note: The runtime dependencies of vfs_ceph and vfs_snapper are moved to
2149+ Recommends.
2150
2151 Package: libsmbclient
2152 Section: libs
2153diff --git a/debian/patches/VERSION.patch b/debian/patches/VERSION.patch
2154index d50c4c9..b92d155 100644
2155--- a/debian/patches/VERSION.patch
2156+++ b/debian/patches/VERSION.patch
2157@@ -1,5 +1,5 @@
2158 From: Eloy A. Paris <peloy@debian.org>
2159-Subject: Add "Debian" as vendor suffix
2160+Subject: Add "Ubuntu" as vendor suffix
2161
2162 Forwarded: not-needed
2163 ---
2164@@ -15,5 +15,5 @@ index d91963a..2650887 100644
2165 # #
2166 ########################################################
2167 -SAMBA_VERSION_VENDOR_SUFFIX=
2168-+SAMBA_VERSION_VENDOR_SUFFIX=Debian
2169++SAMBA_VERSION_VENDOR_SUFFIX=Ubuntu
2170 SAMBA_VERSION_VENDOR_PATCH=
2171diff --git a/debian/patches/ctdb-config-enable-syslog-by-default.patch b/debian/patches/ctdb-config-enable-syslog-by-default.patch
2172new file mode 100644
2173index 0000000..3e96c5a
2174--- /dev/null
2175+++ b/debian/patches/ctdb-config-enable-syslog-by-default.patch
2176@@ -0,0 +1,49 @@
2177+ctdb-config: enable syslog by default
2178+
2179+CTDB uses /var/log/ctdb/ directory for the default log files. With
2180+syslog disabled, systemd journal is not able to correctly inform
2181+errors happening during service initialization.
2182+
2183+Upstream community creates generic config files to be used by different
2184+distributions, so this change makes no big difference to be accepted by
2185+upstream.
2186+
2187+With this patch the end user will be able to identify initialization
2188+errors by executing:
2189+
2190+ systemctl status ctdb.service
2191+
2192+or to follow ctdb logs by executing:
2193+
2194+ journalctl -f -u ctdb
2195+
2196+Signed-off-by: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
2197+-
2198+Author: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
2199+Bug-Debian: https://bugs.debian.org/929931
2200+Bug-Ubuntu: https://bugs.launchpad.net/bugs/722201
2201+Last-Update: 2018-06-27
2202+---
2203+ ctdb/config/ctdb.conf | 4 ++--
2204+ 1 file changed, 2 insertions(+), 2 deletions(-)
2205+
2206+diff --git a/ctdb/config/ctdb.conf b/ctdb/config/ctdb.conf
2207+index 5440600a4..cde24280e 100644
2208+--- a/ctdb/config/ctdb.conf
2209++++ b/ctdb/config/ctdb.conf
2210+@@ -5,10 +5,10 @@
2211+
2212+ [logging]
2213+ # Enable logging to syslog
2214+- # location = syslog
2215++ location = syslog
2216+
2217+ # Default log level
2218+- # log level = NOTICE
2219++ log level = NOTICE
2220+
2221+ [cluster]
2222+ # Shared recovery lock file to avoid split brain. Daemon
2223+--
2224+2.20.1
2225+
2226diff --git a/debian/patches/fix-nfs-service-name-to-nfs-kernel-server.patch b/debian/patches/fix-nfs-service-name-to-nfs-kernel-server.patch
2227index 8e6cc83..70afeba 100644
2228--- a/debian/patches/fix-nfs-service-name-to-nfs-kernel-server.patch
2229+++ b/debian/patches/fix-nfs-service-name-to-nfs-kernel-server.patch
2230@@ -7,10 +7,10 @@ distribution. This patch fixes the names for Debian and derivatives.
2231 Bug-Debian: https://bugs.debian.org/929931
2232 Bug-Ubuntu: https://bugs.launchpad.net/bugs/722201
2233 Last-Update: 2018-08-05
2234-diff --git a/ctdb/config/events/legacy/06.nfs.script b/ctdb/config/events/legacy/06.nfs.script
2235-index 97086f78ed0..7b7614228a5 100755
2236---- a/ctdb/config/events/legacy/06.nfs.script
2237-+++ b/ctdb/config/events/legacy/06.nfs.script
2238+Index: samba/ctdb/config/events/legacy/06.nfs.script
2239+===================================================================
2240+--- samba.orig/ctdb/config/events/legacy/06.nfs.script 2020-11-24 18:11:53.506104058 -0500
2241++++ samba/ctdb/config/events/legacy/06.nfs.script 2020-11-24 18:11:53.502104093 -0500
2242 @@ -6,7 +6,7 @@
2243
2244 . "${CTDB_BASE}/functions"
2245@@ -20,10 +20,10 @@ index 97086f78ed0..7b7614228a5 100755
2246
2247 load_script_options "service" "60.nfs"
2248
2249-diff --git a/ctdb/config/events/legacy/60.nfs.script b/ctdb/config/events/legacy/60.nfs.script
2250-index 2eb90b421c8..5c6a0903322 100755
2251---- a/ctdb/config/events/legacy/60.nfs.script
2252-+++ b/ctdb/config/events/legacy/60.nfs.script
2253+Index: samba/ctdb/config/events/legacy/60.nfs.script
2254+===================================================================
2255+--- samba.orig/ctdb/config/events/legacy/60.nfs.script 2020-11-24 18:11:53.506104058 -0500
2256++++ samba/ctdb/config/events/legacy/60.nfs.script 2020-11-24 18:11:53.502104093 -0500
2257 @@ -6,9 +6,9 @@
2258
2259 . "${CTDB_BASE}/functions"
2260@@ -36,11 +36,11 @@ index 2eb90b421c8..5c6a0903322 100755
2261
2262 load_script_options
2263
2264-diff --git a/ctdb/config/nfs-linux-kernel-callout b/ctdb/config/nfs-linux-kernel-callout
2265-index 71d8ecf8074..9c698f5ad91 100755
2266---- a/ctdb/config/nfs-linux-kernel-callout
2267-+++ b/ctdb/config/nfs-linux-kernel-callout
2268-@@ -14,7 +14,7 @@ nfs_exports_file="${CTDB_NFS_EXPORTS_FILE:-/var/lib/nfs/etab}"
2269+Index: samba/ctdb/config/nfs-linux-kernel-callout
2270+===================================================================
2271+--- samba.orig/ctdb/config/nfs-linux-kernel-callout 2020-11-24 18:11:53.506104058 -0500
2272++++ samba/ctdb/config/nfs-linux-kernel-callout 2020-11-24 18:11:53.502104093 -0500
2273+@@ -14,7 +14,7 @@
2274
2275 # As above, edit the default value below. CTDB_NFS_DISTRO_STYLE is a
2276 # test variable only.
2277@@ -49,11 +49,31 @@ index 71d8ecf8074..9c698f5ad91 100755
2278
2279 case "$nfs_distro_style" in
2280 systemd-*)
2281-@@ -33,6 +33,7 @@ systemd-*)
2282+@@ -33,6 +33,14 @@
2283 ;;
2284 *-debian)
2285 nfs_rquotad_service="quotarpc"
2286++ nfs_lock_service=""
2287++ nfs_lock_service=""
2288++ nfs_mountd_service=""
2289++ nfs_status_service=""
2290++ nfs_rquotad_service=""
2291++ nfs_service="nfs-kernel-server"
2292 + nfs_config="/etc/default/nfs-kernel-server"
2293++ nfs_rquotad_config="/etc/default/quota"
2294 ;;
2295 *)
2296 echo "Internal error"
2297+Index: samba/ctdb/config/statd-callout
2298+===================================================================
2299+--- samba.orig/ctdb/config/statd-callout 2020-11-24 18:11:53.506104058 -0500
2300++++ samba/ctdb/config/statd-callout 2020-11-24 18:11:53.502104093 -0500
2301+@@ -29,7 +29,7 @@
2302+ }
2303+
2304+ # Try different variables to find config file for NFS_HOSTNAME
2305+-load_system_config "nfs" "nfs-common"
2306++load_system_config "nfs-kernel-server"
2307+
2308+ # If NFS_HOSTNAME not set then try to pull it out of /etc/nfs.conf
2309+ if [ -z "$NFS_HOSTNAME" ] && type nfsconf >/dev/null 2>&1 ; then
2310diff --git a/debian/patches/series b/debian/patches/series
2311index 55e4c0d..7bfe108 100644
2312--- a/debian/patches/series
2313+++ b/debian/patches/series
2314@@ -9,3 +9,4 @@ heimdal-rfc3454.txt
2315 smbd.service-Run-update-apparmor-samba-profile-befor.patch
2316 fix-nfs-service-name-to-nfs-kernel-server.patch
2317 Rename-mdfind-to-mdsearch.patch
2318+ctdb-config-enable-syslog-by-default.patch
2319diff --git a/debian/rules b/debian/rules
2320index 0ce3bea..6400e8b 100755
2321--- a/debian/rules
2322+++ b/debian/rules
2323@@ -14,6 +14,12 @@ DEB_HOST_ARCH_OS ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
2324 DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
2325 DEB_HOST_ARCH_CPU ?= $(shell dpkg-architecture -qDEB_HOST_ARCH_CPU)
2326
2327+# Ubuntu i386 binary compatibility only effort
2328+UBUNTU_I386 = 0
2329+ifeq ($(shell dpkg-vendor --is Ubuntu && echo yes) $(DEB_HOST_ARCH), yes i386)
2330+ UBUNTU_I386 = 1
2331+endif
2332+
2333 LDB_VERSION = $(shell pkg-config --modversion ldb)
2334 LDB_EPOCH = $(shell dpkg-query -f '$${Version}' -W libldb-dev | sed 's/:.*//')
2335 LDB_NEXT_VERSION = $(shell python3 -c "x = '$(LDB_VERSION)'.split('.'); x[-1] = str(int(x[-1])+1); print('.'.join(x))")
2336@@ -74,12 +80,20 @@ conf_args = \
2337 --enable-spotlight
2338
2339
2340+ifeq ($(UBUNTU_I386), 0)
2341 ifneq (,$(filter amd64 arm64 armel armhf i386 mips64el mipsel ppc64el ppc64 s390x x32, $(DEB_HOST_ARCH)))
2342- conf_args += \
2343- --enable-ceph-reclock
2344+ conf_args += \
2345+ --enable-ceph-reclock
2346 else
2347- conf_args += \
2348- --disable-cephfs
2349+ conf_args += \
2350+ --disable-cephfs
2351+endif
2352+endif
2353+
2354+# Ubuntu i386 binary compatibility only effort: Disable ceph support
2355+ifeq ($(UBUNTU_I386), 1)
2356+ conf_args += \
2357+ --disable-cephfs
2358 endif
2359
2360 ifeq ($(DEB_HOST_ARCH_OS), linux)
2361@@ -92,8 +106,17 @@ else
2362 --without-systemd
2363 endif
2364
2365+# Ubuntu i386 binary compatibility only effort: Disable some i386 packages
2366+ifeq ($(UBUNTU_I386), 1)
2367+ BUILD_PACKAGES += \
2368+ -Nctdb \
2369+ -Nlibpam-winbind \
2370+ -Nsamba \
2371+ -Nsamba-testsuite
2372+endif
2373+
2374 %:
2375- dh $* --with python3
2376+ dh $* --with python3 $(BUILD_PACKAGES)
2377
2378 override_dh_auto_configure:
2379 $(WAF_NO_PARALLEL) configure $(conf_args)
2380@@ -264,8 +287,9 @@ override_dh_makeshlibs:
2381
2382 override_dh_shlibdeps:
2383 LD_LIBRARY_PATH=$(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)/samba:$$LD_LIBRARY_PATH \
2384- dh_shlibdeps -a -Xceph.so -Xglusterfs.so -Xsnapper.so -Xctdb_mutex_ceph_rados_helper
2385+ dh_shlibdeps -a -Xceph.so -Xsnapper.so -Xctdb_mutex_ceph_rados_helper
2386 ifneq (,$(filter amd64 arm64 armel armhf i386 mips64el mipsel ppc64el ppc64 s390x x32, $(DEB_HOST_ARCH)))
2387+ifeq ($(UBUNTU_I386), 0)
2388 LD_LIBRARY_PATH=$(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)/samba:$$LD_LIBRARY_PATH \
2389 dh_shlibdeps -a -- -pvfsceph -dRecommends \
2390 -e debian/samba-vfs-modules/usr/lib/*/samba/vfs/ceph.so
2391@@ -273,10 +297,6 @@ ifneq (,$(filter amd64 arm64 armel armhf i386 mips64el mipsel ppc64el ppc64 s390
2392 dh_shlibdeps -a -- -prados -dRecommends \
2393 -e debian/ctdb/usr/lib/*/ctdb/ctdb_mutex_ceph_rados_helper
2394 endif
2395-ifeq ($(DEB_HOST_ARCH_OS), linux)
2396- LD_LIBRARY_PATH=$(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)/samba:$$LD_LIBRARY_PATH \
2397- dh_shlibdeps -a -- -pvfsglusterfs -dRecommends \
2398- -e debian/samba-vfs-modules/usr/lib/*/samba/vfs/glusterfs.so
2399 endif
2400 LD_LIBRARY_PATH=$(DESTDIR)/usr/lib/$(DEB_HOST_MULTIARCH)/samba:$$LD_LIBRARY_PATH \
2401 dh_shlibdeps -a -- -pvfssnapper -dRecommends \
2402diff --git a/debian/samba-common.config b/debian/samba-common.config
2403index e9fc02d..4800015 100644
2404--- a/debian/samba-common.config
2405+++ b/debian/samba-common.config
2406@@ -64,15 +64,15 @@ db_go
2407
2408 DHCPPRIORITY=medium
2409 #if [ "$DEBCONF_RECONFIGURE" = 1 ] && [ -f /sbin/dhclient ]
2410-if [ -f /sbin/dhclient ]
2411-then
2412- DHCPPRIORITY=high
2413+#if [ -f /sbin/dhclient ]
2414+#then
2415+# DHCPPRIORITY=high
2416 # TODO: see if we can detect that dhcp-client is *going* to be installed,
2417 # even if it isn't yet.
2418 #elif dpkg-query -W --showformat='${Status}\n' dhcp-client | grep ???
2419 # unknown ok not-installed ?
2420 # DHCPPRIORITY=high
2421-fi
2422+#fi
2423
2424 FOUND=false
2425 if [ -f $FILE ]; then
2426diff --git a/debian/smb.conf b/debian/smb.conf
2427index 6a184f9..8c38ffa 100644
2428--- a/debian/smb.conf
2429+++ b/debian/smb.conf
2430@@ -28,6 +28,9 @@
2431 # Change this to the workgroup/NT-domain name your Samba server will part of
2432 workgroup = WORKGROUP
2433
2434+# server string is the equivalent of the NT Description field
2435+ server string = %h server (Samba, Ubuntu)
2436+
2437 #### Networking ####
2438
2439 # The specific set of interfaces / networks to bind to
2440@@ -166,28 +169,31 @@
2441
2442 #======================= Share Definitions =======================
2443
2444-[homes]
2445- comment = Home Directories
2446- browseable = no
2447+# Un-comment the following (and tweak the other settings below to suit)
2448+# to enable the default home directory shares. This will share each
2449+# user's home directory as \\server\username
2450+;[homes]
2451+; comment = Home Directories
2452+; browseable = no
2453
2454 # By default, the home directories are exported read-only. Change the
2455 # next parameter to 'no' if you want to be able to write to them.
2456- read only = yes
2457+; read only = yes
2458
2459 # File creation mask is set to 0700 for security reasons. If you want to
2460 # create files with group=rw permissions, set next parameter to 0775.
2461- create mask = 0700
2462+; create mask = 0700
2463
2464 # Directory creation mask is set to 0700 for security reasons. If you want to
2465 # create dirs. with group=rw permissions, set next parameter to 0775.
2466- directory mask = 0700
2467+; directory mask = 0700
2468
2469 # By default, \\server\username shares can be connected to by anyone
2470 # with access to the samba server.
2471-# The following parameter makes sure that only "username" can connect
2472-# to \\server\username
2473+# Un-comment the following parameter to make sure that only "username"
2474+# can connect to \\server\username
2475 # This might need tweaking when using external authentication schemes
2476- valid users = %S
2477+; valid users = %S
2478
2479 # Un-comment the following and create the netlogon directory for Domain Logons
2480 # (you need to configure Samba to act as a domain controller too.)
2481diff --git a/debian/tests/cifs-share-access b/debian/tests/cifs-share-access
2482index acfb70a..47ce01a 100644
2483--- a/debian/tests/cifs-share-access
2484+++ b/debian/tests/cifs-share-access
2485@@ -1,34 +1,23 @@
2486-#!/bin/sh -x
2487+#!/bin/sh
2488
2489-if ! testparm -s 2>&1 | grep -qE "^\[homes\]"; then
2490- echo "Adding [homes] share"
2491- cat >> /etc/samba/smb.conf <<EOFEOF
2492-[homes]
2493- valid users = %S
2494- read only = no
2495- guest ok = no
2496-EOFEOF
2497- systemctl reload smbd.service
2498-else
2499- echo "No need to add [homes] share, continuing."
2500-fi
2501+set -x
2502+set -e
2503+
2504+. debian/tests/util
2505
2506 username="smbtest$$"
2507 password="$$"
2508-echo "Creating a local test user called ${username}"
2509-useradd -m "$username"
2510-echo "Setting samba password for the ${username} user"
2511-echo "${password}\n${password}" | smbpasswd -s -a ${username}
2512-userhome=$(eval echo ~$username)
2513+add_user "${username}" "${password}"
2514+
2515+myshare="myshare$$"
2516+add_share "${myshare}"
2517+
2518 echo "Creating file with random data and computing its md5"
2519-dd if=/dev/urandom bs=1 count=128 2>/dev/null | base64 > ${userhome}/data
2520-chown ${username}:${username} ${userhome}/data
2521-cd ${userhome}
2522-md5sum data > data.md5
2523+populate_share "${myshare}" "${username}"
2524
2525-echo "Mounting //localhost/${username} via CIFS"
2526+echo "Mounting //localhost/${myshare} via CIFS"
2527 temp_mount=$(mktemp -d)
2528-mount -t cifs //localhost/${username} "$temp_mount" -o user=${username},username=${username},password=${password}
2529+mount -t cifs //localhost/"${myshare}" "$temp_mount" -o user="${username}",username="${username}",password="${password}"
2530
2531 echo "Verifying MD5 via cifs"
2532 cd "$temp_mount"
2533diff --git a/debian/tests/cifs-share-access-uring b/debian/tests/cifs-share-access-uring
2534new file mode 100644
2535index 0000000..22253ca
2536--- /dev/null
2537+++ b/debian/tests/cifs-share-access-uring
2538@@ -0,0 +1,41 @@
2539+#!/bin/sh
2540+
2541+set -x
2542+set -e
2543+
2544+. debian/tests/util
2545+
2546+ARCH=$(dpkg --print-architecture)
2547+if [ "$ARCH" = "i386" ]; then
2548+ echo "liburing not available on $ARCH, skipping test"
2549+ exit 77
2550+fi
2551+
2552+k_ver=$(uname -r | cut -d - -f 1)
2553+if ! check_kernel_version ${k_ver}; then
2554+ echo "uring not available in kernel version ${k_ver}, skipping test"
2555+ exit 77
2556+fi
2557+
2558+username="smbtest$$"
2559+password="$$"
2560+add_user "${username}" "${password}"
2561+
2562+myshare="myshare$$"
2563+add_share "${myshare}" io_uring
2564+
2565+echo "Creating file with random data and computing its md5"
2566+populate_share "${myshare}" "${username}"
2567+
2568+echo "Mounting //localhost/${myshare} via CIFS"
2569+temp_mount=$(mktemp -d)
2570+mount -t cifs //localhost/"${myshare}" "$temp_mount" -o user="${username}",username="${username}",password="${password}"
2571+
2572+echo "Verifying MD5 via cifs"
2573+cd "$temp_mount"
2574+md5sum -c data.md5
2575+result=$?
2576+cd -
2577+umount "$temp_mount"
2578+rmdir "$temp_mount"
2579+exit "$result"
2580diff --git a/debian/tests/control b/debian/tests/control
2581index 2ebb31c..3ecb853 100644
2582--- a/debian/tests/control
2583+++ b/debian/tests/control
2584@@ -2,6 +2,10 @@ Tests: cifs-share-access
2585 Depends: samba, coreutils, systemd, cifs-utils, passwd
2586 Restrictions: needs-root, allow-stderr, isolation-machine
2587
2588+Tests: cifs-share-access-uring
2589+Depends: samba, samba-vfs-modules, coreutils, systemd, cifs-utils, passwd
2590+Restrictions: needs-root, allow-stderr, isolation-machine, skippable
2591+
2592 Tests: python-smoke
2593 Depends: python3-samba
2594
2595@@ -16,3 +20,7 @@ Restrictions: needs-root, allow-stderr, isolation-container
2596 Tests: smbclient-share-access
2597 Depends: samba, smbclient, coreutils, systemd, passwd
2598 Restrictions: needs-root, allow-stderr, isolation-container
2599+
2600+Tests: smbclient-share-access-uring
2601+Depends: samba, samba-vfs-modules, smbclient, coreutils, systemd, passwd
2602+Restrictions: needs-root, allow-stderr, isolation-container, skippable
2603diff --git a/debian/tests/smbclient-anonymous-share-list b/debian/tests/smbclient-anonymous-share-list
2604index a503ae7..e71ef27 100644
2605--- a/debian/tests/smbclient-anonymous-share-list
2606+++ b/debian/tests/smbclient-anonymous-share-list
2607@@ -1,3 +1,6 @@
2608-#!/bin/sh -x
2609+#!/bin/sh
2610+
2611+set -x
2612+set -e
2613
2614 smbclient -N -L localhost
2615diff --git a/debian/tests/smbclient-authenticated-share-list b/debian/tests/smbclient-authenticated-share-list
2616index 71f0994..9fcaf43 100644
2617--- a/debian/tests/smbclient-authenticated-share-list
2618+++ b/debian/tests/smbclient-authenticated-share-list
2619@@ -1,17 +1,18 @@
2620-#!/bin/sh -x
2621+#!/bin/sh
2622+
2623+set -x
2624+set -e
2625+
2626+. debian/tests/util
2627
2628 username="smbtest$$"
2629 password="$$"
2630
2631-echo "Creating a local test user called ${username}"
2632-useradd -m "$username"
2633-
2634-echo "Setting samba password for the ${username} user"
2635-echo "${password}\n${password}" | smbpasswd -s -a ${username}
2636+add_user "${username}" "${password}"
2637
2638 echo "Testing with incorrect password: must fail"
2639-smbclient -L localhost -U ${username}%wrongpass && exit 1
2640+smbclient -L localhost -U "${username}"%wrongpass && exit 1
2641
2642 echo "Testing with correct password: must work"
2643-smbclient -L localhost -U ${username}%${password}
2644+smbclient -L localhost -U "${username}"%"${password}"
2645
2646diff --git a/debian/tests/smbclient-share-access b/debian/tests/smbclient-share-access
2647index 22546f3..b124c0c 100644
2648--- a/debian/tests/smbclient-share-access
2649+++ b/debian/tests/smbclient-share-access
2650@@ -1,34 +1,23 @@
2651-#!/bin/sh -x
2652+#!/bin/sh
2653
2654-if ! testparm -s 2>&1 | grep -qE "^\[homes\]"; then
2655- echo "Adding [homes] share"
2656- cat >> /etc/samba/smb.conf <<EOFEOF
2657-[homes]
2658- valid users = %S
2659- read only = no
2660- guest ok = no
2661-EOFEOF
2662- systemctl reload smbd.service
2663-else
2664- echo "No need to add [homes] share, continuing."
2665-fi
2666+set -x
2667+set -e
2668+
2669+. debian/tests/util
2670
2671 username="smbtest$$"
2672 password="$$"
2673-echo "Creating a local test user called ${username}"
2674-useradd -m "$username"
2675-echo "Setting samba password for the ${username} user"
2676-echo "${password}\n${password}" | smbpasswd -s -a ${username}
2677-userhome=$(eval echo ~$username)
2678+add_user "${username}" "${password}"
2679+
2680+myshare="myshare$$"
2681+add_share "${myshare}"
2682+
2683 echo "Creating file with random data and computing its md5"
2684-dd if=/dev/urandom bs=1 count=128 2>/dev/null | base64 > ${userhome}/data
2685-chown ${username}:${username} ${userhome}/data
2686-cd ${userhome}
2687-md5sum data > data.md5
2688+populate_share "${myshare}" "${username}"
2689
2690 rm -f downloaded-data
2691 echo "Downloading file and comparing its md5"
2692-smbclient //localhost/${username} -U ${username}%${password} -c "get data downloaded-data"
2693+smbclient //localhost/"${myshare}" -U "${username}"%"${password}" -c "get data downloaded-data"
2694
2695 mv -f downloaded-data data
2696 md5sum -c data.md5
2697diff --git a/debian/tests/smbclient-share-access-uring b/debian/tests/smbclient-share-access-uring
2698new file mode 100644
2699index 0000000..e7915c3
2700--- /dev/null
2701+++ b/debian/tests/smbclient-share-access-uring
2702@@ -0,0 +1,35 @@
2703+#!/bin/sh
2704+
2705+set -x
2706+set -e
2707+
2708+. debian/tests/util
2709+
2710+ARCH=$(dpkg --print-architecture)
2711+if [ "$ARCH" = "i386" ]; then
2712+ echo "liburing not available on $ARCH, skipping test"
2713+ exit 77
2714+fi
2715+
2716+k_ver=$(uname -r | cut -d - -f 1)
2717+if ! check_kernel_version ${k_ver}; then
2718+ echo "uring not available in kernel version ${k_ver}, skipping test"
2719+ exit 77
2720+fi
2721+
2722+username="smbtest$$"
2723+password="$$"
2724+add_user "${username}" "${password}"
2725+
2726+myshare="myshare$$"
2727+add_share "${myshare}" io_uring
2728+
2729+echo "Creating file with random data and computing its md5"
2730+populate_share "${myshare}" "${username}"
2731+
2732+rm -f downloaded-data
2733+echo "Downloading file and comparing its md5"
2734+smbclient //localhost/"${myshare}" -U "${username}"%"${password}" -c "get data downloaded-data"
2735+
2736+mv -f downloaded-data data
2737+md5sum -c data.md5
2738diff --git a/debian/tests/util b/debian/tests/util
2739new file mode 100644
2740index 0000000..47d58b9
2741--- /dev/null
2742+++ b/debian/tests/util
2743@@ -0,0 +1,65 @@
2744+#!/bin/sh
2745+
2746+# $1: share name
2747+# $2: comma separated list of vfs_objects to use, if any
2748+add_share() {
2749+ local share="$1"
2750+ local vfs="$2"
2751+ if ! testparm -s 2>&1 | grep -E "^\[${share}\]"; then
2752+ echo "Adding [${share}] share"
2753+ cat >> /etc/samba/smb.conf <<EOFEOF
2754+[${share}]
2755+ read only = no
2756+ guest ok = no
2757+ path = /${share}
2758+EOFEOF
2759+ if [ -n "${vfs}" ]; then
2760+ echo "vfs objects = ${vfs}" >> /etc/samba/smb.conf
2761+ fi
2762+ systemctl restart smbd.service
2763+ else
2764+ echo "Share [${share}] already exists, continuing"
2765+ fi
2766+}
2767+
2768+# $1: username
2769+# $2: password
2770+add_user() {
2771+ local username="$1"
2772+ local password="$2"
2773+
2774+ echo "Creating a local and samba user called ${username}"
2775+ useradd -m "${username}"
2776+ echo "Setting samba password for the ${username} user"
2777+ echo "${password}\n${password}" | smbpasswd -s -a ${username}
2778+}
2779+
2780+# $1: share name
2781+populate_share() {
2782+ local sharename="$1"
2783+ local usergroup="$2"
2784+ local sharepath="/${sharename}"
2785+
2786+ mkdir -p "${sharepath}"
2787+ dd if=/dev/urandom bs=4096 count=1000 2>/dev/null | base64 > "${sharepath}/data"
2788+ cd "${sharepath}"
2789+ md5sum data > data.md5
2790+ chown -R "${usergroup}:${usergroup}" "${sharepath}"
2791+}
2792+
2793+
2794+# $1: kernel version in the form major.minor.patch
2795+check_kernel_version() {
2796+ local k_ver=$1
2797+ local k_major=$(echo ${k_ver} | cut -d . -f 1)
2798+ local k_minor=$(echo ${k_ver} | cut -d . -f 2)
2799+
2800+ # uring is supported starting with kernel 5.1.x
2801+ if [ ${k_major} -eq 5 ] && [ ${k_minor} -ge 1 ]; then
2802+ return 0
2803+ elif [ ${k_major} -ge 6 ]; then
2804+ return 0
2805+ else
2806+ return 1
2807+ fi
2808+}

Subscribers

People subscribed via source and target branches