Merge ~sergiodj/ubuntu/+source/node-uid-number:bug1877704-install-get-uid-gid-groovy into ubuntu/+source/node-uid-number:ubuntu/groovy-devel

[Sergio Durigan Junior]

This is a fix for bug 1877704.

It's very simple: the problem is that the package on Focal and Groovy does not install the "get-uid-gid.js" file, which a requirement for it to function properly. node-uid-number is a dependency of npm, which is an important package, and this means that npm will have trouble working.

There's a test plan written in the bug, which I'm pasting here:

Inside a Groovy container:

# apt install npm -y
# npm install yarn -g
# rm .npm/_logs/*.log
# grep get-uid-gid .npm/_logs/*-debug.log
57 verbose stack Error: Cannot find module './get-uid-gid.js'
64 error Cannot find module './get-uid-gid.js'

When testing the fixed package, make sure to delete the logs under .npm/_logs/.

There's a PPA with the proposed change here:

https://launchpad.net/~sergiodj/+archive/ubuntu/node-uid-number-bug1877704

The dep8 tests are still happy:

autopkgtest [12:02:51]: @@@@@@@@@@@@@@@@@@@@ summary
require PASS

[Bryce Harrington (bryce)]

LGTM, +1

Since this looks pretty trivial, I'm skipping all the usual review validation.
The SRU process will already add more than ample review/testing.

review: Approve

[Bryce Harrington (bryce)]

Oh, one suggestion for the SRU text; please mention why the issue doesn't need addressed for hirsute or how it's already fixed (i.e. you're backporting the fix).

(Btw, very good [Regression Potential] section there; note they've renamed this section.)

[Sergio Durigan Junior (sergiodj)]

Thanks, uploaded:

$ git push pkg upload/0.0.6-1ubuntu0.20.10.1
Enumerating objects: 13, done.
Counting objects: 100% (13/13), done.
Delta compression using up to 8 threads
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 1.17 KiB | 600.00 KiB/s, done.
Total 9 (delta 4), reused 0 (delta 0)
To ssh://git.launchpad.net/ubuntu/+source/node-uid-number
 * [new tag] upload/0.0.6-1ubuntu0.20.10.1 -> upload/0.0.6-1ubuntu0.20.10.1

$ dput node-uid-number_0.0.6-1ubuntu0.20.10.1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/node-uid-number/node-uid-number_0.0.6-1ubuntu0.20.10.1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/node-uid-number/node-uid-number_0.0.6-1ubuntu0.20.10.1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading node-uid-number_0.0.6-1ubuntu0.20.10.1.dsc: done.
  Uploading node-uid-number_0.0.6-1ubuntu0.20.10.1.debian.tar.xz: done.
  Uploading node-uid-number_0.0.6-1ubuntu0.20.10.1_source.buildinfo: done.
  Uploading node-uid-number_0.0.6-1ubuntu0.20.10.1_source.changes: done.
Successfully uploaded packages.

[Sergio Durigan Junior (sergiodj)]

I'll expand the SRU template and add the requested info. Thanks, Bryce.

diff --git a/debian/changelog b/debian/changelog
index 6181874..6308341 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+node-uid-number (0.0.6-1ubuntu0.20.10.1) groovy; urgency=medium
+
+  * d/install: Install get-uid-gid.js.  (LP: #1877704)
+
+ -- Sergio Durigan Junior <[e-mail]>  Tue, 23 Feb 2021 10:26:15 -0500
+
 node-uid-number (0.0.6-1) unstable; urgency=medium
 
   * Initial release
diff --git a/debian/install b/debian/install
index 7fc6722..eaf2260 100644
--- a/debian/install
+++ b/debian/install
@@ -1,2 +1,3 @@
 package.json usr/lib/nodejs/uid-number/
 uid-number.js usr/lib/nodejs/uid-number/
+get-uid-gid.js usr/lib/nodejs/uid-number/