Code review comment for ~sergiodj/ubuntu/+source/net-snmp:double-free-bug1877027-groovy

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

First pass:
- please use full urls for the Origin tag in the DEP3 header, it helps a lot to verify what upstream committed and what we are shipping
- it's a bit troublesome that the bulk get command still fails. I'm by far not an snmp expert, but "error in packet" doesn't look like a normal error, but could indicate that something is corrupted, i.e., another bug, maybe a new one, or introduced by these changes. Could you clarify with upstream, file a bug there, something like this?

I also pinged #security, as I think this is a remote DoS that can be triggered by authenticated users.

review: Needs Information

« Back to merge proposal