Merge ~sergiodj/ubuntu/+source/libvpx:fix-ftbfs-gcc-11 into ubuntu/+source/libvpx:ubuntu/devel

[Sergio Durigan Junior]

This MP works around the LTO problems that are causing libvpx to FTBFS with GCC 11.

I made a mistake and added the package to the lto-disabled-list, but libvpx is in main and therefore the problem should be fixed/worked around in the package itself. That's why I'm now filing this MP (after having removed libvpx from lto-disabled-list).

I have verified that this problem is still happening with upstream's git HEAD, so I've filed a report against them here:

https://bugs.chromium.org/p/webm/issues/detail?id=1736

There's a PPA with the proposed change here:

https://launchpad.net/~sergiodj/+archive/ubuntu/ftbfs-impish/+packages

dep8 tests are still happy:

autopkgtest [11:14:57]: @@@@@@@@@@@@@@@@@@@@ summary
encode-testimage PASS

[Lucas Kanashiro (lucaskanashiro)]

Thanks for this MP Sergio, the changes LGTM, +1.

review: Approve

[Sergio Durigan Junior (sergiodj)]

On Monday, August 16 2021, Lucas Kanashiro wrote:

> Thanks for this MP Sergio, the changes LGTM, +1.

Thanks for the review, Lucas. Uploaded:

$ git push pkg upload/1.9.0-1ubuntu1
Enumerating objects: 18, done.
Counting objects: 100% (18/18), done.
Delta compression using up to 8 threads
Compressing objects: 100% (13/13), done.
Writing objects: 100% (13/13), 1.61 KiB | 550.00 KiB/s, done.
Total 13 (delta 9), reused 0 (delta 0)
To ssh://git.launchpad.net/ubuntu/+source/libvpx
 * [new tag] upload/1.9.0-1ubuntu1 -> upload/1.9.0-1ubuntu1

$ dput libvpx_1.9.0-1ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/libvpx/libvpx_1.9.0-1ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/libvpx/libvpx_1.9.0-1ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading libvpx_1.9.0-1ubuntu1.dsc: done.
  Uploading libvpx_1.9.0-1ubuntu1.debian.tar.xz: done.
  Uploading libvpx_1.9.0-1ubuntu1_source.buildinfo: done.
  Uploading libvpx_1.9.0-1ubuntu1_source.changes: done.
Successfully uploaded packages.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

diff --git a/debian/changelog b/debian/changelog
index d32bede..f559ac1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+libvpx (1.9.0-1ubuntu1) impish; urgency=medium
+
+  * d/rules: Disable LTO and fix FTBFS when building with GCC 11.
+    (LP: #1939640)
+
+ -- Sergio Durigan Junior <[e-mail]>  Wed, 11 Aug 2021 22:25:45 -0400
+
 libvpx (1.9.0-1) unstable; urgency=medium
 
   * Team upload
diff --git a/debian/control b/debian/control
index 4203206..decace7 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: libvpx
 Section: video
 Priority: optional
-Maintainer: Debian Multimedia Maintainers <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian Multimedia Maintainers <[e-mail]>
 Uploaders: Sebastian Dröge <[e-mail]>,
            Ondřej Nový <[e-mail]>,
 Build-Depends: debhelper-compat (= 13),
diff --git a/debian/rules b/debian/rules
index e186702..cb1b2ed 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,6 +5,9 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 DEB_CFLAGS_MAINT_APPEND = -Wall
 DEB_CXXFLAGS_MAINT_APPEND = -Wall
 
+# The build fails with GCC 11 when using LTO.
+export DEB_BUILD_MAINT_OPTIONS = optimize=-lto
+
 include /usr/share/dpkg/architecture.mk
 
 configure_flags += \