Merge ~sergiodj/ubuntu/+source/gvm-libs:fix-ftbfs-uninitialized into ubuntu/+source/gvm-libs:ubuntu/devel

[Sergio Durigan Junior]

This MP fixes the FTBFS that's currently affecting gvm-libs.

The problem is simple: GCC 12 is more strict when checking for uninitialized variables, and the following error was caught when compiling the package:

In function ‘ip_islocalhost’,
    inlined from ‘gvm_routethrough’ at ./base/networking.c:1032:11:
./base/networking.c:863:22: error: ‘addr6.__in6_u.__u6_addr32[3]’ may be used uninitialized [-Werror=maybe-uninitialized]
./base/networking.c: In function ‘gvm_routethrough’:
./base/networking.c:790:19: note: ‘addr6.__in6_u.__u6_addr32[3]’ was declared here
...

https://launchpadlibrarian.net/643052273/buildlog_ubuntu-lunar-amd64.gvm-libs_22.4.1-2_BUILDING.txt.gz

To fix it, I'm initializing "addr6" with IN6ADDR_ANY_INIT, which is a convenience macro that means ::/0. If you look at the code, you'll notice that it is unlikely that "addr6" is ever uninitialized, but it's better to be safe here.

I submitted this fix to upstream as well: https://github.com/greenbone/gvm-libs/pull/728

There's a PPA with the proposed changes here:

https://launchpad.net/~sergiodj/+archive/ubuntu/gvm-libs/+packages

The package doesn't have autopkgtests.

[Bryce Harrington (bryce)]

Can you include an explanation (in the patch or bug report is fine) as to why it's initialized to IN6ADDR_ANY_INIT versus 0 or -1 or some other value?

review: Needs Information

[Sergio Durigan Junior (sergiodj)]

Done; comment added in the patch. Let me know what you think.

Thanks.

[Bryce Harrington (bryce)]

Thanks, looks great.

review: Approve

[Sergio Durigan Junior (sergiodj)]

On Friday, January 06 2023, Bryce Harrington wrote:

> Thanks, looks great.

Thanks Bryce.

Uploaded:

$ dput gvm-libs_22.4.1-2ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/gvm-libs/gvm-libs_22.4.1-2ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/gvm-libs/gvm-libs_22.4.1-2ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading gvm-libs_22.4.1-2ubuntu1.dsc: done.
  Uploading gvm-libs_22.4.1-2ubuntu1.debian.tar.xz: done.
  Uploading gvm-libs_22.4.1-2ubuntu1_source.buildinfo: done.
  Uploading gvm-libs_22.4.1-2ubuntu1_source.changes: done.
Successfully uploaded packages.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

diff --git a/debian/changelog b/debian/changelog
index 4d658fd..c797658 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+gvm-libs (22.4.1-2ubuntu1) lunar; urgency=medium
+
+  * d/p/Fix-FTBFS-uninitialized-var-GCC-12.patch: Fix FTBFS due to
+    uninitialized variable. (LP: #2002022)
+
+ -- Sergio Durigan Junior <[e-mail]>  Thu, 05 Jan 2023 13:35:58 -0500
+
 gvm-libs (22.4.1-2) unstable; urgency=medium
 
   * Fix build on 32 bit arch
diff --git a/debian/control b/debian/control
index 67a95db..a19cf3f 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: gvm-libs
 Section: libs
 Priority: optional
-Maintainer: Debian Security Tools <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian Security Tools <[e-mail]>
 Uploaders: Sophie Brun <[e-mail]>
 Build-Depends: debhelper-compat (= 13),
                cmake,
diff --git a/debian/patches/Fix-FTBFS-uninitialized-var-GCC-12.patch b/debian/patches/Fix-FTBFS-uninitialized-var-GCC-12.patch
new file mode 100644
index 0000000..7ea0d0e
--- /dev/null
+++ b/debian/patches/Fix-FTBFS-uninitialized-var-GCC-12.patch
@@ -0,0 +1,29 @@
+From: Sergio Durigan Junior <[e-mail]>
+Date: Wed, 4 Jan 2023 22:28:43 -0500
+Subject: Fix FTBFS due to uninitialized variable on GCC 12
+
+"addr6" is being initialized as IN6ADDR_ANY_INIT (instead of 0 or -1)
+because, being a structure, we need to initialize all of its fields.
+IN6ADDR_ANY_INIT is a macro that means "::/0", which is good enough
+for an initial value here (especially because "addr6" will be
+reassigned later on in the function).
+
+Forwarded: yes, https://github.com/greenbone/gvm-libs/pull/728
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/gvm-libs/+bug/2002022
+---
+ base/networking.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/base/networking.c b/base/networking.c
+index 1d1d7a1..7a1170c 100644
+--- a/base/networking.c
++++ b/base/networking.c
+@@ -787,7 +787,7 @@ ip_islocalhost (struct sockaddr_storage *storage)
+ {
+   struct in_addr addr;
+   struct in_addr *addr_p;
+-  struct in6_addr addr6;
++  struct in6_addr addr6 = IN6ADDR_ANY_INIT;
+   struct in6_addr *addr6_p;
+   struct sockaddr_in *sin_p;
+   struct sockaddr_in6 *sin6_p;
diff --git a/debian/patches/series b/debian/patches/series
index 61607cd..ef8e5f2 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
 disable-networking-test.patch
 Fix-test-failure-on-ipv6-only-build-daemons.patch
 Fix-build-with-gpgme-1.18.0-2.patch
+Fix-FTBFS-uninitialized-var-GCC-12.patch