Merge ~sergiodj/ubuntu/+source/gstreamer1.0:use-g_memdup2-where-available into ubuntu/+source/gstreamer1.0:ubuntu/devel
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Sergio Durigan Junior | ||||
Proposed branch: | ~sergiodj/ubuntu/+source/gstreamer1.0:use-g_memdup2-where-available | ||||
Merge into: | ubuntu/+source/gstreamer1.0:ubuntu/devel | ||||
Diff against target: |
287 lines (+255/-1) 4 files modified
debian/changelog (+8/-0) debian/control (+2/-1) debian/patches/0002-Use-g_memdup2-where-available-and-add-fallback-for-o.patch (+244/-0) debian/patches/series (+1/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Utkarsh Gupta (community) | Approve | ||
Canonical Desktop Team | Pending | ||
Review via email: mp+405405@code.launchpad.net |
Description of the change
Currently, libcamera FTBFS because gstreamer is using a deprecated g_memdup:
/usr/include/
/usr/include/
365 | return (guint8 *) g_memdup (data, size);
| ^
In file included from /usr/include/
/usr/include/
257 | gpointer g_memdup (gconstpointer mem,
This has been fixed by upstream gstreamer, and the patch is simple enough and I think we should adopt it as a delta while Debian doesn't pick it up:
https:/
This is what this MP is about.
I tested rebuilding gstreamer with the upstream patch and then rebuilding libcamera with the new gstreamer package, and the build succeeded.
There's a PPA with the proposed gstreamer package and the libcamera rebuild here:
https:/
* Changelog:
- [-] old content and logical tag match as expected
- [✔] changelog entry correct version and targeted codename
- [✔] changelog entries correct
- [✔] update-maintainer has been run
* Actual changes:
- [-] no upstream changes to consider
- [✔] no further upstream version to consider
- [-] debian changes look safe
* New Delta: patches/ series
- [✔] patches match what was proposed upstream
- [✔] patches correctly included in debian/
- [✔] patches have correct DEP3 metadata
- [x] patches forwarded to Debian
I don't see the patches being forwarded however I believe that the new version that Debian will incorporate after the freeze should automatically pick this up. So not a problem, I believe. In case you've had different reasons for not forwarding, I'd be interested to hear them. Thanks!
* Build/Test:
- [✔] build is ok
- [✔] verified PPA package installs/uninstalls
- [-] autopkgtest against the PPA package passes
- [-] sanity checks test fine
I suppose you've done the above two things here, as mentioned in the comment, so I didn't re-do the whole thing.
+1. Thank you!