Merge ~sergiodj/ubuntu/+source/backuppc:samba-dep8-bug1962166 into ubuntu/+source/backuppc:ubuntu/devel

[Sergio Durigan Junior]

This MP fixes backuppc's dep8 failures with Samba 4.15.5.

You can read about my investigation here:

https://bugs.launchpad.net/ubuntu/+source/backuppc/+bug/1962166/comments/1

and here:

https://bugzilla.samba.org/show_bug.cgi?id=14991

Debian is still on Samba 4.13.14, so this patch doesn't apply to them. Also, I'm going to file a bug against backuppc upstream and see if I can get them to improve/fix the way they invoke smbclient when both the username and password provided are empty.

There's a PPA with the proposed change here:

https://launchpad.net/~sergiodj/+archive/ubuntu/backuppc-bug1962166/+packages

autopkgtest is now passing on all architectures (using all-proposed=1, otherwise Samba 4.15.5 isn't used):

autopkgtest [22:35:55]: @@@@@@@@@@@@@@@@@@@@ summary
smb-backup PASS

[Andreas Hasenack (ahasenack)]

Nice investigation, thanks!

It does sound silly to provide empty username and password. Let's land this, and I will file a bug for myself to add another DEP8 test, one that uses an actual username and password, and rename this one to "test anonymous backup" or something. And if it stays like this (samba upstream says it's as it should be, and backuppc says one shouldn't be using anonymous shares like this), we can add an entry to the release notes.

I also subscribed to the upstream samba bug you filed, thanks for that too.

review: Approve

[Sergio Durigan Junior (sergiodj)]

On Saturday, February 26 2022, Andreas Hasenack wrote:

> Nice investigation, thanks!
>
> It does sound silly to provide empty username and password. Let's land
> this, and I will file a bug for myself to add another DEP8 test, one
> that uses an actual username and password, and rename this one to
> "test anonymous backup" or something. And if it stays like this (samba
> upstream says it's as it should be, and backuppc says one shouldn't be
> using anonymous shares like this), we can add an entry to the release
> notes.

+1, thanks for the quick review and sorry about the delay.

> I also subscribed to the upstream samba bug you filed, thanks for that too.

No problem.

Uploaded:

$ dput backuppc_4.4.0-5ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/backuppc/backuppc_4.4.0-5ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/backuppc/backuppc_4.4.0-5ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading backuppc_4.4.0-5ubuntu1.dsc: done.
  Uploading backuppc_4.4.0-5ubuntu1.debian.tar.xz: done.
  Uploading backuppc_4.4.0-5ubuntu1_source.buildinfo: done.
  Uploading backuppc_4.4.0-5ubuntu1_source.changes: done.
Successfully uploaded packages.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

diff --git a/debian/changelog b/debian/changelog
index 9976159..543bb7a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+backuppc (4.4.0-5ubuntu1) jammy; urgency=medium
+
+  * d/t/smb-backup: Provide non-empty username/password values to
+    authenticate against the Samba share, working around a possible Samba
+    regression with anonymous authentication. (LP: #1962166)
+
+ -- Sergio Durigan Junior <[e-mail]>  Fri, 25 Feb 2022 16:49:57 -0500
+
 backuppc (4.4.0-5) unstable; urgency=medium
 
   [ Simon McVittie ]
diff --git a/debian/control b/debian/control
index 829dc6f..51e3d7d 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: backuppc
 Section: utils
 Priority: optional
-Maintainer: Debian BackupPC Team <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian BackupPC Team <[e-mail]>
 Uploaders: Tobias Frost <[e-mail]>,
            Axel Beckert <[e-mail]>,
            Jonathan Wiltshire <[e-mail]>
diff --git a/debian/tests/smb-backup b/debian/tests/smb-backup
index 7ec3f21..209af08 100644
--- a/debian/tests/smb-backup
+++ b/debian/tests/smb-backup
@@ -62,8 +62,8 @@ add_localhost_backuppc_config() {
 \$Conf{ClientCharset} = '';
 \$Conf{ClientCharsetLegacy} = 'iso-8859-1';
 \$Conf{SmbShareName} = 'public';
-\$Conf{SmbShareUserName} = '';
-\$Conf{SmbSharePasswd} = '';
+\$Conf{SmbShareUserName} = 'guest';
+\$Conf{SmbSharePasswd} = 'nothing';
 \$Conf{PingPath} = '/bin/ping';
 \$Conf{Ping6Path} = '/bin/ping6';
 EOFEOF