Merge ~sergiodj/ubuntu-docker-images/+git/telegraf:1.19-21.10 into ~ubuntu-docker-images/ubuntu-docker-images/+git/telegraf:1.17-21.04

Proposed by Sergio Durigan Junior
Status: Merged
Merge reported by: Sergio Durigan Junior
Merged at revision: 82eba1312d7f2fb4b756e68158181d9cf1245ef1
Proposed branch: ~sergiodj/ubuntu-docker-images/+git/telegraf:1.19-21.10
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/telegraf:1.17-21.04
Diff against target: 86 lines (+9/-9)
4 files modified
Dockerfile (+2/-2)
HACKING.md (+2/-2)
README.md (+3/-3)
data/telegraf.yaml (+2/-2)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Athos Ribeiro Pending
Canonical Server Pending
Review via email: mp+407749@code.launchpad.net

Description of the change

This MP updates the telegraf OCI image to use Ubuntu Impish as the base layer. It also updates the documentation.

Built locally and tested with our unittest suite.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Athos would probably be better to review than me, but I know he's off until next week.
I wanted to at least test your image builds, but unfortunately my local system's docker doesn't work, so will instead trust CI to build/test.

Verified the new version is 1.19.2 in impish, and things seem to be substituted correctly.

LGTM, +1

review: Approve
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

On Thursday, August 26 2021, Bryce Harrington wrote:

> Athos would probably be better to review than me, but I know he's off until next week.
> I wanted to at least test your image builds, but unfortunately my local system's docker doesn't work, so will instead trust CI to build/test.
>
> Verified the new version is 1.19.2 in impish, and things seem to be substituted correctly.
>
> LGTM, +1

Thanks for the review, Bryce. New branch created.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index 3bcd73f..2c619d2 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -1,4 +1,4 @@
6-FROM ubuntu:hirsute AS manifest-builder
7+FROM ubuntu:impish AS manifest-builder
8
9 WORKDIR /src/telegraf
10
11@@ -22,7 +22,7 @@ RUN set -eux; \
12 /src/telegraf/utils/golang-manifest-builder.py /src/telegraf/telegraf-mods.txt > /src/telegraf/manifest-upstream.txt; \
13 cat /src/telegraf/manifest-upstream.txt
14
15-FROM ubuntu:hirsute
16+FROM ubuntu:impish
17
18 ENV TZ UTC
19
20diff --git a/HACKING.md b/HACKING.md
21index 0423e8f..70266c4 100644
22--- a/HACKING.md
23+++ b/HACKING.md
24@@ -1,7 +1,7 @@
25 # Contributing
26
27 In Ubuntu, Telegraf is available as a `.deb` package. For this reason,
28-this image was built by installing the Telegraf Ubuntu 21.04 package
29+this image was built by installing the Telegraf Ubuntu 21.10 package
30 inside a docker container.
31
32 In order to contribute to the Telegraf OCI image, do the following:
33@@ -50,6 +50,6 @@ The repository containing the templates is located at:
34 https://code.launchpad.net/~canonical-server/ubuntu-docker-images/+git/templates
35
36 The specific data for this image's template can be found inside the
37-`data/` directory.
38+`data/` directory, in the image's own repository.
39
40
41diff --git a/README.md b/README.md
42index 1d66f30..1ade38b 100644
43--- a/README.md
44+++ b/README.md
45@@ -19,7 +19,7 @@ _Tags in italics are not available in ubuntu/telegraf but are shown here for com
46
47 | Channel Tag | | | Currently | Architectures |
48 |---|---|---|---|---|
49-| **`1.17-21.04_beta`**    | | | Telegraf 1.17.2 on Ubuntu 21.04 | `amd64`, `arm64`, `ppc64el`, `s390x` |
50+| **`1.19-21.10_beta`**    | | | Telegraf 1.19.2 on Ubuntu 21.10 | `amd64`, `arm64`, `ppc64el`, `s390x` |
51 | _`track_risk`_ |
52
53 Channel tag shows the most stable channel for that track ordered `stable`, `candidate`, `beta`, `edge`. More risky channels are always implicitly available. So if `beta` is listed, you can also pull `edge`. If `candidate` is listed, you can pull `beta` and `edge`. When `stable` is listed, all four are available. Images are guaranteed to progress through the sequence `edge`, `beta`, `candidate` before `stable`.
54@@ -30,7 +30,7 @@ Channel tag shows the most stable channel for that track ordered `stable`, `cand
55 Launch this image locally:
56
57 ```sh
58-docker run -d --name telegraf-container -e TZ=UTC -p 30273:9273 ubuntu/telegraf:1.17-21.04_beta
59+docker run -d --name telegraf-container -e TZ=UTC -p 30273:9273 ubuntu/telegraf:1.19-21.10_beta
60 ```
61 Access your Telegraf server at `localhost:30273`.
62
63@@ -64,7 +64,7 @@ Works with any Kubernetes; if you don't have one, we recommend you [install Micr
64
65 Download
66 [telegraf.conf](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/telegraf/plain/examples/config/telegraf.conf) and
67-[telegraf-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/telegraf/plain/examples/telegraf-deployment.yml) and set `containers.telegraf.image` in `telegraf-deployment.yml` to your chosen channel tag (e.g. `ubuntu/telegraf:1.17-21.04_beta`), then:
68+[telegraf-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/telegraf/plain/examples/telegraf-deployment.yml) and set `containers.telegraf.image` in `telegraf-deployment.yml` to your chosen channel tag (e.g. `ubuntu/telegraf:1.19-21.10_beta`), then:
69
70 ```sh
71 kubectl create configmap telegraf-config --from-file=main-config=telegraf.conf
72diff --git a/data/telegraf.yaml b/data/telegraf.yaml
73index 67cd654..7de933d 100644
74--- a/data/telegraf.yaml
75+++ b/data/telegraf.yaml
76@@ -3,8 +3,8 @@ main: false
77 repo: telegraf
78 description: >
79 Telegraf is an agent for collecting, processing, aggregating, and writing metrics. Design goals are to have a minimal memory footprint with a plugin system so that developers in the community can easily add support for collecting metrics. Read more on the [Telegraf website](https://www.influxdata.com/time-series-platform/telegraf/).
80-version: 1.17.2
81-base: Ubuntu 21.04
82+version: 1.19.2
83+base: Ubuntu 21.10
84 architectures:
85 - amd64
86 - arm64

Subscribers

People subscribed via source and target branches