Merge ~sergiodj/ubuntu-docker-images/+git/grafana:8.2-22.04 into ~ubuntu-docker-images/ubuntu-docker-images/+git/grafana:8.1-21.10

Proposed by Sergio Durigan Junior
Status: Merged
Merge reported by: Sergio Durigan Junior
Merged at revision: d4b5640537512382f6a6386eb462b08ac1ad94ca
Proposed branch: ~sergiodj/ubuntu-docker-images/+git/grafana:8.2-22.04
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/grafana:8.1-21.10
Diff against target: 27 lines (+3/-3)
1 file modified
Dockerfile (+3/-3)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Athos Ribeiro Pending
Canonical Server Pending
Review via email: mp+416992@code.launchpad.net

Description of the change

This MP creates the grafana 22.04 ROCK image.

It is targeted against the 8.1-21.10 branch only to make it easier to review; once this is approved, I will push it to a new branch named 8.2-22.04.

The only significant change here is that we're going to start using the 'rock' track when downloading the snap; otherwise, everything stays the same.

As a reminder: we're not updating this image to the latest upstream version because it can't build on big endian architectures (see https://github.com/grafana/grafana/issues/46269).

Tested locally with the unittest:

DOCKER_IMAGE=sergiodj/grafana /bin/sh ~/work/server-test-scripts/oci-unit-tests/grafana_test.sh
Error response from daemon: manifest for sergiodj/grafana:latest not found: manifest unknown: manifest unknown
test_default_config
test_default_config_ipv6
test_persistent_storage
test_manifest_exists

Ran 4 tests.

OK

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Pretty much carbon copy of changes to prometheus, and again LGTM.

review: Approve
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

On Wednesday, March 16 2022, Bryce Harrington wrote:

> Pretty much carbon copy of changes to prometheus, and again LGTM.

Thanks for the review, Bryce.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index aae5c65..f6ab5b6 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -4,7 +4,7 @@
6 # and adapted to use the grafana snap built from
7 # https://github.com/auria/snap-grafana and installed from
8 # https://snapcraft.io/grafana
9-FROM ubuntu:impish AS snap-installer
10+FROM ubuntu:jammy AS snap-installer
11
12 RUN set -eux; \
13 apt-get update; \
14@@ -14,11 +14,11 @@ RUN set -eux; \
15
16 # taken from https://snapcraft.io/docs/build-on-docker
17 # Alternatively, we can install snapd, and issue `snap download grafana`
18-RUN curl -L -H 'Snap-CDN: none' $(curl -H 'X-Ubuntu-Series: 16' -H "X-Ubuntu-Architecture: $(dpkg --print-architecture)" 'https://api.snapcraft.io/api/v1/snaps/details/grafana?channel=21.10/edge' | jq '.download_url' -r) --output grafana.snap
19+RUN curl -L -H 'Snap-CDN: none' $(curl -H 'X-Ubuntu-Series: 16' -H "X-Ubuntu-Architecture: $(dpkg --print-architecture)" 'https://api.snapcraft.io/api/v1/snaps/details/grafana?channel=rock/edge' | jq '.download_url' -r) --output grafana.snap
20
21 RUN mkdir -p /snap && unsquashfs -d /snap/grafana grafana.snap
22
23-FROM ubuntu:impish
24+FROM ubuntu:jammy
25
26 EXPOSE 3000
27 LABEL maintainer="Ubuntu Server team <ubuntu-server@lists.ubuntu.com>"

Subscribers

People subscribed via source and target branches