Merge ~sergiodj/prometheus-snap:skip-template-test into prometheus-snap:20.04

[Sergio Durigan Junior]

This MP temporarily disables the template_test.go testcase because it is failing on non-amd64 architectures.

This is most likely caused by the architecture-dependent way that Go performs the conversion between floats and ints, which affects this specific test. For more details, see:

https://github.com/prometheus/prometheus/issues/10185

[Sergio Durigan Junior (sergiodj)]

FWIW, I took the liberty to leave a "reminder" that will make the build fail when we update the snap, so that we remember to remove this temporary hack (which will be hopefully fixed by then).

[Athos Ribeiro (athos-ribeiro)]

You are missing a "then" statement for the if/else block there. Other than that, LGTM!

review: Needs Fixing

[Sergio Durigan Junior (sergiodj)]

On Thursday, January 20 2022, Athos Ribeiro wrote:

> You are missing a "then" statement for the if/else block there. Other than that, LGTM!

Ops, thanks Athos, I've fixed it.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

[Athos Ribeiro (athos-ribeiro)]

Thanks! LGTM :)

review: Approve

diff --git a/snapcraft.yaml b/snapcraft.yaml
index 3e6d880..05401d6 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -52,6 +52,16 @@ parts:
         export PATH=/usr/local/lib/nodejs/node-v${NODE_VERSION}-linux-${NODE_ARCH}/bin:$PATH
         NODE_ENV="production"
         npm install yarn -g
+        # See https://github.com/prometheus/prometheus/issues/10185
+        # for an explanation regarding the snippet below.
+        if [ "${SNAPCRAFT_PROJECT_VERSION}" = "2.32.1" ]; then
+          rm -fv template/template_test.go
+        else
+          echo
+          echo "FIXME: Please verify if the template/template_test.go still fails."
+          echo
+          exit 1
+        fi
         make build
         make common-test-short
         mkdir -p $SNAPCRAFT_PART_INSTALL/bin