Merge lp:~sergiodj/midori/safe-ciphers into lp:midori

Proposed by Sergio Durigan Junior
Status: Needs review
Proposed branch: lp:~sergiodj/midori/safe-ciphers
Merge into: lp:midori
Diff against target: 15 lines (+5/-0)
1 file modified
midori/main.c (+5/-0)
To merge this branch: bzr merge lp:~sergiodj/midori/safe-ciphers
Reviewer Review Type Date Requested Status
Cris Dywan Pending
Review via email: mp+277914@code.launchpad.net

Commit message

Improve security by making sure that we use a safe set of ciphers.

This comes from Debian bug #804196 (LP Bug #1517265). When Midori
uses libwebkitgtk, it inherits the default value of the
G_TLS_GNUTLS_PRIORITY environment variable. Unfortunately this value
is not safe enough because it still lets GnuTLS to enable to unsafe
ciphers. Therefore, we need to set this variable ourselves and make
sure that Midori is using safe ciphers for TLS operations.

Description of the change

Improve security by making sure that we use a safe set of ciphers.

This comes from Debian bug #804196 (LP Bug #1517265). When Midori
uses libwebkitgtk, it inherits the default value of the
G_TLS_GNUTLS_PRIORITY environment variable. Unfortunately this value
is not safe enough because it still lets GnuTLS to enable to unsafe
ciphers. Therefore, we need to set this variable ourselves and make
sure that Midori is using safe ciphers for TLS operations.

To post a comment you must log in.

Unmerged revisions

7058. By Sergio Durigan Junior

Improve security by making sure that we use a safe set of ciphers.

This comes from Debian bug #804196 (LP Bug #1517265). When Midori
uses libwebkitgtk, it inherits the default value of the
G_TLS_GNUTLS_PRIORITY environment variable. Unfortunately this value
is not safe enough because it still lets GnuTLS to enable to unsafe
ciphers. Therefore, we need to set this variable ourselves and make
sure that Midori is using safe ciphers for TLS operations.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/main.c'
2--- midori/main.c 2014-04-23 03:34:23 +0000
3+++ midori/main.c 2015-11-18 21:32:32 +0000
4@@ -143,6 +143,11 @@
5 /* Versioned prgname to override menuproxy blacklist */
6 g_set_prgname (PACKAGE_NAME "4");
7
8+ /* Make sure we are using a sane set of ciphers. */
9+ g_setenv ("G_TLS_GNUTLS_PRIORITY",
10+ "NORMAL:%COMPAT:%LATEST_RECORD_VERSION:!VERS-SSL3.0:!ARCFOUR-128",
11+ 1);
12+
13 if (version)
14 {
15 GString* versions = g_string_new ("");

Subscribers

People subscribed via source and target branches