Merge lp:~sergiodj/lp-ftbfs-report/fix-internal-pkgset-team-links into lp:~wgrant/lp-ftbfs-report/production

Proposed by Sergio Durigan Junior
Status: Merged
Merged at revision: 67
Proposed branch: lp:~sergiodj/lp-ftbfs-report/fix-internal-pkgset-team-links
Merge into: lp:~wgrant/lp-ftbfs-report/production
Diff against target: 33 lines (+4/-4)
1 file modified
source/build_status.html (+4/-4)
To merge this branch: bzr merge lp:~sergiodj/lp-ftbfs-report/fix-internal-pkgset-team-links
Reviewer Review Type Date Requested Status
William Grant Pending
Review via email: mp+407099@code.launchpad.net

Description of the change

When the packageset and the team names are the same, the internal links for each of these will end up also being the same. Currently, because the packageset section comes first in the page, that means that the team internal link will point to it.

A simple fix is to use distinct suffixes to compose the internal link names, which help differentiate them.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'source/build_status.html'
2--- source/build_status.html 2018-06-05 22:44:50 +0000
3+++ source/build_status.html 2021-08-13 16:25:17 +0000
4@@ -131,12 +131,12 @@
5
6 <p>Jump to packageset:
7 {% for (ps, lst) in packagesets.items()|sort if lst|count > 0 -%}
8- <a href="#{{ ps }}">{{ ps }}</a> ({{ lst|count }})
9+ <a href="#{{ ps }}-pkgset">{{ ps }}</a> ({{ lst|count }})
10 {% endfor -%}
11 </p>
12 <p>Jump to team:
13 {% for (team, lst) in teams.items()|sort if lst|count > 0 -%}
14- <a href="#{{ team }}">{{ team }}</a> ({{ lst|count }})
15+ <a href="#{{ team }}-team">{{ team }}</a> ({{ lst|count }})
16 {% endfor -%}
17 </p>
18
19@@ -190,13 +190,13 @@
20
21 <h2>Packagesets</h2>
22 {% for (ps, lst) in packagesets.items()|sort if lst|count > 0 -%}
23- <h3 id="{{ ps }}">{{ ps }}: {{ lst|count }} packages (<a href="#top">top</a>)</h3>
24+ <h3 id="{{ ps }}-pkgset">{{ ps }}: {{ lst|count }} packages (<a href="#top">top</a>)</h3>
25 {{ table(lst, ps, 'Also belongs to another packageset?') }}
26 {% endfor -%}
27
28 <h2>Teams (main only)</h2>
29 {% for (team, lst) in teams.items()|sort if lst|count > 0 -%}
30- <h3 id="{{ team }}">{{ team }}: {{ lst|count }} packages (<a href="#top">top</a>)</h3>
31+ <h3 id="{{ team }}-team">{{ team }}: {{ lst|count }} packages (<a href="#top">top</a>)</h3>
32 {{ table(lst, team, 'Also belongs to another team?') }}
33 {% endfor -%}
34

Subscribers

People subscribed via source and target branches