Merge lp:~sergei.glushchenko/percona-xtrabackup/xb20-bug976945 into lp:percona-xtrabackup/2.0
Proposed by
Sergei Glushchenko
Status: | Merged |
---|---|
Approved by: | Alexey Kopytov |
Approved revision: | no longer in the source branch. |
Merged at revision: | 451 |
Proposed branch: | lp:~sergei.glushchenko/percona-xtrabackup/xb20-bug976945 |
Merge into: | lp:percona-xtrabackup/2.0 |
Diff against target: |
125 lines (+69/-20) 2 files modified
src/xtrabackup.c (+34/-20) test/t/bug976945.sh (+35/-0) |
To merge this branch: | bzr merge lp:~sergei.glushchenko/percona-xtrabackup/xb20-bug976945 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Review via email: mp+110468@code.launchpad.net |
Description of the change
Bug976945: innodb_
When called with --prepare xtrabackup didn't initialize
log_block_size properly.
Solution is to initialize log_block_size from inside
xtrabackup_
http://
#24231
To post a comment you must log in.
Sergei,
- let's do some cleanups instead of copy-pasting the code. Please remove the ####EXPERIMENTA L#### warning, as it's not clear what users are supposed to do with that information.
- I would do the error handling in the xb_init_ log_block_ size() rather than rely on the callers. I.e. print the error if srv_log_block_size is zero and return TRUE.
- I would rather put #ifdef XTRADB_BASED inside xb_init_ log_block_ size() so it's an empty function for other configurations and we have less #ifdefs in the code.
- there's no need to check for xtrabackup_prepare in innodb_ init_param( ). It's OK to call this function twice. And it doesn't hurt to print the informational message twice. In fact, in my compact backups branch innodb_init_param() may be called multiple times at prepare.
- the test case is incompatible with the changes to the test suite I pushed recently. "run_mysqld" and "stop_mysqld" have been renamed to "start_server" and "stop_server" respectively, and "init" has been removed. Please pull from 2.0 and update the test case.