Merge lp:~sergei.glushchenko/percona-xtrabackup/xb2.0-bug989397 into lp:percona-xtrabackup/2.0

Proposed by Sergei Glushchenko
Status: Merged
Approved by: Stewart Smith
Approved revision: no longer in the source branch.
Merged at revision: 432
Proposed branch: lp:~sergei.glushchenko/percona-xtrabackup/xb2.0-bug989397
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 36 lines (+20/-1)
2 files modified
innobackupex (+1/-1)
test/t/bug989397.sh (+19/-0)
To merge this branch: bzr merge lp:~sergei.glushchenko/percona-xtrabackup/xb2.0-bug989397
Reviewer Review Type Date Requested Status
Stewart Smith (community) Approve
Review via email: mp+104395@code.launchpad.net

Description of the change

Bug989397: InnoDB tables with names *opt*, *par*, *CSV*, *MYD*
and so on backed up twice.
Such tables were backed up by xtrabackup binary and by innobackupex
script. Regexp for filtering database directory contents was fixed.

http://jenkins.percona.com/view/Percona%20Xtrabackup/job/percona-xtrabackup-param/181/

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'innobackupex'
2--- innobackupex 2012-05-15 09:30:50 +0000
3+++ innobackupex 2012-05-17 13:40:23 +0000
4@@ -2008,7 +2008,7 @@
5
6 # copy files of this database
7 opendir(DBDIR, "$source_dir/$database");
8- @list = grep(/\.(frm)|(MYD)|(MYI)|(MRG)|(TRG)|(TRN)|(ARM)|(ARZ)|(CSM)|(CSV)|(opt)|(par)$/, readdir(DBDIR));
9+ @list = grep(/\.(frm|MYD|MYI|MRG|TRG|TRN|ARM|ARZ|CSM|CSV|opt|par)$/, readdir(DBDIR));
10 closedir DBDIR;
11 $file_c = @list;
12 if ($file_c <= $backup_file_print_limit) {
13
14=== added file 'test/t/bug989397.sh'
15--- test/t/bug989397.sh 1970-01-01 00:00:00 +0000
16+++ test/t/bug989397.sh 2012-05-17 13:40:23 +0000
17@@ -0,0 +1,19 @@
18+############################################################################
19+# Bug989397: InnoDB tables with names *opt*, *par*, *CSV*, *MYD* and so on
20+# backed up twice
21+############################################################################
22+
23+. inc/common.sh
24+
25+init
26+run_mysqld --innodb_file_per_table
27+
28+# create table which name ends with opt
29+${MYSQL} ${MYSQL_ARGS} -e "create table test.topt (a int auto_increment primary key);"
30+
31+# take a backup with stream mode
32+mkdir -p $topdir/backup
33+innobackupex --stream=xbstream $topdir/backup > $topdir/backup/stream.xbs
34+
35+# will fail if table topt backed up twice
36+xbstream -xv -C $topdir/backup < $topdir/backup/stream.xbs

Subscribers

People subscribed via source and target branches