Merge lp:~sergei.glushchenko/percona-xtrabackup/bug983685-xb2.0 into lp:percona-xtrabackup/2.0

Proposed by Sergei Glushchenko
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 424
Proposed branch: lp:~sergei.glushchenko/percona-xtrabackup/bug983685-xb2.0
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 54 lines (+31/-1)
2 files modified
innobackupex (+3/-1)
test/t/bug983685.sh (+28/-0)
To merge this branch: bzr merge lp:~sergei.glushchenko/percona-xtrabackup/bug983685-xb2.0
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+102288@code.launchpad.net

Description of the change

Bug 983685: innodb_data_file_path is not written to backup-my.cnf
Regression introduced by fix for bug #733651.
Along with innodb_data_file_path, innodb_log_group_home_dir is also missed.

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'innobackupex'
2--- innobackupex 2012-03-27 01:08:22 +0000
3+++ innobackupex 2012-04-17 12:59:17 +0000
4@@ -1655,6 +1655,7 @@
5 }
6
7 my @option_names = (
8+ "innodb_data_file_path",
9 "innodb_log_files_in_group",
10 "innodb_log_file_size",
11 "innodb_fast_checksum",
12@@ -1666,7 +1667,8 @@
13 "# The MySQL server\n" .
14 "[mysqld]\n" .
15 "datadir=$root\n" .
16- "innodb_data_home_dir=$root\n";
17+ "innodb_data_home_dir=$root\n" .
18+ "innodb_log_group_home_dir=$root\n";
19
20 my $option_name;
21 foreach $option_name (@option_names) {
22
23=== added file 'test/t/bug983685.sh'
24--- test/t/bug983685.sh 1970-01-01 00:00:00 +0000
25+++ test/t/bug983685.sh 2012-04-17 12:59:17 +0000
26@@ -0,0 +1,28 @@
27+########################################################################
28+# Bug #983685: innodb_data_file_path is not written to backup-my.cnf
29+########################################################################
30+
31+. inc/common.sh
32+
33+init
34+
35+options="innodb_data_file_path innodb_log_group_home_dir"
36+
37+run_mysqld
38+
39+mkdir -p $topdir/backup
40+innobackupex $topdir/backup
41+backup_dir=`grep "innobackupex: Backup created in directory" $OUTFILE | awk -F\' '{ print $2}'`
42+vlog "Backup created in directory $backup_dir"
43+
44+# test presence of options
45+for option in $options ; do
46+
47+ if ! grep $option $backup_dir/backup-my.cnf ; then
48+ vlog "Option $option is absent"
49+ exit -1
50+ else
51+ vlog "Option $option is present"
52+ fi
53+
54+done

Subscribers

People subscribed via source and target branches