Merge lp:~sergei.glushchenko/percona-xtrabackup/ST31156-2.1-xb-bug1175860 into lp:percona-xtrabackup/2.1

Proposed by Sergei Glushchenko
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 588
Proposed branch: lp:~sergei.glushchenko/percona-xtrabackup/ST31156-2.1-xb-bug1175860
Merge into: lp:percona-xtrabackup/2.1
Diff against target: 38 lines (+23/-0)
2 files modified
innobackupex (+9/-0)
test/t/bug1175860.sh (+14/-0)
To merge this branch: bzr merge lp:~sergei.glushchenko/percona-xtrabackup/ST31156-2.1-xb-bug1175860
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
George Ormond Lorch III (community) g2 Approve
Review via email: mp+162468@code.launchpad.net

Description of the change

Manual merge from 2.0.

To post a comment you must log in.
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :
Revision history for this message
George Ormond Lorch III (gl-az) :
review: Approve (g2)
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'innobackupex'
2--- innobackupex 2013-04-28 18:35:33 +0000
3+++ innobackupex 2013-05-03 21:03:49 +0000
4@@ -1827,6 +1827,15 @@
5 }
6 }
7
8+ if ( -e "$option_tmpdir/$xtrabackup_pid_file" ) {
9+ print STDERR "WARNING : A left over instance of xtrabackup pid " .
10+ "file '$option_tmpdir/$xtrabackup_pid_file' " .
11+ "was found.\n";
12+ unlink $option_tmpdir . "/" . $xtrabackup_pid_file ||
13+ Die "Failed to delete " .
14+ "'$option_tmpdir/$xtrabackup_pid_file': $!";
15+ }
16+
17 } elsif ($option_copy_back || $option_move_back) {
18 #$backup_config_file = $backup_dir . '/backup-my.cnf';
19 #read_config_file($backup_config_file, \%backup_config);
20
21=== added file 'test/t/bug1175860.sh'
22--- test/t/bug1175860.sh 1970-01-01 00:00:00 +0000
23+++ test/t/bug1175860.sh 2013-05-03 21:03:49 +0000
24@@ -0,0 +1,14 @@
25+############################################################################
26+# Bug #1175860: Orphaned xtrabackup_pid file Breaks Cluster SST
27+############################################################################
28+
29+. inc/common.sh
30+
31+start_server
32+
33+echo "22993" > $MYSQLD_TMPDIR/xtrabackup_pid
34+
35+mkdir -p $topdir/backup
36+innobackupex --stream=tar $topdir/backup > /dev/null
37+
38+grep -q "A left over instance of xtrabackup pid file" $OUTFILE

Subscribers

People subscribed via source and target branches