Percona XtraBackup moved to https://jira.percona.com/projects/PXB

Code review comment for lp:~sergei.glushchenko/percona-xtrabackup/ST-25967-2.0

  1. ST-25967-2.0
  2. Merge into 2.0
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Sergei,

Thanks for explanations.

Some things I noticed when branching lp:~sergei.glushchenko/percona-xtrabackup/ST-25967-2.0 locally:

- revision #472 containing the fix for this bug is a _merge_ revision. It appears you committed the fix for #1066843 and #1068470, then merged it into another branch and then implemented a fix for bug #1062684 as a merge revision. Please create separate branches and separate revisions.

- xb_normalize_init_values() contains trailing whitespace for some lines

- both lines with calls to xb_normalize_init_values() use spaces rather than tabs for indentation.

review: Needs Fixing

« Back to merge proposal