Code review comment for lp:~sergei.glushchenko/percona-xtrabackup/ST-25967-2.0

Still something doesn't add up. So the code this patch moves from xtrabackup_backup_func() to xb_data_files_init() has been previously copy-pasted from srv_normalize_init_values().

Now srv_normalize_init_values is called from srv_boot() which in turn is called from innobase_start_or_create_for_mysql().

Which means when applying an incremental backup, we first execute that code by calling xb_data_files_init(). And then execute this code once again when starting an InnoDB instance by calling innodb_init().

Am I missing anything here?

Please also provide a proper description of the problem in revision comments. I.e. what exactly on the code level led to the crash. And the current solution ("Fixed by srv_data_file_sizes in xb_delta_open_matching_space.") doesn't make much sense either.