Code review comment for lp:~sergei.glushchenko/percona-xtrabackup/20-bug856400

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

However for this specific case using just a filename from innodb_data_file_path will not lead to catastrophe. It can lead only to some files will not be cleaned up.

If our tablespace is named say xtrabackup_tmp#1234.idb, and we removed tablespace with ID 1234 between full and incremental backup, the tmp# tablespace will remain in full backup directory. It will not be copied back on restore however because of https://bugs.launchpad.net/percona-xtrabackup/+bug/1169726. That's when two bugs eventually give almost correct result.

The reason why I started to think in that side was just a discomfort when I write a code that decide whether to remove file or not by using just it's name instead of fully qualified path.

Tree is updated, jenkins run is started, but supposedly it will be finished by tomorrow
http://jenkins.percona.com/view/XtraBackup/job/percona-xtrabackup-2.0-param/399/

« Back to merge proposal