Merge lp:~sergei.glushchenko/percona-xtrabackup/2.2-ST43302-xb-bug1340717 into lp:percona-xtrabackup/2.2

Proposed by Sergei Glushchenko
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 5001
Proposed branch: lp:~sergei.glushchenko/percona-xtrabackup/2.2-ST43302-xb-bug1340717
Merge into: lp:percona-xtrabackup/2.2
Diff against target: 71 lines (+40/-2)
2 files modified
storage/innobase/fil/fil0fil.cc (+5/-2)
storage/innobase/xtrabackup/test/t/bug1340717.sh (+35/-0)
To merge this branch: bzr merge lp:~sergei.glushchenko/percona-xtrabackup/2.2-ST43302-xb-bug1340717
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+227024@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tom Manville (tdmanville) wrote :

Any update on when this will be merged?

Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'storage/innobase/fil/fil0fil.cc'
2--- storage/innobase/fil/fil0fil.cc 2014-04-30 13:14:18 +0000
3+++ storage/innobase/fil/fil0fil.cc 2014-08-17 09:54:24 +0000
4@@ -45,6 +45,7 @@
5 #include "page0zip.h"
6 #include "pars0pars.h"
7 #include "que0que.h"
8+#include "trx0purge.h"
9 #include "trx0sys.h"
10 #include "row0mysql.h"
11 #ifndef UNIV_HOTBACKUP
12@@ -3691,7 +3692,9 @@
13 ib_logf(IB_LOG_LEVEL_WARN,
14 "It will be removed from the data dictionary.");
15
16- fil_remove_invalid_table_from_data_dict(tablename);
17+ if (purge_sys) {
18+ fil_remove_invalid_table_from_data_dict(tablename);
19+ }
20
21 err = DB_CORRUPTION;
22
23@@ -4900,7 +4903,7 @@
24
25 mutex_exit(&fil_system->mutex);
26
27- if (remove_from_data_dict) {
28+ if (remove_from_data_dict && purge_sys) {
29 fil_remove_invalid_table_from_data_dict(name);
30 }
31
32
33=== added file 'storage/innobase/xtrabackup/test/t/bug1340717.sh'
34--- storage/innobase/xtrabackup/test/t/bug1340717.sh 1970-01-01 00:00:00 +0000
35+++ storage/innobase/xtrabackup/test/t/bug1340717.sh 2014-08-17 09:54:24 +0000
36@@ -0,0 +1,35 @@
37+########################################################################
38+# Test resurrect table locks
39+########################################################################
40+
41+. inc/common.sh
42+
43+require_server_version_higher_than 5.6.0
44+
45+################################################################################
46+# Start an uncommitted transaction pause "indefinitely" to keep the connection
47+# open
48+################################################################################
49+function start_uncomitted_transaction()
50+{
51+ run_cmd $MYSQL $MYSQL_ARGS sakila <<EOF
52+START TRANSACTION;
53+DELETE FROM payment;
54+SELECT SLEEP(10000);
55+EOF
56+}
57+
58+start_server
59+load_sakila
60+
61+start_uncomitted_transaction &
62+job_master=$!
63+
64+sleep 5;
65+
66+innobackupex --no-timestamp --include="sakila.actor" $topdir/backup
67+
68+kill -SIGKILL $job_master
69+stop_server
70+
71+innobackupex --apply-log $topdir/backup

Subscribers

People subscribed via source and target branches