- I would call the option just ‘--close-files’, because ‘handlers’ looks
confusing (and should be ‘handles’ for that matter).
- users are generally not supposed to call xtrabackup directly, but use
innobackupex instead. Why is there no corresponding innobackupex
option?
- please add the warning to the built-in help for xtrabackup option
- please also update the docs (with the “use at your own risk” warning )
- the ‘-i’ option to run.sh has been added to usage text, but is not
actually handled
- XB_EXTRA_ARGS in run.sh is unused
- srv_close_file_handlers should be initialized to FALSE for consistency
Sergei,
- I would call the option just ‘--close-files’, because ‘handlers’ looks file_handlers should be initialized to FALSE for consistency
confusing (and should be ‘handles’ for that matter).
- users are generally not supposed to call xtrabackup directly, but use
innobackupex instead. Why is there no corresponding innobackupex
option?
- please add the warning to the built-in help for xtrabackup option
- please also update the docs (with the “use at your own risk” warning )
- the ‘-i’ option to run.sh has been added to usage text, but is not
actually handled
- XB_EXTRA_ARGS in run.sh is unused
- srv_close_