Merge lp:~sergei.glushchenko/percona-xtrabackup/2.0-BT39727-xb-bug1284778 into lp:percona-xtrabackup/2.0

Proposed by Sergei Glushchenko on 2014-02-26
Status: Merged
Approved by: Alexey Kopytov on 2014-02-26
Approved revision: 591
Merged at revision: 591
Proposed branch: lp:~sergei.glushchenko/percona-xtrabackup/2.0-BT39727-xb-bug1284778
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 18 lines (+2/-2)
1 file modified
innobackupex (+2/-2)
To merge this branch: bzr merge lp:~sergei.glushchenko/percona-xtrabackup/2.0-BT39727-xb-bug1284778
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) 2014-02-26 Approve on 2014-02-26
Review via email: mp+208353@code.launchpad.net

Description of the change

    Move START SLAVE SQL_THREAD before right after log copying stopped.
    This allows us not to wait for log streaming to complete.
http://jenkins.percona.com/view/PXB%202.0/job/percona-xtrabackup-2.0-param/517/

To post a comment you must log in.
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'innobackupex'
2--- innobackupex 2013-11-05 09:54:40 +0000
3+++ innobackupex 2014-02-26 12:57:56 +0000
4@@ -441,13 +441,13 @@
5 # release read locks on all tables
6 mysql_unlockall() if !$option_no_lock;
7
8- my $ibbackup_exit_code = wait_for_ibbackup_finish();
9-
10 if ( $option_safe_slave_backup && $sql_thread_started) {
11 print STDERR "$prefix: Starting slave SQL thread\n";
12 mysql_send('START SLAVE SQL_THREAD;');
13 }
14
15+ my $ibbackup_exit_code = wait_for_ibbackup_finish();
16+
17 # Close the DB connection
18 mysql_close();
19

Subscribers

People subscribed via source and target branches