Code review comment for lp:~sergei.glushchenko/percona-server/disable-flashcache

On 27.08.12 16:03, Sergei Glushchenko wrote:
> Alexey,
>
>> I think a clean way to implement the test case would be to add
>> 'include/have_flashcache.inc' (which would also require a separate
>> status variable). So you can easily check if the code you are going
>> to test is present in the binary. You should also test only the
>> --flashcache=0 case (i.e. the default) and make sure the
>> initialization message is not present in the error log. Then you only
>> need a few lines in Perl to implement that (see
>> percona_log_warnings_suppress.test for an example).
>
> There is already status variable Flashcache_enabled, which can be used to check flashcache presence. I'm thinking of having include/not_flashcache.inc.
>

No, Flashcache_enabled is present on all platforms, even on Windows. And
it will always be OFF on all platforms, since the test case does not
enable it explicitly. So not_flashcache.inc does not really check
anything, all platforms and binaries will pass it. Besides, the name of
that check is weird: we actually want to run this test when the
flashcache support is ON, so "include/not_flashcache.inc" is confusing.

I was talking about a separate system variable (not a status one, sorry)
similar to have_query_cache, have_partitioning, etc. that would only be
TRUE if the binary has flashcache code compiled in (i.e. is a Linux binary).