Percona Server moved to https://jira.percona.com/projects/PS

Merge lp:~sergei.glushchenko/percona-server/51-ST-27220-bug1042946 into lp:percona-server/5.1

  1. 51-ST-27220-bug1042946
  2. Merge into 5.1
Proposed by Sergei Glushchenko
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 517
Proposed branch: lp:~sergei.glushchenko/percona-server/51-ST-27220-bug1042946
Merge into: lp:percona-server/5.1
Diff against target: 10 lines (+1/-0)
1 file modified
Percona-Server/sql/rpl_utility.cc (+1/-0)
To merge this branch: bzr merge lp:~sergei.glushchenko/percona-server/51-ST-27220-bug1042946
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Vlad Lesin (community) g2 Approve
Review via email: mp+141728@code.launchpad.net

Description of the change

This is a fix for memory leak issue in PS 5.1 and MySQL 5.1 related to deferred events management. Due to missing update of last_added pointer when deferred events container been cleaned subsequent event can be forgotten to delete.
See details at https://bugs.launchpad.net/percona-server/+bug/1042946/comments/32

http://jenkins.percona.com/view/PS%205.1/job/percona-server-5.1-param/481/

To post a comment you must log in.
Revision history for this message
Vlad Lesin (vlad-lesin) wrote :

I've read your explanation and explored the code. It seems you a right, the "last_added" pointer the deleted object can be the cause of the leak.

review: Approve (g2)
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Percona-Server/sql/rpl_utility.cc'
2--- Percona-Server/sql/rpl_utility.cc 2012-04-20 16:41:20 +0000
3+++ Percona-Server/sql/rpl_utility.cc 2013-01-03 10:12:57 +0000
4@@ -283,6 +283,7 @@
5 if (array.elements > array.max_element)
6 freeze_size(&array);
7 reset_dynamic(&array);
8+ last_added= NULL;
9 }
10 }
11

Subscribers

People subscribed via source and target branches