Code review comment for lp:~sergei.glushchenko/percona-server/5.6-ps-bug1309026
Revision history for this message
| Laurynas Biveinis (laurynas-biveinis) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
I wonder about the PFS instrumentation implications of the fix.
Before, PFS tracked the follower thread twice for the same time span: once for the follower thread itself, the waits on m_lock_done and m_cond_done; and at the same time, for the leader thread in the follower context, whatever is done in ha_commit_low.
With the fix, we lose m_lock_done and m_cond_done accounting?