Merge lp:~sergei.glushchenko/percona-server/5.6-ps-bug1282008 into lp:percona-server/5.6

Proposed by Sergei Glushchenko
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 562
Proposed branch: lp:~sergei.glushchenko/percona-server/5.6-ps-bug1282008
Merge into: lp:percona-server/5.6
Diff against target: 32 lines (+7/-1)
1 file modified
sql/threadpool_common.cc (+7/-1)
To merge this branch: bzr merge lp:~sergei.glushchenko/percona-server/5.6-ps-bug1282008
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+210140@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Looks good, setting to WiP if it needs a re-merge from 5.5.

review: Needs Information
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

The previous MP had a thd_prepare_connection call and this one is an automerge from 5.5?

review: Needs Information
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

That is weird because I was sure I MP'ed version without thd_prepare_connection. The difference is that thd_prepare_connection invokes lex_start. I had not much luck making it work, but I didn't investigated deeper.

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sql/threadpool_common.cc'
2--- sql/threadpool_common.cc 2013-12-02 12:25:50 +0000
3+++ sql/threadpool_common.cc 2014-03-15 08:32:12 +0000
4@@ -24,6 +24,7 @@
5 #include <debug_sync.h>
6 #include <threadpool.h>
7 #include <global_threads.h>
8+#include <probes_mysql.h>
9
10
11 /* Threadpool parameters */
12@@ -212,7 +213,9 @@
13
14 if (!setup_connection_thread_globals(thd))
15 {
16- if (!login_connection(thd))
17+ bool rc= login_connection(thd);
18+ MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd);
19+ if (!rc)
20 {
21 prepare_new_connection_state(thd);
22
23@@ -229,6 +232,9 @@
24 thd->m_server_idle= true;
25 threadpool_init_net_server_extension(thd);
26 }
27+
28+ MYSQL_CONNECTION_START(thd->thread_id, &thd->security_ctx->priv_user[0],
29+ (char *) thd->security_ctx->host_or_ip);
30 }
31 }
32 worker_context.restore();

Subscribers

People subscribed via source and target branches