Merge lp:~sergei.glushchenko/percona-server/5.6-ST36241-ps-bug1011047 into lp:percona-server/5.6

Proposed by Sergei Glushchenko
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 493
Proposed branch: lp:~sergei.glushchenko/percona-server/5.6-ST36241-ps-bug1011047
Merge into: lp:percona-server/5.6
Diff against target: 72 lines (+34/-5)
4 files modified
Percona-Server/mysql-test/r/bug1011047.result (+10/-0)
Percona-Server/mysql-test/t/bug1011047-master.opt (+1/-0)
Percona-Server/mysql-test/t/bug1011047.test (+18/-0)
Percona-Server/sql/mysqld.cc (+5/-5)
To merge this branch: bzr merge lp:~sergei.glushchenko/percona-server/5.6-ST36241-ps-bug1011047
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+193206@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

I'd also like to note that I turned on example plugin in cake options for 5.6 builds in our Jenkins. It is turned off by default in 5.6.

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'Percona-Server/mysql-test/r/bug1011047.result'
2--- Percona-Server/mysql-test/r/bug1011047.result 1970-01-01 00:00:00 +0000
3+++ Percona-Server/mysql-test/r/bug1011047.result 2013-10-30 10:01:33 +0000
4@@ -0,0 +1,10 @@
5+show variables like 'userstat%';
6+Variable_name Value
7+userstat ON
8+INSTALL PLUGIN example SONAME 'ha_example.so';
9+show variables like 'userstat%';
10+Variable_name Value
11+userstat ON
12+CREATE TABLE t1(a int) ENGINE=EXAMPLE;
13+DROP TABLE t1;
14+UNINSTALL PLUGIN example;
15
16=== added file 'Percona-Server/mysql-test/t/bug1011047-master.opt'
17--- Percona-Server/mysql-test/t/bug1011047-master.opt 1970-01-01 00:00:00 +0000
18+++ Percona-Server/mysql-test/t/bug1011047-master.opt 2013-10-30 10:01:33 +0000
19@@ -0,0 +1,1 @@
20+$EXAMPLE_PLUGIN_OPT --userstat
21\ No newline at end of file
22
23=== added file 'Percona-Server/mysql-test/t/bug1011047.test'
24--- Percona-Server/mysql-test/t/bug1011047.test 1970-01-01 00:00:00 +0000
25+++ Percona-Server/mysql-test/t/bug1011047.test 2013-10-30 10:01:33 +0000
26@@ -0,0 +1,18 @@
27+#
28+# Bug 1011047: mysqld can't startup when a plugin was installed
29+#
30+
31+--source include/have_example_plugin.inc
32+
33+show variables like 'userstat%';
34+
35+--replace_regex /\.dll/.so/
36+eval INSTALL PLUGIN example SONAME '$EXAMPLE_PLUGIN';
37+
38+--source include/restart_mysqld.inc
39+show variables like 'userstat%';
40+
41+CREATE TABLE t1(a int) ENGINE=EXAMPLE;
42+DROP TABLE t1;
43+
44+UNINSTALL PLUGIN example;
45
46=== modified file 'Percona-Server/sql/mysqld.cc'
47--- Percona-Server/sql/mysqld.cc 2013-10-23 08:52:03 +0000
48+++ Percona-Server/sql/mysqld.cc 2013-10-30 10:01:33 +0000
49@@ -4707,6 +4707,11 @@
50 init_slave_list();
51 #endif
52
53+#ifndef EMBEDDED_LIBRARY
54+ init_global_table_stats();
55+ init_global_index_stats();
56+#endif
57+
58 /* Setup logs */
59
60 /*
61@@ -4974,11 +4979,6 @@
62 if (!DEFAULT_ERRMSGS[0][0])
63 unireg_abort(1);
64
65-#ifndef EMBEDDED_LIBRARY
66- init_global_table_stats();
67- init_global_index_stats();
68-#endif
69-
70 /* We have to initialize the storage engines before CSV logging */
71
72 if (ha_init())

Subscribers

People subscribed via source and target branches