Merge lp:~sergei.glushchenko/percona-server/5.5-ps-bug1282008 into lp:percona-server/5.5

[Sergei Glushchenko]

Notify audit plugin using MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT.

http://jenkins.percona.com/view/PS%205.5/job/percona-server-5.5-param/961/

[Laurynas Biveinis (laurynas-biveinis)]

Looks OK, but there is one more difference from the one thread per connection code path: MYSQL_CONNECTION_START callback for DTrace. Is that one missing too?

review: Needs Information

[Sergei Glushchenko (sergei.glushchenko)]

Indeed MYSQL_CONNECTION_START is missing.

http://jenkins.percona.com/view/PS%205.5/job/percona-server-5.5-param/976/

[Laurynas Biveinis (laurynas-biveinis)]

Looks good. Consider adding a testcase for this to the audit plugin MP, if you have to revisit it.

review: Approve

=== modified file 'sql/threadpool_common.cc'
--- sql/threadpool_common.cc	2013-12-02 12:17:20 +0000
+++ sql/threadpool_common.cc	2014-03-15 08:25:22 +0000
@@ -23,6 +23,7 @@
 #include <sql_audit.h>
 #include <debug_sync.h>
 #include <threadpool.h>
+#include <probes_mysql.h>
 
 
 /* Threadpool parameters */
@@ -147,7 +148,9 @@
 
   if (!setup_connection_thread_globals(thd))
   {
-    if (!login_connection(thd))
+    bool rc= login_connection(thd);
+    MYSQL_AUDIT_NOTIFY_CONNECTION_CONNECT(thd);
+    if (!rc)
     {
       prepare_new_connection_state(thd);
       
@@ -161,6 +164,9 @@
         thd->net.reading_or_writing= 1;
         thd->skip_wait_timeout= true;
       }
+
+      MYSQL_CONNECTION_START(thd->thread_id, &thd->security_ctx->priv_user[0],
+                             (char *) thd->security_ctx->host_or_ip);
     }
   }
   worker_context.restore();