Code review comment for lp:~sergei.glushchenko/percona-server/5.5-ps-blueprint-audit-log-streaming

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

    - Launchpad says the prerequisite branch does not exist. Is the
      prerequisite branch the CSV/JSON one and was it repushed after
      this branch was pushed? If so, rebase this on the updated prereq
      branch to avoid any surprises.
    - Bump plugin_version (for this and for the CSV/JSON MP, already merged)
    - Let's split audit_log.test to audit_log_foo.test, where instead
      of each restart each split testcase has -master.opt file that
      sets up auditing.
    - 1283: s/hadler/handler
    - 1321: "The string that will be prepended to each log message, if
      syslog handler is used"
    - 1333: clarify it's the syslog facility, not something else,
      i.e. "The syslog facility to use, if syslog handler is used"
      (might need further editing)
    - Clarify that strategy, buffer_size, rotate_on_size, rotations,
      file only apply to file handler. Add this to blueprint (for docs
      updating)
    - Add to blueprint (for the later documenting) what does
      "flushing" the syslog mean.
    - TYPELIBs are formatted with source code indentation of 4 whereas
      the rest use 2

review: Needs Fixing

« Back to merge proposal