Merge lp:~sergei.glushchenko/percona-server/5.5-BT40550-ps-bug1166938 into lp:percona-server/5.5

Proposed by Sergei Glushchenko on 2014-05-13
Status: Merged
Approved by: Laurynas Biveinis on 2014-05-15
Approved revision: 647
Merged at revision: 658
Proposed branch: lp:~sergei.glushchenko/percona-server/5.5-BT40550-ps-bug1166938
Merge into: lp:percona-server/5.5
Diff against target: 18 lines (+7/-2)
1 file modified
plugin/percona-pam-for-mysql/src/auth_pam_compat.c (+7/-2)
To merge this branch: bzr merge lp:~sergei.glushchenko/percona-server/5.5-BT40550-ps-bug1166938
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve on 2014-05-15
Registry Administrators 2014-05-13 Pending
Review via email: mp+219368@code.launchpad.net
To post a comment you must log in.

Same comment as for the percona-pam-for-mysql review. If only the comment will be changed, no need for new Jenkins.

review: Needs Fixing

changed comment

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugin/percona-pam-for-mysql/src/auth_pam_compat.c'
2--- plugin/percona-pam-for-mysql/src/auth_pam_compat.c 2013-12-23 22:05:57 +0000
3+++ plugin/percona-pam-for-mysql/src/auth_pam_compat.c 2014-05-14 13:37:40 +0000
4@@ -95,8 +95,13 @@
5 strncpy(resp->resp, (char *)pkt, pkt_len);
6 resp->resp[pkt_len]= '\0';
7
8- /* we could only guess whether password was used or not */
9- data->info->password_used= PASSWORD_USED_NO_MENTION;
10+ /**
11+ we could only guess whether password was used or not
12+ normally we would set PASSWORD_USED_NO_MENTION but
13+ because of http://bugs.mysql.com/bug.php?id=72536
14+ we set PASSWORD_USED_YES.
15+ */
16+ data->info->password_used= PASSWORD_USED_YES;
17 ++(*num_talks);
18 }
19

Subscribers

People subscribed via source and target branches